From: "Tom 'spot' Callaway" <tcallawa@redhat.com>
To: sparclinux@vger.kernel.org
Subject: Re: div, udiv, mul, umul, rem, urem broken again?!?
Date: Wed, 05 Oct 2005 22:17:40 +0000 [thread overview]
Message-ID: <1128550660.2140.105.camel@localhost.localdomain> (raw)
In-Reply-To: <1128550254.2140.103.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 320 bytes --]
I accidentally sent a broken version of this patch, the attached version works.
~spot
--
Tom "spot" Callaway: Red Hat Senior Sales Engineer || GPG ID: 93054260
Fedora Extras Steering Committee Member (RPM Standards and Practices)
Aurora Linux Project Leader: http://auroralinux.org
Lemurs, llamas, and sparcs, oh my!
[-- Attachment #2: module-init-tools-3.2-sparc.patch --]
[-- Type: text/x-patch, Size: 2024 bytes --]
--- module-init-tools-3.2-pre9/depmod.c.BAD 2005-10-05 17:10:39.026053905 -0400
+++ module-init-tools-3.2-pre9/depmod.c 2005-10-05 18:09:11.354098881 -0400
@@ -103,10 +103,24 @@ void add_symbol(const char *name, struct
static int print_unknown;
-struct module *find_symbol(const char *name, const char *modname, int weak)
+struct module *find_symbol(char *name, const char *modname, int weak)
{
struct symbol *s;
+ /* Handle the wacky sparc cases */
+ if (strcmp(name, ".div") == 0)
+ strncpy(name, "_Div", sizeof(name));
+ if (strcmp(name, ".udiv") == 0)
+ strncpy(name, "_Udiv", sizeof(name));
+ if (strcmp(name, ".mul") == 0)
+ strncpy(name, "_Mul", sizeof(name));
+ if (strcmp(name, ".umul") == 0)
+ strncpy(name, "_Umul", sizeof(name));
+ if (strcmp(name, ".rem") == 0)
+ strncpy(name, "_Rem", sizeof(name));
+ if (strcmp(name, ".urem") == 0)
+ strncpy(name, "_Urem", sizeof(name));
+
/* For our purposes, .foo matches foo. PPC64 needs this. */
if (name[0] == '.')
name++;
--- module-init-tools-3.2-pre9/moduleops_core.c.BAD 2005-10-05 18:10:18.321918225 -0400
+++ module-init-tools-3.2-pre9/moduleops_core.c 2005-10-05 18:10:12.533798153 -0400
@@ -118,7 +118,7 @@ static void PERBIT(calculate_deps)(struc
for (i = 1; i < size / sizeof(syms[0]); i++) {
if (END(syms[i].st_shndx, module->conv) == SHN_UNDEF) {
/* Look for symbol */
- const char *name;
+ char *name;
struct module *owner;
int weak;
--- module-init-tools-3.2-pre9/depmod.h.BAD 2005-10-05 18:19:53.451485241 -0400
+++ module-init-tools-3.2-pre9/depmod.h 2005-10-05 18:19:58.472721897 -0400
@@ -12,7 +12,7 @@ void *do_nofail(void *ptr, const char *f
#define NOFAIL(ptr) do_nofail((ptr), __FILE__, __LINE__, #ptr)
void add_symbol(const char *name, struct module *owner);
-struct module *find_symbol(const char *name, const char *modname, int weak);
+struct module *find_symbol(char *name, const char *modname, int weak);
void add_dep(struct module *mod, struct module *depends_on);
/* I hate strcmp. */
next prev parent reply other threads:[~2005-10-05 22:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-05 22:10 div, udiv, mul, umul, rem, urem broken again?!? Tom 'spot' Callaway
2005-10-05 22:17 ` Tom 'spot' Callaway [this message]
2005-10-06 0:24 ` David S. Miller
2005-10-06 13:21 ` Tom 'spot' Callaway
2005-10-10 10:20 ` Rusty Russell
2005-10-10 14:35 ` Tom 'spot' Callaway
2005-10-10 18:22 ` David S. Miller
2005-10-11 10:03 ` Rusty Russell
2005-11-06 0:40 ` David S. Miller
2005-11-06 4:13 ` Tom 'spot' Callaway
2005-11-06 6:27 ` Rusty Russell
2005-11-06 20:56 ` David S. Miller
2005-11-06 20:58 ` David S. Miller
2006-02-08 20:25 ` Martin Habets
2006-02-08 20:51 ` Tom 'spot' Callaway
2006-02-08 20:56 ` Al Viro
2006-02-09 1:29 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1128550660.2140.105.camel@localhost.localdomain \
--to=tcallawa@redhat.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.