All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: sparclinux@vger.kernel.org
Subject: Re: div, udiv, mul, umul, rem, urem broken again?!?
Date: Sun, 06 Nov 2005 06:27:20 +0000	[thread overview]
Message-ID: <1131258440.12902.28.camel@localhost.localdomain> (raw)
In-Reply-To: <1128550254.2140.103.camel@localhost.localdomain>

On Sat, 2005-11-05 at 16:40 -0800, David S. Miller wrote:
> From: Rusty Russell <rusty@rustcorp.com.au>
> Date: Tue, 11 Oct 2005 20:03:36 +1000
> 
> > > > #define __EXPORT_SPECIAL_SYMBOL(name, sym) \
> > > > 	static const char __kstrtab_##name[]			\
> > > > 	__attribute__((section("__ksymtab_strings")))		\
> > > > 	= MODULE_SYMBOL_PREFIX #name;    			\
> > > > 	static const struct kernel_symbol __ksymtab_##name	\
> > > > 	__attribute_used__					\
> > > > 	__attribute__((section("__ksymtab"), unused))	\
> > > > 	= { (unsigned long)&sym, __kstrtab_##name }
> > > > 
> > > > Note, PPC64 still needs the dot hack because it changes the name of
> > > > *every* function symbol.
> 
> How is this special export macro supposed to work?

Argh, it would need to use the alias trick, yes.  As I said, untested.
But, looking in 2.6.12, sparc already did this aliasing?

So my question is (I missed the beginning of this thread), why do you
want to avoid the simple "omit the . at the front" name mangling scheme
which modpost, kernel/module.c and module-init-tools already understand,
and use a different mangling scheme?  Name clash with something else?
Why is "_Udiv" a better name than "udiv"?

And we shouldn't make it ifdef __sparc__ in module-init-tools anyway,
since depmod is supposed to be platform neutral.  Would have to be
special case on ELF header or on names.

Rusty.		
-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman


  parent reply	other threads:[~2005-11-06  6:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-05 22:10 div, udiv, mul, umul, rem, urem broken again?!? Tom 'spot' Callaway
2005-10-05 22:17 ` Tom 'spot' Callaway
2005-10-06  0:24 ` David S. Miller
2005-10-06 13:21 ` Tom 'spot' Callaway
2005-10-10 10:20 ` Rusty Russell
2005-10-10 14:35 ` Tom 'spot' Callaway
2005-10-10 18:22 ` David S. Miller
2005-10-11 10:03 ` Rusty Russell
2005-11-06  0:40 ` David S. Miller
2005-11-06  4:13 ` Tom 'spot' Callaway
2005-11-06  6:27 ` Rusty Russell [this message]
2005-11-06 20:56 ` David S. Miller
2005-11-06 20:58 ` David S. Miller
2006-02-08 20:25 ` Martin Habets
2006-02-08 20:51 ` Tom 'spot' Callaway
2006-02-08 20:56 ` Al Viro
2006-02-09  1:29 ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1131258440.12902.28.camel@localhost.localdomain \
    --to=rusty@rustcorp.com.au \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.