Re: [PATCH] fix iptables on systems with discontiguous processor ids

[Bart De Schuymer <bdschuym@pandora.be>]

Op di, 11-10-2005 te 12:44 +0200, schreef Harald Welte:
> On Mon, Oct 10, 2005 at 02:15:18PM -0700, David S. Miller wrote:
> > Ebtables needs it too.  "git grep num_possible_cpus" shows all
> > of the users in the whole tree, %80 of which are the netfilter
> > cases we're fixing here :-)
> 
> mh. I'm not very familiar with the ebtables specific changes, and
> apparently it differs quite a bit in counter handling.

Counters are allocated separately from the rules so that rules don't
need to be duplicated for each cpu. But the fix for ebtables should be
very similar to the one for iptables.

> Anyway, I've tried to come up with a patch that also includes ebtables.
> 
> Bart: Could you please comment on it? If you have missed the previous
> thread: some systems have smp processor id's "0 2" but no "1", e.g.
> num_possible_cpus() is 2 (and we allocate two rulesets), but then we try
> to index it with '2', e.g. the non-existing 3rd copy.

I will once I can see it :)

cheers,
Bart