Re: qlogicpti kernel panic

[Peter Jones <pjones@redhat.com>]

On Fri, 2005-10-14 at 12:43 -0700, David S. Miller wrote:
> From: "Tom 'spot' Callaway" <tcallawa@redhat.com>
> Date: Fri, 14 Oct 2005 13:53:18 -0500
> 
> > I got a kernel panic on 2.6.14-rc4-git2 on the e4500 (8 CPU, 8GB mem). 
> > 
> > It's hitting the BUG() case in drivers/scsi/qlogicpti.c in ourdone():
> > 
> > 1146                if (Cmnd->cmnd[0] = 0x12 && ok) {
> > 1147                        unsigned char *iqd;
> > 1148
> > 1149                        if (Cmnd->use_sg != 0)
> > 1150                                BUG();
> > 
> > I can't find any other SCSI drivers doing this sort of check, then
> > again, no other SCSI driver seems to act like qlogicpti. Adding a printk
> > there shows that Cmnd->use_sg is 1.
> 
> That piece of code needs to be rewritten.  That situation is perfectly
> valid.  It wants to sniff the SCSI command result buffer, but that
> isn't the portable way to do it at all.

Roughly, what's the portable way?

The closest thing I see to something that does something like this, but
handles both sg and a single buffer is scsi_debug.c's
fill_from_dev_buffer (which is of course not exported, nor should it
be).

Is the right way something along those lines?

-- 
  Peter