All of lore.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: sparclinux@vger.kernel.org
Subject: Re: qlogicpti kernel panic
Date: Fri, 14 Oct 2005 19:43:21 +0000	[thread overview]
Message-ID: <20051014.124321.34718872.davem@davemloft.net> (raw)
In-Reply-To: <1129315998.2243.35.camel@localhost.localdomain>

From: "Tom 'spot' Callaway" <tcallawa@redhat.com>
Date: Fri, 14 Oct 2005 13:53:18 -0500

> I got a kernel panic on 2.6.14-rc4-git2 on the e4500 (8 CPU, 8GB mem). 
> 
> It's hitting the BUG() case in drivers/scsi/qlogicpti.c in ourdone():
> 
> 1146                if (Cmnd->cmnd[0] = 0x12 && ok) {
> 1147                        unsigned char *iqd;
> 1148
> 1149                        if (Cmnd->use_sg != 0)
> 1150                                BUG();
> 
> I can't find any other SCSI drivers doing this sort of check, then
> again, no other SCSI driver seems to act like qlogicpti. Adding a printk
> there shows that Cmnd->use_sg is 1.

That piece of code needs to be rewritten.  That situation is perfectly
valid.  It wants to sniff the SCSI command result buffer, but that
isn't the portable way to do it at all.

  reply	other threads:[~2005-10-14 19:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-14 18:53 qlogicpti kernel panic Tom 'spot' Callaway
2005-10-14 19:43 ` David S. Miller [this message]
2005-10-14 20:49 ` Peter Jones
2005-10-14 21:07 ` Peter Jones
2005-10-14 21:42 ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051014.124321.34718872.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.