From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Avi Kivity <avi@argo.co.il>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: PATCH: EDAC atomic scrub operations
Date: Sat, 15 Oct 2005 20:44:02 +0100 [thread overview]
Message-ID: <1129405443.17923.23.camel@localhost.localdomain> (raw)
In-Reply-To: <4351530C.3070907@argo.co.il>
On Sad, 2005-10-15 at 21:05 +0200, Avi Kivity wrote:
> >+static __inline__ void atomic_scrub(unsigned long *virt_addr, u32 size)
> >+{
> >+ u32 i;
> >+ for (i = 0; i < size / 4; i++, virt_addr++)
> >
> >
> (size+7) / 8? or increment virt_addr by 0.5? :)
>
> >+ /* Very carefully read and write to memory atomically
> >+ * so we are interrupt, DMA and SMP safe.
> >+ */
> >+ __asm__ __volatile__("lock; addl $0, %0"::"m"(*virt_addr));
> >
> >
> shouldn't that be addq?
Should be u32 * for the address used. Well spotted.
Alan
prev parent reply other threads:[~2005-10-15 19:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-15 18:55 PATCH: EDAC atomic scrub operations Alan Cox
2005-10-15 19:05 ` Avi Kivity
2005-10-15 19:44 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1129405443.17923.23.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=avi@argo.co.il \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.