From: Dave Hansen <haveblue@us.ibm.com>
To: Robin Holt <holt@sgi.com>
Cc: Greg KH <greg@kroah.com>, ia64 list <linux-ia64@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
hch@infradead.org, jgarzik@pobox.com,
William Lee Irwin III <wli@holomorphy.com>,
Jack Steiner <steiner@americas.sgi.com>
Subject: Re: [Patch 2/3] Export get_one_pte_map.
Date: Mon, 17 Oct 2005 11:41:52 +0000 [thread overview]
Message-ID: <1129549312.32658.32.camel@localhost> (raw)
In-Reply-To: <20051017113131.GA30898@lnx-holt.americas.sgi.com>
On Mon, 2005-10-17 at 06:31 -0500, Robin Holt wrote:
> On Fri, Oct 14, 2005 at 02:30:38PM -0700, Greg KH wrote:
> > On Fri, Oct 14, 2005 at 02:22:25PM -0500, Robin Holt wrote:
> > > +EXPORT_SYMBOL(get_one_pte_map);
> >
> > EXPORT_SYMBOL_GPL() ?
>
> Not sure why it would fall that way. Looking at the directory,
> I get:
Most of the VM stuff in those directories that you're referring to are
old, crusty exports, from the days before _GPL. We've left them to be
polite, but if many of them were recreated today, they'd certainly be
_GPL.
We do not want random external modules poking at PTEs, nor should a
module need to know such kernel internals as the semantics of
PTE_HIGHMEM. I think it needs _GPL.
BTW, your new patches look much nicer than the last set. Thanks for
making the changes I suggested.
-- Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <haveblue@us.ibm.com>
To: Robin Holt <holt@sgi.com>
Cc: Greg KH <greg@kroah.com>, ia64 list <linux-ia64@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
hch@infradead.org, jgarzik@pobox.com,
William Lee Irwin III <wli@holomorphy.com>,
Jack Steiner <steiner@americas.sgi.com>
Subject: Re: [Patch 2/3] Export get_one_pte_map.
Date: Mon, 17 Oct 2005 13:41:52 +0200 [thread overview]
Message-ID: <1129549312.32658.32.camel@localhost> (raw)
In-Reply-To: <20051017113131.GA30898@lnx-holt.americas.sgi.com>
On Mon, 2005-10-17 at 06:31 -0500, Robin Holt wrote:
> On Fri, Oct 14, 2005 at 02:30:38PM -0700, Greg KH wrote:
> > On Fri, Oct 14, 2005 at 02:22:25PM -0500, Robin Holt wrote:
> > > +EXPORT_SYMBOL(get_one_pte_map);
> >
> > EXPORT_SYMBOL_GPL() ?
>
> Not sure why it would fall that way. Looking at the directory,
> I get:
Most of the VM stuff in those directories that you're referring to are
old, crusty exports, from the days before _GPL. We've left them to be
polite, but if many of them were recreated today, they'd certainly be
_GPL.
We do not want random external modules poking at PTEs, nor should a
module need to know such kernel internals as the semantics of
PTE_HIGHMEM. I think it needs _GPL.
BTW, your new patches look much nicer than the last set. Thanks for
making the changes I suggested.
-- Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <haveblue@us.ibm.com>
To: Robin Holt <holt@sgi.com>
Cc: Greg KH <greg@kroah.com>, ia64 list <linux-ia64@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
hch@infradead.org, jgarzik@pobox.com,
William Lee Irwin III <wli@holomorphy.com>,
Jack Steiner <steiner@americas.sgi.com>
Subject: Re: [Patch 2/3] Export get_one_pte_map.
Date: Mon, 17 Oct 2005 13:41:52 +0200 [thread overview]
Message-ID: <1129549312.32658.32.camel@localhost> (raw)
In-Reply-To: <20051017113131.GA30898@lnx-holt.americas.sgi.com>
On Mon, 2005-10-17 at 06:31 -0500, Robin Holt wrote:
> On Fri, Oct 14, 2005 at 02:30:38PM -0700, Greg KH wrote:
> > On Fri, Oct 14, 2005 at 02:22:25PM -0500, Robin Holt wrote:
> > > +EXPORT_SYMBOL(get_one_pte_map);
> >
> > EXPORT_SYMBOL_GPL() ?
>
> Not sure why it would fall that way. Looking at the directory,
> I get:
Most of the VM stuff in those directories that you're referring to are
old, crusty exports, from the days before _GPL. We've left them to be
polite, but if many of them were recreated today, they'd certainly be
_GPL.
We do not want random external modules poking at PTEs, nor should a
module need to know such kernel internals as the semantics of
PTE_HIGHMEM. I think it needs _GPL.
BTW, your new patches look much nicer than the last set. Thanks for
making the changes I suggested.
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-10-17 11:41 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-14 19:21 [Patch 0/3] SGI Altix and ia64 special memory support Robin Holt
2005-10-14 19:21 ` Robin Holt
2005-10-14 19:21 ` Robin Holt
2005-10-14 19:21 ` [Patch 1/3] Add a NOPAGE_FAULTED flag Robin Holt
2005-10-14 19:21 ` Robin Holt
2005-10-14 19:21 ` Robin Holt
2005-10-14 19:22 ` [Patch 2/3] Export get_one_pte_map Robin Holt
2005-10-14 19:22 ` Robin Holt
2005-10-14 19:22 ` Robin Holt
2005-10-14 21:30 ` Greg KH
2005-10-14 21:30 ` Greg KH
2005-10-14 21:30 ` Greg KH
2005-10-17 11:31 ` Robin Holt
2005-10-17 11:31 ` Robin Holt
2005-10-17 11:31 ` Robin Holt
2005-10-17 11:36 ` Christoph Hellwig
2005-10-17 11:36 ` Christoph Hellwig
2005-10-17 11:36 ` Christoph Hellwig
2005-10-17 11:39 ` Robin Holt
2005-10-17 11:39 ` Robin Holt
2005-10-17 11:39 ` Robin Holt
2005-10-17 11:41 ` Dave Hansen [this message]
2005-10-17 11:41 ` Dave Hansen
2005-10-17 11:41 ` Dave Hansen
2005-10-17 11:47 ` Robin Holt
2005-10-17 11:47 ` Robin Holt
2005-10-17 11:47 ` Robin Holt
2005-10-17 12:33 ` Hugh Dickins
2005-10-17 12:33 ` Hugh Dickins
2005-10-17 12:33 ` Hugh Dickins
2005-10-17 15:14 ` Robin Holt
2005-10-17 15:14 ` Robin Holt
2005-10-17 15:14 ` Robin Holt
2005-10-17 15:20 ` Greg KH
2005-10-17 15:20 ` Greg KH
2005-10-17 15:20 ` Greg KH
2005-10-17 15:56 ` Robin Holt
2005-10-17 15:56 ` Robin Holt
2005-10-17 15:56 ` Robin Holt
2005-10-17 16:05 ` Greg KH
2005-10-17 16:05 ` Greg KH
2005-10-17 16:05 ` Greg KH
2005-10-17 16:09 ` Dave Hansen
2005-10-17 16:09 ` Dave Hansen
2005-10-17 16:09 ` Dave Hansen
2005-10-17 16:14 ` Hugh Dickins
2005-10-17 16:14 ` Hugh Dickins
2005-10-17 16:14 ` Hugh Dickins
2005-10-17 20:53 ` Andrew Morton
2005-10-17 20:53 ` Andrew Morton
2005-10-17 20:53 ` Andrew Morton
2005-10-18 8:48 ` Carsten Otte
2005-10-18 8:48 ` Carsten Otte
2005-10-18 8:48 ` Carsten Otte
2005-10-17 15:59 ` Hugh Dickins
2005-10-17 15:59 ` Hugh Dickins
2005-10-17 15:59 ` Hugh Dickins
2005-10-17 20:25 ` Robin Holt
2005-10-17 20:25 ` Robin Holt
2005-10-17 20:25 ` Robin Holt
2005-10-17 20:59 ` Hugh Dickins
2005-10-17 20:59 ` Hugh Dickins
2005-10-17 20:59 ` Hugh Dickins
2005-10-18 23:28 ` William Lee Irwin III
2005-10-18 23:28 ` William Lee Irwin III
2005-10-18 23:28 ` William Lee Irwin III
2005-10-14 19:22 ` [Patch 3/3] Special Memory (mspec) driver Robin Holt
2005-10-14 19:22 ` Robin Holt
2005-10-14 19:22 ` Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1129549312.32658.32.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=greg@kroah.com \
--cc=hch@infradead.org \
--cc=holt@sgi.com \
--cc=jgarzik@pobox.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=steiner@americas.sgi.com \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.