[PATCH] [VT] Fix for python breakge

[PATCH] [VT] Fix for python breakge

[Kamble, Nitin A]

Keir, Ian,

The VMX builder python code is broken due to recent changes. 
It gives this error while trying to start a VMX guest:
"Error: Error creating domain: function takes exactly 7 arguments (6 given)"

This patch to xen-upstream fixes the issue.

Signed-Off-By: Nitin A Kamble <nitin.a.kamble@intel.com>
diff -r 7c951e3eb5ab4ab0a6de33a8f831c828d16b1ad4 tools/python/xen/lowlevel/xc/xc.c
--- a/tools/python/xen/lowlevel/xc/xc.c Wed Oct 19 10:53:00 2005
+++ b/tools/python/xen/lowlevel/xc/xc.c Wed Oct 19 15:44:26 2005
@@ -426,7 +426,7 @@
     static char *kwd_list[] = { "dom", "control_evtchn", "store_evtchn",
                                 "memsize", "image", "flags", "vcpus", NULL };

-    if ( !PyArg_ParseTupleAndKeywords(args, kwds, "iiiisii", kwd_list,
+    if ( !PyArg_ParseTupleAndKeywords(args, kwds, "iiiis|ii", kwd_list,
                                       &dom, &control_evtchn, &store_evtchn,
                                       &memsize, &image, &flags, &vcpus) )
         return NULL;

Thanks & Regards,
Nitin
--------------------------------------------------------------------------
Open Source Technology Center, Intel Corp

Re: [PATCH] [VT] Fix for python breakge

[Khoa Huynh]

"Kamble, Nitin A" <nitin.a.kamble@intel.com> wrote on 10/20/2005 07:31:45
PM:

> Keir, Ian,
>
> The VMX builder python code is broken due to recent changes.
> It gives this error while trying to start a VMX guest:
> "Error: Error creating domain: function takes exactly 7 arguments (6
given)"
>
> This patch to xen-upstream fixes the issue.
>
> Signed-Off-By: Nitin A Kamble <nitin.a.kamble@intel.com>
> diff -r 7c951e3eb5ab4ab0a6de33a8f831c828d16b1ad4
> tools/python/xen/lowlevel/xc/xc.c
> --- a/tools/python/xen/lowlevel/xc/xc.c Wed Oct 19 10:53:00 2005
> +++ b/tools/python/xen/lowlevel/xc/xc.c Wed Oct 19 15:44:26 2005
> @@ -426,7 +426,7 @@
>      static char *kwd_list[] = { "dom", "control_evtchn", "store_evtchn",
>                                  "memsize", "image", "flags", "vcpus",
NULL };
>
> -    if ( !PyArg_ParseTupleAndKeywords(args, kwds, "iiiisii", kwd_list,
> +    if ( !PyArg_ParseTupleAndKeywords(args, kwds, "iiiis|ii", kwd_list,
>                                        &dom, &control_evtchn,
&store_evtchn,
>                                        &memsize, &image, &flags, &vcpus)
)
>          return NULL;

I think this patch was included in a patch submitted by Xin Li a couple
days ago.  I applied Li's patch and it fixed the problem for me.
Thanks.

Regards,

Khoa

RE: [PATCH] [VT] Fix for python breakge

[Kamble, Nitin A]

Xin's patch is making vcpus argument mandatory. This is not right. Xin
can you fix your patch to make it optinal?

Thanks & Regards,
Nitin
------------------------------------------------------------------------
-----------
Open Source Technology Center, Intel Corp

>-----Original Message-----
>From: Khoa Huynh [mailto:khoa@us.ibm.com]
>Sent: Friday, October 21, 2005 10:16 AM
>To: Kamble, Nitin A
>Cc: Keir Fraser; Ian Pratt; xen-devel; xen-devel-
>bounces@lists.xensource.com; Li, Xin B
>Subject: Re: [Xen-devel] [PATCH] [VT] Fix for python breakge
>
>I think this patch was included in a patch submitted by Xin Li a couple
>days ago.  I applied Li's patch and it fixed the problem for me.
>Thanks.
>
>Regards,
>
>Khoa
>

RE: [PATCH] [VT] Fix for python breakge

[Li, Xin B]

Ok, I will do that.
-Xin

>-----Original Message-----
>From: Kamble, Nitin A 
>Sent: 2005年10月22日 4:35
>To: Khoa Huynh
>Cc: Keir Fraser; Ian Pratt; xen-devel; 
>xen-devel-bounces@lists.xensource.com; Li, Xin B
>Subject: RE: [Xen-devel] [PATCH] [VT] Fix for python breakge
>
>Xin's patch is making vcpus argument mandatory. This is not 
>right. Xin can you fix your patch to make it optinal?
>
>Thanks & Regards,
>Nitin
>---------------------------------------------------------------
>--------------------
>Open Source Technology Center, Intel Corp
>
>>-----Original Message-----
>>From: Khoa Huynh [mailto:khoa@us.ibm.com]
>>Sent: Friday, October 21, 2005 10:16 AM
>>To: Kamble, Nitin A
>>Cc: Keir Fraser; Ian Pratt; xen-devel; xen-devel-
>>bounces@lists.xensource.com; Li, Xin B
>>Subject: Re: [Xen-devel] [PATCH] [VT] Fix for python breakge
>>
>>I think this patch was included in a patch submitted by Xin 
>Li a couple
>>days ago.  I applied Li's patch and it fixed the problem for me.
>>Thanks.
>>
>>Regards,
>>
>>Khoa
>>
>
>

RE: [PATCH] [VT] Fix for python breakge

[Ted Kaczmarek]

On Fri, 2005-10-21 at 13:35 -0700, Kamble, Nitin A wrote:
> Xin's patch is making vcpus argument mandatory. This is not right. Xin
> can you fix your patch to make it optinal?
> 
> Thanks & Regards,
> Nitin
> ------------------------------------------------------------------------
> -----------
> Open Source Technology Center, Intel Corp
> 
> >-----Original Message-----
> >From: Khoa Huynh [mailto:khoa@us.ibm.com]
> >Sent: Friday, October 21, 2005 10:16 AM
> >To: Kamble, Nitin A
> >Cc: Keir Fraser; Ian Pratt; xen-devel; xen-devel-
> >bounces@lists.xensource.com; Li, Xin B
> >Subject: Re: [Xen-devel] [PATCH] [VT] Fix for python breakge
> >
> >I think this patch was included in a patch submitted by Xin Li a couple
> >days ago.  I applied Li's patch and it fixed the problem for me.
> >Thanks.
> >
> >Regards,
> >
> >Khoa
> >

I posted something on this in my other post as well, optional is bad,
declaring everything may be a one time pain, but over the long haul it
is less problematic.  

IMHO

Regards,
Ted