From: Dave Hansen <haveblue@us.ibm.com>
To: Paul Jackson <pj@sgi.com>
Cc: Andrew Morton <akpm@osdl.org>,
Simon.Derr@bull.net,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Christoph Lameter <clameter@sgi.com>,
Linus Torvalds <torvalds@osdl.org>, Andi Kleen <ak@suse.de>
Subject: Re: [PATCH 02/02] cpuset automatic numa mempolicy rebinding
Date: Mon, 24 Oct 2005 10:36:27 +0200 [thread overview]
Message-ID: <1130142987.16002.4.camel@localhost> (raw)
In-Reply-To: <20051024072750.10390.32993.sendpatchset@jackhammer.engr.sgi.com>
On Mon, 2005-10-24 at 00:27 -0700, Paul Jackson wrote:
> + break;
> + }
> + default:
> + BUG();
> + break;
> + }
> +}
Just think how that looks to a reviewer without the full context :)
Perhaps the MBOL_BIND case needs a little helper function.
-- Dave
next prev parent reply other threads:[~2005-10-24 8:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-24 7:27 [PATCH 01/02] cpuset bitmap and mask remap operators Paul Jackson
2005-10-24 7:27 ` [PATCH 02/02] cpuset automatic numa mempolicy rebinding Paul Jackson
2005-10-24 8:36 ` Dave Hansen [this message]
2005-10-24 14:47 ` Paul Jackson
2005-10-24 14:52 ` Dave Hansen
2005-10-24 15:02 ` Paul Jackson
2005-10-24 7:48 ` [PATCH 01/02] cpuset bitmap and mask remap operators Andrew Morton
2005-10-24 8:16 ` Paul Jackson
2005-10-24 8:37 ` Andrew Morton
2005-10-24 14:37 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1130142987.16002.4.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=Simon.Derr@bull.net \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.