All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Jackson <pj@sgi.com>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: akpm@osdl.org, Simon.Derr@bull.net, linux-kernel@vger.kernel.org,
	clameter@sgi.com, torvalds@osdl.org, ak@suse.de
Subject: Re: [PATCH 02/02] cpuset automatic numa mempolicy rebinding
Date: Mon, 24 Oct 2005 07:47:38 -0700	[thread overview]
Message-ID: <20051024074738.4f2bfcbc.pj@sgi.com> (raw)
In-Reply-To: <1130142987.16002.4.camel@localhost>

Dave wrote:
> Just think how that looks to a reviewer without the full context :)

I was just copying Andi's coding style for these cases, with
this BUG() if no policy matched.  When in Rome, do as the
Romans.

> Perhaps the MBOL_BIND case needs a little helper function.

Eh ... that entire routine still fits on a page of my screen.
I'm not sure that adding a helper function would clarify the
code any.

Thanks for looking at it.  If you're pretty sure I should change
one of the above, squeek a little louder.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401

  reply	other threads:[~2005-10-24 14:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-24  7:27 [PATCH 01/02] cpuset bitmap and mask remap operators Paul Jackson
2005-10-24  7:27 ` [PATCH 02/02] cpuset automatic numa mempolicy rebinding Paul Jackson
2005-10-24  8:36   ` Dave Hansen
2005-10-24 14:47     ` Paul Jackson [this message]
2005-10-24 14:52       ` Dave Hansen
2005-10-24 15:02         ` Paul Jackson
2005-10-24  7:48 ` [PATCH 01/02] cpuset bitmap and mask remap operators Andrew Morton
2005-10-24  8:16   ` Paul Jackson
2005-10-24  8:37     ` Andrew Morton
2005-10-24 14:37       ` Paul Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051024074738.4f2bfcbc.pj@sgi.com \
    --to=pj@sgi.com \
    --cc=Simon.Derr@bull.net \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=clameter@sgi.com \
    --cc=haveblue@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.