From: Dave Hansen <haveblue@us.ibm.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: Andrew Morton <akpm@osdl.org>,
Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
Mike Kravetz <kravetz@us.ibm.com>,
Ray Bryant <raybry@mpdtxmail.amd.com>,
Lee Schermerhorn <lee.schermerhorn@hp.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Magnus Damm <magnus.damm@gmail.com>, Paul Jackson <pj@sgi.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH 3/5] Swap Migration V4: migrate_pages() function
Date: Wed, 26 Oct 2005 09:15:34 +0200 [thread overview]
Message-ID: <1130310934.1226.29.camel@localhost> (raw)
In-Reply-To: <20051025193039.6828.74991.sendpatchset@schroedinger.engr.sgi.com>
On Tue, 2005-10-25 at 12:30 -0700, Christoph Lameter wrote:
>
> +#ifdef CONFIG_SWAP
> + if (PageSwapCache(page)) {
> + swp_entry_t swap = { .val = page_private(page) };
> + add_to_swapped_list(swap.val);
> + __delete_from_swap_cache(page);
> + write_unlock_irq(&mapping->tree_lock);
> + swap_free(swap);
> + __put_page(page); /* The pagecache ref */
> + return 1;
> + }
> +#endif /* CONFIG_SWAP */
Why is this #ifdef needed? PageSwapCache() is #defined to 0 when !
CONFIG_SWAP.
-- Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <haveblue@us.ibm.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: Andrew Morton <akpm@osdl.org>,
Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
Mike Kravetz <kravetz@us.ibm.com>,
Ray Bryant <raybry@mpdtxmail.amd.com>,
Lee Schermerhorn <lee.schermerhorn@hp.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>,
Magnus Damm <magnus.damm@gmail.com>, Paul Jackson <pj@sgi.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH 3/5] Swap Migration V4: migrate_pages() function
Date: Wed, 26 Oct 2005 09:15:34 +0200 [thread overview]
Message-ID: <1130310934.1226.29.camel@localhost> (raw)
In-Reply-To: <20051025193039.6828.74991.sendpatchset@schroedinger.engr.sgi.com>
On Tue, 2005-10-25 at 12:30 -0700, Christoph Lameter wrote:
>
> +#ifdef CONFIG_SWAP
> + if (PageSwapCache(page)) {
> + swp_entry_t swap = { .val = page_private(page) };
> + add_to_swapped_list(swap.val);
> + __delete_from_swap_cache(page);
> + write_unlock_irq(&mapping->tree_lock);
> + swap_free(swap);
> + __put_page(page); /* The pagecache ref */
> + return 1;
> + }
> +#endif /* CONFIG_SWAP */
Why is this #ifdef needed? PageSwapCache() is #defined to 0 when !
CONFIG_SWAP.
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-10-26 7:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-25 19:30 [PATCH 0/5] Swap Migration V4: Overview Christoph Lameter
2005-10-25 19:30 ` Christoph Lameter
2005-10-25 19:30 ` [PATCH 1/5] Swap Migration V4: LRU operations Christoph Lameter
2005-10-25 19:30 ` Christoph Lameter
2005-10-26 9:31 ` Peter Zijlstra
2005-10-26 9:31 ` Peter Zijlstra
2005-10-26 16:44 ` Christoph Lameter
2005-10-26 16:44 ` Christoph Lameter
2005-10-25 19:30 ` [PATCH 2/5] Swap Migration V4: PF_SWAPWRITE to allow writing to swap Christoph Lameter
2005-10-25 19:30 ` Christoph Lameter
2005-10-25 19:30 ` [PATCH 3/5] Swap Migration V4: migrate_pages() function Christoph Lameter
2005-10-25 19:30 ` Christoph Lameter
2005-10-26 7:15 ` Dave Hansen [this message]
2005-10-26 7:15 ` Dave Hansen
2005-10-26 16:48 ` Christoph Lameter
2005-10-26 16:48 ` Christoph Lameter
2005-10-25 19:30 ` [PATCH 4/5] Swap Migration V4: MPOL_MF_MOVE interface Christoph Lameter
2005-10-25 19:30 ` Christoph Lameter
2005-10-25 19:30 ` [PATCH 5/5] Swap Migration V4: sys_migrate_pages interface Christoph Lameter
2005-10-25 19:30 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1130310934.1226.29.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kravetz@us.ibm.com \
--cc=lee.schermerhorn@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=magnus.damm@gmail.com \
--cc=marcelo.tosatti@cyclades.com \
--cc=pj@sgi.com \
--cc=raybry@mpdtxmail.amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.