Re: [Bluez-devel] [PATCH] dbus.c cleanup

[Marcel Holtmann <marcel@holtmann.org>]

Hi Claudio,

> here is patch to move the find_conn function to lib.c file.

I just realized that I already moved it out of dbus.c and so lets keep
it in hcid as inline function for now.

> Regarding the error related functions, can I move to a error.c file or
> it's better keep them in the dbus.c?

At the moment, I think it is better to keep them there. I don't have any
real opinion at the moment and so it might be better not to move to much
code around.

> Another point is the Disconnect signal. Which approach you preffer
> exit or create a timer to re-connect each x seconds?

We should try to re-connect. The security is still running and so we
can't exit.

> IMHO, I think it not necessary handle this scenario. Restart the
> dbus-daemon is not common.

Every time you update your D-Bus installation. The Ubuntu guys even
popup a message box that you should reboot your system ;)

Regards

Marcel




-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel