From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Geoff Levand <geoffrey.levand@am.sony.com>
Cc: rmk+serial@arm.linux.org.uk, linux-serial@vger.kernel.org
Subject: Re: pmac serial_pci_guess_board problem
Date: Sat, 05 Nov 2005 08:47:40 +1100 [thread overview]
Message-ID: <1131140861.29195.13.camel@gaston> (raw)
In-Reply-To: <436BD229.3090401@am.sony.com>
On Fri, 2005-11-04 at 13:27 -0800, Geoff Levand wrote:
> Russell,
>
> I found that the serial port probe code in drivers/serial/8250_pci.c
> no longer works properly for PowerMac G5 in 2.6.14. It seems some new
> code now takes the PCI device info directly from the G5's Open
> Firmware. The trouble is that OF sets the address length to 16 bytes,
> not the expected 8 bytes.
>
> Here's a fix, but I'd be interested to hear your comments.
I wouldn't do the ifdef at all ... Why do we bother testing the size
anyway ? Russell ?
Ben.
next prev parent reply other threads:[~2005-11-04 21:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-04 21:27 pmac serial_pci_guess_board problem Geoff Levand
2005-11-04 21:47 ` Benjamin Herrenschmidt [this message]
2005-11-04 22:50 ` Russell King
2005-11-04 22:53 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1131140861.29195.13.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=geoffrey.levand@am.sony.com \
--cc=linux-serial@vger.kernel.org \
--cc=rmk+serial@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.