Re: pmac serial_pci_guess_board problem

[Russell King <rmk@arm.linux.org.uk>]

On Sat, Nov 05, 2005 at 08:47:40AM +1100, Benjamin Herrenschmidt wrote:
> On Fri, 2005-11-04 at 13:27 -0800, Geoff Levand wrote:
> > Russell,
> > 
> > I found that the serial port probe code in drivers/serial/8250_pci.c 
> > no longer works properly for PowerMac G5 in 2.6.14.  It seems some new
> > code now takes the PCI device info directly from the G5's Open 
> > Firmware.  The trouble is that OF sets the address length to 16 bytes, 
> > not the expected 8 bytes.
> > 
> > Here's a fix, but I'd be interested to hear your comments.
> 
> I wouldn't do the ifdef at all ... Why do we bother testing the size
> anyway ? Russell ?

That's the expected size of the ports.  Remember this is a heuristic
for finding the correct details of the ports.  Some cards seem to
have regions of 16 bytes which aren't serial ports.

I'm _very_ nervous about changing this, especially as it pre-dates
my time and you seem to imply that it's an OF problem.  Can't it be
fixed up in a PCI quirk?

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core