From: Lee Revell <rlrevell@joe-job.com>
To: mchehab@brturbo.com.br
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org,
video4linux-list@redhat.com,
Ricardo Cerqueira <v4l@cerqueira.org>,
Takashi Iwai <tiwai@suse.de>,
alsa-devel@lists.sourceforge.net
Subject: Re: [Patch 02/20] V4L (930) Alsa fixes and improvements
Date: Thu, 10 Nov 2005 15:59:47 -0500 [thread overview]
Message-ID: <1131656388.8383.182.camel@mindpipe> (raw)
In-Reply-To: <1131656168.6478.39.camel@localhost>
On Thu, 2005-11-10 at 18:50 -0200, mchehab@brturbo.com.br wrote:
> - struct saa7134_dev *dev = (struct saa7134_dev*) dev_id;
> + snd_card_saa7134_t *saa7134 = dev_id;
> + struct saa7134_dev *dev = saa7134->saadev;
Don't use typedefs for stucts. Yes, it's all over the place in ALSA,
but this will be changed very soon.
Lee
-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php
WARNING: multiple messages have this Message-ID (diff)
From: Lee Revell <rlrevell@joe-job.com>
To: mchehab@brturbo.com.br
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org,
video4linux-list@redhat.com,
Ricardo Cerqueira <v4l@cerqueira.org>,
Takashi Iwai <tiwai@suse.de>,
alsa-devel@lists.sourceforge.net
Subject: Re: [Patch 02/20] V4L (930) Alsa fixes and improvements
Date: Thu, 10 Nov 2005 15:59:47 -0500 [thread overview]
Message-ID: <1131656388.8383.182.camel@mindpipe> (raw)
In-Reply-To: <1131656168.6478.39.camel@localhost>
On Thu, 2005-11-10 at 18:50 -0200, mchehab@brturbo.com.br wrote:
> - struct saa7134_dev *dev = (struct saa7134_dev*) dev_id;
> + snd_card_saa7134_t *saa7134 = dev_id;
> + struct saa7134_dev *dev = saa7134->saadev;
Don't use typedefs for stucts. Yes, it's all over the place in ALSA,
but this will be changed very soon.
Lee
next prev parent reply other threads:[~2005-11-10 20:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-10 20:50 [Patch 02/20] V4L (930) Alsa fixes and improvements mchehab
2005-11-10 20:59 ` Lee Revell [this message]
2005-11-10 20:59 ` Lee Revell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1131656388.8383.182.camel@mindpipe \
--to=rlrevell@joe-job.com \
--cc=akpm@osdl.org \
--cc=alsa-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@brturbo.com.br \
--cc=tiwai@suse.de \
--cc=v4l@cerqueira.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.