From: Adam Litke <agl@us.ibm.com>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: linux-mm@kvack.org, ak@suse.de, linux-kernel@vger.kernel.org,
kenneth.w.chen@intel.com, wli@holomorphy.com
Subject: Re: [RFC] NUMA memory policy support for HUGE pages
Date: Mon, 14 Nov 2005 16:30:10 -0600 [thread overview]
Message-ID: <1132007410.13502.35.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.62.0511141340160.4663@schroedinger.engr.sgi.com>
On Mon, 2005-11-14 at 13:46 -0800, Christoph Lameter wrote:
> This is V2 of the patch.
>
> Changes:
>
> - Cleaned up by folding find_or_alloc() into hugetlb_no_page().
IMHO this is not really a cleanup. When the demand fault patch stack
was first accepted, we decided to separate out find_or_alloc_huge_page()
because it has the page_cache retry loop with several exit conditions.
no_page() has its own backout logic and mixing the two makes for a
tangled mess. Can we leave that hunk out please?
--
Adam Litke - (agl at us.ibm.com)
IBM Linux Technology Center
WARNING: multiple messages have this Message-ID (diff)
From: Adam Litke <agl@us.ibm.com>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: linux-mm@kvack.org, ak@suse.de, linux-kernel@vger.kernel.org,
kenneth.w.chen@intel.com, wli@holomorphy.com
Subject: Re: [RFC] NUMA memory policy support for HUGE pages
Date: Mon, 14 Nov 2005 16:30:10 -0600 [thread overview]
Message-ID: <1132007410.13502.35.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.62.0511141340160.4663@schroedinger.engr.sgi.com>
On Mon, 2005-11-14 at 13:46 -0800, Christoph Lameter wrote:
> This is V2 of the patch.
>
> Changes:
>
> - Cleaned up by folding find_or_alloc() into hugetlb_no_page().
IMHO this is not really a cleanup. When the demand fault patch stack
was first accepted, we decided to separate out find_or_alloc_huge_page()
because it has the page_cache retry loop with several exit conditions.
no_page() has its own backout logic and mixing the two makes for a
tangled mess. Can we leave that hunk out please?
--
Adam Litke - (agl at us.ibm.com)
IBM Linux Technology Center
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-11-14 22:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-11 18:56 [RFC] NUMA memory policy support for HUGE pages Christoph Lameter
2005-11-11 18:56 ` Christoph Lameter
2005-11-11 20:28 ` Christoph Lameter
2005-11-11 20:28 ` Christoph Lameter
2005-11-14 15:06 ` Adam Litke
2005-11-14 15:06 ` Adam Litke
2005-11-14 18:09 ` Christoph Lameter
2005-11-14 18:09 ` Christoph Lameter
2005-11-14 21:46 ` Christoph Lameter
2005-11-14 21:46 ` Christoph Lameter
2005-11-14 22:30 ` Adam Litke [this message]
2005-11-14 22:30 ` Adam Litke
2005-11-14 23:25 ` Christoph Lameter
2005-11-14 23:25 ` Christoph Lameter
2005-11-15 12:18 ` William Lee Irwin III
2005-11-15 12:18 ` William Lee Irwin III
2005-11-11 21:23 ` William Lee Irwin III
2005-11-11 21:23 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1132007410.13502.35.camel@localhost.localdomain \
--to=agl@us.ibm.com \
--cc=ak@suse.de \
--cc=clameter@engr.sgi.com \
--cc=kenneth.w.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.