Re: [2.6 patch] drivers/media/video/: make code static

[Mauro Carvalho Chehab <mchehab@brturbo.com.br>]

Adrian,

Em Dom, 2005-11-20 às 03:44 +0100, Adrian Bunk escreveu:
> This patch makes needlessly global code static.
> 
> 
>  drivers/media/video/bttv-cards.c           |    6 +++---
>  drivers/media/video/cx25840/cx25840-core.c |    4 ++--
>  drivers/media/video/em28xx/em28xx-core.c   |    6 +++---
>  drivers/media/video/em28xx/em28xx-video.c  |    2 +-
>  drivers/media/video/saa7127.c              |    6 +++---
>  drivers/media/video/saa7134/saa7134-alsa.c |    9 +++++----
>  drivers/media/video/saa7134/saa7134-oss.c  |    4 ++--
>  7 files changed, 19 insertions(+), 18 deletions(-)
> 
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Thanks for your patch.

> --- linux-2.6.15-rc1-mm2-full/drivers/media/video/saa7134/saa7134-alsa.c.old	2005-11-20 02:49:12.000000000 +0100
> +++ linux-2.6.15-rc1-mm2-full/drivers/media/video/saa7134/saa7134-alsa.c	2005-11-20 02:58:01.000000000 +0100
> @@ -58,7 +58,7 @@
>  module_param_array(index, int, NULL, 0444);
>  MODULE_PARM_DESC(index, "Index value for SAA7134 capture interface(s).");
>  
> -int position;
> +static int position;

	This didn't applied at V4L tree. This flag was removed at the latest
version. We had already a patch including static on some I2C structs and
other trivial fixes.
I'll added your patch with fixes on my tree and send to -mm in the next
V4L patchsets, after the patch that removes position and fixes some
stuff at saa7134-alsa.

Cheers, 
Mauro.