All of lore.kernel.org
 help / color / mirror / Atom feed
* RE: [ALSA - driver 0001563]: No Sound on CybersystemS28 (hda_codec: Unknown model for ALC880, trying auto-probe from BIOS...)
@ 2005-11-23  5:55 Yang, Libin
  2005-11-23  6:04 ` Lee Revell
  0 siblings, 1 reply; 6+ messages in thread
From: Yang, Libin @ 2005-11-23  5:55 UTC (permalink / raw)
  To: Lee Revell; +Cc: bugtrack, alsa-devel

[-- Attachment #1: Type: text/plain, Size: 1451 bytes --]

Here is the patch file for 1.0.10. 

The problem is that in the patch_realtek.c file, it should use alc880_idx_to_dac() function in the first 'for' loop, not alc880_dac_to_idx() in function alc880_auto_fill_dac_nids().

Thanks.

-----Original Message-----
From: alsa-devel-admin@lists.sourceforge.net [mailto:alsa-devel-admin@lists.sourceforge.net] On Behalf Of Lee Revell
Sent: 2005年11月23日 10:49
To: Yang, Libin
Cc: bugtrack@alsa-project.org; alsa-devel@alsa-project.org
Subject: RE: [Alsa-devel] [ALSA - driver 0001563]: No Sound on CybersystemS28 (hda_codec: Unknown model for ALC880, trying auto-probe from BIOS...)

On Wed, 2005-11-23 at 10:45 +0800, Yang, Libin wrote:
> I think I have found the reason which may cause the problem. But I don't  how to submit the patch or just write the reason here? Thanks.  

Thanks very much for fixing this.

You can just post the patch here, with the description and Signed-Off-By
line.

Lee



-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc.  Get Certified Today
Register for a JBoss Training Course.  Free Certification Exam
for All Training Attendees Through End of 2005. For more info visit:
http://ads.osdn.com/?ad_id=7628&alloc_id=16845&op=click
_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel

[-- Attachment #2: rpatch.diff --]
[-- Type: application/octet-stream, Size: 1160 bytes --]

diff -urN alsa-driver-1.0.10/alsa-kernel/pci/hda/patch_realtek.c my_alsa-driver-1.0.10/alsa-kernel/pci/hda/patch_realtek.c
--- alsa-driver-1.0.10/alsa-kernel/pci/hda/patch_realtek.c	2005-11-02 10:26:49.000000000 -0800
+++ my_alsa-driver-1.0.10/alsa-kernel/pci/hda/patch_realtek.c	2005-11-23 05:52:36.000000000 -0800
@@ -1809,7 +1809,7 @@
 		nid = cfg->line_out_pins[i];
 		if (alc880_is_fixed_pin(nid)) {
 			int idx = alc880_fixed_pin_idx(nid);
-			spec->multiout.dac_nids[i] = alc880_dac_to_idx(idx);
+			spec->multiout.dac_nids[i] = alc880_idx_to_dac(idx);
 			assigned[idx] = 1;
 		}
 	}
diff -urN alsa-driver-1.0.10/sound/pci/hda/patch_realtek.c my_alsa-driver-1.0.10/sound/pci/hda/patch_realtek.c
--- alsa-driver-1.0.10/sound/pci/hda/patch_realtek.c	2005-11-02 10:26:49.000000000 -0800
+++ my_alsa-driver-1.0.10/sound/pci/hda/patch_realtek.c	2005-11-23 05:52:36.000000000 -0800
@@ -1809,7 +1809,7 @@
 		nid = cfg->line_out_pins[i];
 		if (alc880_is_fixed_pin(nid)) {
 			int idx = alc880_fixed_pin_idx(nid);
-			spec->multiout.dac_nids[i] = alc880_dac_to_idx(idx);
+			spec->multiout.dac_nids[i] = alc880_idx_to_dac(idx);
 			assigned[idx] = 1;
 		}
 	}

^ permalink raw reply	[flat|nested] 6+ messages in thread
* RE: [ALSA - driver 0001563]: No Sound on CybersystemS28 (hda_codec: Unknown model for ALC880, trying auto-probe from BIOS...)
@ 2005-11-23 15:39 Yang, Libin
  2005-11-23 15:50 ` Takashi Iwai
  0 siblings, 1 reply; 6+ messages in thread
From: Yang, Libin @ 2005-11-23 15:39 UTC (permalink / raw)
  To: Takashi Iwai, Lee Revell; +Cc: alsa-devel


 This patch is to fix the problem of calculating the nid incorrectly when auto-probe for ALC880. The problem to be fixed often behaves with such words when using dmesg, 'num_steps = 0 for NID=0x8' when auto-probe for ALC880.

The patch contains:
- alsa-kernel/pci/hda/patch_realtek.c: replace 'alc880_dac_to_idx' with 'alc880_idx_to_dac' in function 'alc880_auto_fill_dac_nids()'

Signed-off-by: Libin Yang <libin.yang@intel.com>


--- alsa-driver-1.0.10/alsa-kernel/pci/hda/patch_realtek.c	2005-11-02 10:26:49.000000000 -0800
+++ my_alsa-driver-1.0.10/alsa-kernel/pci/hda/patch_realtek.c	2005-11-23 05:52:36.000000000 -0800
@@ -1809,7 +1809,7 @@
 		nid = cfg->line_out_pins[i];
 		if (alc880_is_fixed_pin(nid)) {
 			int idx = alc880_fixed_pin_idx(nid);
-			spec->multiout.dac_nids[i] = alc880_dac_to_idx(idx);
+			spec->multiout.dac_nids[i] = alc880_idx_to_dac(idx);
 			assigned[idx] = 1;
 		}
 	}


-----Original Message-----
From: Takashi Iwai [mailto:tiwai@suse.de] 
Sent: 2005年11月23日 19:50
To: Lee Revell
Cc: Yang, Libin; alsa-devel@lists.sourceforge.net
Subject: Re: [Alsa-devel] [ALSA - driver 0001563]: No Sound on CybersystemS28 (hda_codec: Unknown model for ALC880, trying auto-probe from BIOS...)

At Wed, 23 Nov 2005 01:04:07 -0500,
Lee Revell wrote:
> 
> On Wed, 2005-11-23 at 13:55 +0800, Yang, Libin wrote:
> > Here is the patch file for 1.0.10. 
> > 
> > The problem is that in the patch_realtek.c file, it should use
> > alc880_idx_to_dac() function in the first 'for' loop, not
> > alc880_dac_to_idx() in function alc880_auto_fill_dac_nids().
> > 
> > Thanks. 
> 
> Thank you!
> 
> Please provide a Signed-Off-By line with your name and email address,
> for example:
> 
> Signed-Off-By: Lee Revell <rlrevell@joe-job.com>
> 
> This is Linux kernel submission policy.

Also please provide a short description for the patch as a changelog
like below:

	Summary: Fix blah on xyz

	This patch fixes the problem blah on xyz....
	....

	Signed-off-by: Foo Bar <foo@bar.com>


thanks,

Takashi


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_idv37&alloc_id\x16865&op=click

^ permalink raw reply	[flat|nested] 6+ messages in thread
* RE: [ALSA - driver 0001563]: No Sound on CybersystemS28 (hda_codec: Unknown model for ALC880, trying auto-probe from BIOS...)
@ 2005-11-23 16:05 Yang, Libin
  0 siblings, 0 replies; 6+ messages in thread
From: Yang, Libin @ 2005-11-23 16:05 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: Lee Revell, alsa-devel

[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]


OK. Thank you for your comments. Here is the attachment. 

-----Original Message-----
From: Takashi Iwai [mailto:tiwai@suse.de] 
Sent: 2005年11月23日 23:51
To: Yang, Libin
Cc: Lee Revell; alsa-devel@lists.sourceforge.net
Subject: Re: [Alsa-devel] [ALSA - driver 0001563]: No Sound on CybersystemS28 (hda_codec: Unknown model for ALC880, trying auto-probe from BIOS...)

At Wed, 23 Nov 2005 23:39:25 +0800,
Yang, Libin wrote:
> 
> 
>  This patch is to fix the problem of calculating the nid incorrectly when auto-probe for ALC880. The problem to be fixed often behaves with such words when using dmesg, 'num_steps = 0 for NID=0x8' when auto-probe for ALC880.
> 
> The patch contains:
> - alsa-kernel/pci/hda/patch_realtek.c: replace 'alc880_dac_to_idx' with 'alc880_idx_to_dac' in function 'alc880_auto_fill_dac_nids()'
> 
> Signed-off-by: Libin Yang <libin.yang@intel.com>

Thanks, applied to ALSA CVS now.

BTW, your mailer sent the text with quoted-printable encoding.  This
breaks the patch pasted in the text body.  In such a case, fix the
encoding or use an attachment.


Takashi

[-- Attachment #2: rpatch.diff --]
[-- Type: application/octet-stream, Size: 469 bytes --]

--- alsa-driver-1.0.10/alsa-kernel/pci/hda/patch_realtek.c	2005-11-02 10:26:49.000000000 -0800
+++ my_alsa-driver-1.0.10/alsa-kernel/pci/hda/patch_realtek.c	2005-11-23 05:52:36.000000000 -0800
@@ -1809,7 +1809,7 @@
 		nid = cfg->line_out_pins[i];
 		if (alc880_is_fixed_pin(nid)) {
 			int idx = alc880_fixed_pin_idx(nid);
-			spec->multiout.dac_nids[i] = alc880_dac_to_idx(idx);
+			spec->multiout.dac_nids[i] = alc880_idx_to_dac(idx);
 			assigned[idx] = 1;
 		}
 	}

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-11-23 16:05 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-23  5:55 [ALSA - driver 0001563]: No Sound on CybersystemS28 (hda_codec: Unknown model for ALC880, trying auto-probe from BIOS...) Yang, Libin
2005-11-23  6:04 ` Lee Revell
2005-11-23 11:50   ` Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2005-11-23 15:39 Yang, Libin
2005-11-23 15:50 ` Takashi Iwai
2005-11-23 16:05 Yang, Libin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.