From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Andrew Morton <akpm@osdl.org>, Greg KH <greg@kroah.com>,
linux-kernel@vger.kernel.org,
David Brownell <david-b@pacbell.net>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH] Fix USB suspend/resume crasher
Date: Thu, 24 Nov 2005 12:23:15 +1100 [thread overview]
Message-ID: <1132795396.26560.382.camel@gaston> (raw)
In-Reply-To: <200511240122.46125.rjw@sisk.pl>
> Unfortunately with this patch the EHCI controller in my box (Asus L5D,
> x86-64 kernel) does not resume from suspend. Appended is the relevant
> snippet from the serial console log (EHCI is the only device using IRQ #5).
Hrm... let me see... You are getting an interrupt for EHCI after it has
been resumed, so it should work.
/me double-checks the patch
> ehci_hcd 0000:00:02.2: lost power, restarting
Hrm... I can't find that line in the code...
/me rechecks with david's other patches
Ah ... I see it. There might have been some screwup between david's
patch and mine.
Make sure that
set_bit(HCD_FLAG_HW_ACCESSIBLE, &hcd->flags);
Is still done before anything else in ehci_pci_resume(). It may be worth
following it with a memory barrier actually... just in case (due to the
absence of locks in that area).
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: linux-kernel@vger.kernel.org,
David Brownell <david-b@pacbell.net>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>,
Andrew Morton <akpm@osdl.org>, Greg KH <greg@kroah.com>,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH] Fix USB suspend/resume crasher
Date: Thu, 24 Nov 2005 12:23:15 +1100 [thread overview]
Message-ID: <1132795396.26560.382.camel@gaston> (raw)
In-Reply-To: <200511240122.46125.rjw@sisk.pl>
> Unfortunately with this patch the EHCI controller in my box (Asus L5D,
> x86-64 kernel) does not resume from suspend. Appended is the relevant
> snippet from the serial console log (EHCI is the only device using IRQ #5).
Hrm... let me see... You are getting an interrupt for EHCI after it has
been resumed, so it should work.
/me double-checks the patch
> ehci_hcd 0000:00:02.2: lost power, restarting
Hrm... I can't find that line in the code...
/me rechecks with david's other patches
Ah ... I see it. There might have been some screwup between david's
patch and mine.
Make sure that
set_bit(HCD_FLAG_HW_ACCESSIBLE, &hcd->flags);
Is still done before anything else in ehci_pci_resume(). It may be worth
following it with a memory barrier actually... just in case (due to the
absence of locks in that area).
Ben.
next prev parent reply other threads:[~2005-11-24 1:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-23 3:08 [PATCH] Fix USB suspend/resume crasher Benjamin Herrenschmidt
2005-11-23 3:08 ` Benjamin Herrenschmidt
2005-11-23 3:09 ` Benjamin Herrenschmidt
2005-11-23 3:09 ` Benjamin Herrenschmidt
2005-11-23 3:14 ` Nigel Cunningham
2005-11-23 3:14 ` Nigel Cunningham
2005-11-23 5:13 ` Benjamin Herrenschmidt
2005-11-23 5:13 ` Benjamin Herrenschmidt
2005-11-23 17:10 ` Greg KH
2005-11-23 17:10 ` Greg KH
2005-11-23 18:58 ` David Brownell
2005-11-23 18:58 ` David Brownell
2005-11-24 0:22 ` Rafael J. Wysocki
2005-11-24 0:22 ` Rafael J. Wysocki
2005-11-24 0:29 ` sysfs question JaniD++
2005-11-24 1:23 ` Benjamin Herrenschmidt [this message]
2005-11-24 1:23 ` [PATCH] Fix USB suspend/resume crasher Benjamin Herrenschmidt
2005-11-24 20:50 ` Rafael J. Wysocki
2005-11-24 20:50 ` Rafael J. Wysocki
2005-11-24 21:01 ` Benjamin Herrenschmidt
2005-11-24 21:01 ` Benjamin Herrenschmidt
2005-11-24 21:14 ` Rafael J. Wysocki
2005-11-24 21:14 ` Rafael J. Wysocki
2005-11-24 21:22 ` Benjamin Herrenschmidt
2005-11-24 21:22 ` Benjamin Herrenschmidt
2005-11-24 16:52 ` Arkadiusz Miskiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1132795396.26560.382.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=david-b@pacbell.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.