* [PATCH] serial: Fix matching of MMIO ports
@ 2005-11-28 21:11 Benjamin Herrenschmidt
2005-11-28 22:12 ` Russell King
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2005-11-28 21:11 UTC (permalink / raw)
To: Russell King, Andrew Morton; +Cc: Linux Kernel list
The function uart_match_port() incorrectly compares the ioremap'd
virtual addresses of ports instead of the physical address to find
duplicate ports for MMIO based UARTs. This fixes it.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Index: linux-work/drivers/serial/serial_core.c
===================================================================
--- linux-work.orig/drivers/serial/serial_core.c 2005-11-14 20:32:16.000000000 +1100
+++ linux-work/drivers/serial/serial_core.c 2005-11-29 08:08:44.000000000 +1100
@@ -2307,7 +2307,7 @@
return (port1->iobase == port2->iobase) &&
(port1->hub6 == port2->hub6);
case UPIO_MEM:
- return (port1->membase == port2->membase);
+ return (port1->mapbase == port2->mapbase);
}
return 0;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] serial: Fix matching of MMIO ports
2005-11-28 21:11 [PATCH] serial: Fix matching of MMIO ports Benjamin Herrenschmidt
@ 2005-11-28 22:12 ` Russell King
2005-11-28 22:11 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 3+ messages in thread
From: Russell King @ 2005-11-28 22:12 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: Andrew Morton, Linux Kernel list
On Tue, Nov 29, 2005 at 08:11:08AM +1100, Benjamin Herrenschmidt wrote:
> The function uart_match_port() incorrectly compares the ioremap'd
> virtual addresses of ports instead of the physical address to find
> duplicate ports for MMIO based UARTs. This fixes it.
I'd like this to go in -mm for a bit before we put it into mainline,
just in case there's any undesirable side effects.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] serial: Fix matching of MMIO ports
2005-11-28 22:12 ` Russell King
@ 2005-11-28 22:11 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2005-11-28 22:11 UTC (permalink / raw)
To: Russell King; +Cc: Andrew Morton, Linux Kernel list
On Mon, 2005-11-28 at 22:12 +0000, Russell King wrote:
> On Tue, Nov 29, 2005 at 08:11:08AM +1100, Benjamin Herrenschmidt wrote:
> > The function uart_match_port() incorrectly compares the ioremap'd
> > virtual addresses of ports instead of the physical address to find
> > duplicate ports for MMIO based UARTs. This fixes it.
>
> I'd like this to go in -mm for a bit before we put it into mainline,
> just in case there's any undesirable side effects.
Fine with me.
Ben.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-11-28 22:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-28 21:11 [PATCH] serial: Fix matching of MMIO ports Benjamin Herrenschmidt
2005-11-28 22:12 ` Russell King
2005-11-28 22:11 ` Benjamin Herrenschmidt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.