* [PATCH] setting irq affinity is broken in ia32 with MSI enabled
@ 2005-11-30 8:37 Shaohua Li
2005-11-30 2:31 ` Ashok Raj
0 siblings, 1 reply; 2+ messages in thread
From: Shaohua Li @ 2005-11-30 8:37 UTC (permalink / raw)
To: lkml; +Cc: Raj, Ashok, Pallipadi, Venkatesh, akpm
Setting irq affinity stops working when MSI is enabled. With MSI,
move_irq is empty, so we can't change irq affinity. It appears a typo in
Ashok's original commit for this issue. X86_64 actually is using
move_native_irq.
Signed-off-by: Shaohua Li <shaohua.li@intel.com>
--- a/arch/i386/kernel/io_apic.c 2005-11-29 22:22:16.000000000 -0800
+++ b/arch/i386/kernel/io_apic.c 2005-11-29 22:23:01.000000000 -0800
@@ -2009,7 +2009,7 @@ static void ack_edge_ioapic_vector(unsig
{
int irq = vector_to_irq(vector);
- move_irq(vector);
+ move_native_irq(vector);
ack_edge_ioapic_irq(irq);
}
@@ -2024,7 +2024,7 @@ static void end_level_ioapic_vector (uns
{
int irq = vector_to_irq(vector);
- move_irq(vector);
+ move_native_irq(vector);
end_level_ioapic_irq(irq);
}
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] setting irq affinity is broken in ia32 with MSI enabled
2005-11-30 8:37 [PATCH] setting irq affinity is broken in ia32 with MSI enabled Shaohua Li
@ 2005-11-30 2:31 ` Ashok Raj
0 siblings, 0 replies; 2+ messages in thread
From: Ashok Raj @ 2005-11-30 2:31 UTC (permalink / raw)
To: Shaohua Li; +Cc: lkml, Raj, Ashok, Pallipadi, Venkatesh, akpm
On Wed, Nov 30, 2005 at 12:37:15AM -0800, Shaohua Li wrote:
> Setting irq affinity stops working when MSI is enabled. With MSI,
> move_irq is empty, so we can't change irq affinity. It appears a typo in
> Ashok's original commit for this issue. X86_64 actually is using
> move_native_irq.
>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
Yep...Think i missed the MSI/i386 case.
Looks good
Ashok Raj
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-11-30 2:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-30 8:37 [PATCH] setting irq affinity is broken in ia32 with MSI enabled Shaohua Li
2005-11-30 2:31 ` Ashok Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.