* Re: [Patch 11/31] V4L (0999) Some funcions now static and I2C hw code for IR [not found] <1133400730.21135.62.camel@localhost> @ 2005-12-01 20:10 ` Jean Delvare 0 siblings, 0 replies; 4+ messages in thread From: Jean Delvare @ 2005-12-01 19:11 UTC (permalink / raw) To: Mauro Carvalho Chehab; +Cc: Andrew Morton, js, LM Sensors, Greg KH, LKML Hi Mauro, [As a side note, it looks like there have been some distribution problems with this patchset... I can only see 0/31 (twice) on LKML and 11/31 didn't make it to the lm-sensors list as it was supposed to. I received it twice though.] > From: Mauro Carvalho Chehab <mchehab@brturbo.com.br> > > - Some funcions are now declared as static > - Added a I2C code for InfraRed. Unrelated changes, this should have been two separate patches. Also, "I2C driver ID" would better describe what the second change is about than "I2C code". > --- git.orig/drivers/media/video/ir-kbd-i2c.c > +++ git/drivers/media/video/ir-kbd-i2c.c > @@ -278,7 +278,7 @@ static int ir_probe(struct i2c_adapter * > > static struct i2c_driver driver = { > .name = "ir remote kbd driver", > - .id = I2C_DRIVERID_EXP3, /* FIXME */ > + .id = I2C_DRIVERID_I2C_IR, > .flags = I2C_DF_NOTIFY, > .attach_adapter = ir_probe, > .detach_client = ir_detach, That's a poor ID name you chose. The second "I2C" is totally redundant, and "IR" is a bit short and could mean about anything. Please change it to I2C_DRIVERID_IRKBD or I2C_DRIVERID_INFRARED or something. Thanks, -- Jean Delvare ^ permalink raw reply [flat|nested] 4+ messages in thread
* [lm-sensors] Re: [Patch 11/31] V4L (0999) Some funcions now static @ 2005-12-01 20:10 ` Jean Delvare 0 siblings, 0 replies; 4+ messages in thread From: Jean Delvare @ 2005-12-01 20:10 UTC (permalink / raw) To: Mauro Carvalho Chehab; +Cc: Andrew Morton, js, LM Sensors, Greg KH, LKML Hi Mauro, [As a side note, it looks like there have been some distribution problems with this patchset... I can only see 0/31 (twice) on LKML and 11/31 didn't make it to the lm-sensors list as it was supposed to. I received it twice though.] > From: Mauro Carvalho Chehab <mchehab@brturbo.com.br> > > - Some funcions are now declared as static > - Added a I2C code for InfraRed. Unrelated changes, this should have been two separate patches. Also, "I2C driver ID" would better describe what the second change is about than "I2C code". > --- git.orig/drivers/media/video/ir-kbd-i2c.c > +++ git/drivers/media/video/ir-kbd-i2c.c > @@ -278,7 +278,7 @@ static int ir_probe(struct i2c_adapter * > > static struct i2c_driver driver = { > .name = "ir remote kbd driver", > - .id = I2C_DRIVERID_EXP3, /* FIXME */ > + .id = I2C_DRIVERID_I2C_IR, > .flags = I2C_DF_NOTIFY, > .attach_adapter = ir_probe, > .detach_client = ir_detach, That's a poor ID name you chose. The second "I2C" is totally redundant, and "IR" is a bit short and could mean about anything. Please change it to I2C_DRIVERID_IRKBD or I2C_DRIVERID_INFRARED or something. Thanks, -- Jean Delvare ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Patch 11/31] V4L (0999) Some funcions now static and I2C hw code for IR 2005-12-01 20:10 ` [lm-sensors] Re: [Patch 11/31] V4L (0999) Some funcions now static Jean Delvare @ 2005-12-02 2:45 ` Mauro Carvalho Chehab -1 siblings, 0 replies; 4+ messages in thread From: Mauro Carvalho Chehab @ 2005-12-01 19:21 UTC (permalink / raw) To: Jean Delvare; +Cc: Andrew Morton, js, LM Sensors, Greg KH, LKML Em Qui, 2005-12-01 às 20:11 +0100, Jean Delvare escreveu: > Hi Mauro, > > [As a side note, it looks like there have been some distribution > problems with this patchset... I can only see 0/31 (twice) on LKML and > 11/31 didn't make it to the lm-sensors list as it was supposed to. I > received it twice though.] In fact, all were sent to lkml... for some unknown reason, my ISP didn't sent it (or lkml anti-spam rules filtered?). I even tried to send a second time... > > > From: Mauro Carvalho Chehab <mchehab@brturbo.com.br> > > > > - Some funcions are now declared as static > > - Added a I2C code for InfraRed. > > Unrelated changes, this should have been two separate patches. Also, > "I2C driver ID" would better describe what the second change is about > than "I2C code". Ok. I'll do it next time. I tried to consolidate into one due the ammount of patches we have to send. Up now, we sent more than 250 patches, just v4l updates to 2.6.15. > > > --- git.orig/drivers/media/video/ir-kbd-i2c.c > > +++ git/drivers/media/video/ir-kbd-i2c.c > > @@ -278,7 +278,7 @@ static int ir_probe(struct i2c_adapter * > > > > static struct i2c_driver driver = { > > .name = "ir remote kbd driver", > > - .id = I2C_DRIVERID_EXP3, /* FIXME */ > > + .id = I2C_DRIVERID_I2C_IR, > > .flags = I2C_DF_NOTIFY, > > .attach_adapter = ir_probe, > > .detach_client = ir_detach, > > That's a poor ID name you chose. The second "I2C" is totally redundant, > and "IR" is a bit short and could mean about anything. Please change it to > I2C_DRIVERID_IRKBD or I2C_DRIVERID_INFRARED or something. Ok. (We have also other non-i2c ir.. that's why I called it I2C_IR). I'll prepare a patch for it. I2C_DRIVERID_INFRARED seems a good name. > > Thanks, Cheers, Mauro. ^ permalink raw reply [flat|nested] 4+ messages in thread
* [lm-sensors] Re: [Patch 11/31] V4L (0999) Some funcions now static @ 2005-12-02 2:45 ` Mauro Carvalho Chehab 0 siblings, 0 replies; 4+ messages in thread From: Mauro Carvalho Chehab @ 2005-12-02 2:45 UTC (permalink / raw) To: Jean Delvare; +Cc: Andrew Morton, js, LM Sensors, Greg KH, LKML Em Qui, 2005-12-01 ?s 20:11 +0100, Jean Delvare escreveu: > Hi Mauro, > > [As a side note, it looks like there have been some distribution > problems with this patchset... I can only see 0/31 (twice) on LKML and > 11/31 didn't make it to the lm-sensors list as it was supposed to. I > received it twice though.] In fact, all were sent to lkml... for some unknown reason, my ISP didn't sent it (or lkml anti-spam rules filtered?). I even tried to send a second time... > > > From: Mauro Carvalho Chehab <mchehab@brturbo.com.br> > > > > - Some funcions are now declared as static > > - Added a I2C code for InfraRed. > > Unrelated changes, this should have been two separate patches. Also, > "I2C driver ID" would better describe what the second change is about > than "I2C code". Ok. I'll do it next time. I tried to consolidate into one due the ammount of patches we have to send. Up now, we sent more than 250 patches, just v4l updates to 2.6.15. > > > --- git.orig/drivers/media/video/ir-kbd-i2c.c > > +++ git/drivers/media/video/ir-kbd-i2c.c > > @@ -278,7 +278,7 @@ static int ir_probe(struct i2c_adapter * > > > > static struct i2c_driver driver = { > > .name = "ir remote kbd driver", > > - .id = I2C_DRIVERID_EXP3, /* FIXME */ > > + .id = I2C_DRIVERID_I2C_IR, > > .flags = I2C_DF_NOTIFY, > > .attach_adapter = ir_probe, > > .detach_client = ir_detach, > > That's a poor ID name you chose. The second "I2C" is totally redundant, > and "IR" is a bit short and could mean about anything. Please change it to > I2C_DRIVERID_IRKBD or I2C_DRIVERID_INFRARED or something. Ok. (We have also other non-i2c ir.. that's why I called it I2C_IR). I'll prepare a patch for it. I2C_DRIVERID_INFRARED seems a good name. > > Thanks, Cheers, Mauro. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-12-02 2:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1133400730.21135.62.camel@localhost>
2005-12-01 19:11 ` [Patch 11/31] V4L (0999) Some funcions now static and I2C hw code for IR Jean Delvare
2005-12-01 20:10 ` [lm-sensors] Re: [Patch 11/31] V4L (0999) Some funcions now static Jean Delvare
2005-12-01 19:21 ` [Patch 11/31] V4L (0999) Some funcions now static and I2C hw code for IR Mauro Carvalho Chehab
2005-12-02 2:45 ` [lm-sensors] Re: [Patch 11/31] V4L (0999) Some funcions now static Mauro Carvalho Chehab
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.