* [uml-devel] [PATCH] um: fix compile error for tt @ 2005-12-06 20:24 ` Pekka Enberg 0 siblings, 0 replies; 8+ messages in thread From: Pekka Enberg @ 2005-12-06 20:24 UTC (permalink / raw) To: akpm; +Cc: linux-kernel, jdike, user-mode-linux-devel Without the included patch, I get the following compile error for um: arch/um/kernel/tt/uaccess.c: In function `copy_from_user_tt': arch/um/kernel/tt/uaccess.c:11: error: `FIXADDR_USER_START' undeclared (first use in this function) arch/um/kernel/tt/uaccess.c:11: error: (Each undeclared identifier is reported only once arch/um/kernel/tt/uaccess.c:11: error: for each function it appears in.) The error only happens when I disable CONFIG_MODE_SKAS. Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi> --- uaccess-tt.h | 1 + 1 file changed, 1 insertion(+) Index: 2.6/arch/um/kernel/tt/include/uaccess-tt.h =================================================================== --- 2.6.orig/arch/um/kernel/tt/include/uaccess-tt.h +++ 2.6/arch/um/kernel/tt/include/uaccess-tt.h @@ -8,6 +8,7 @@ #include "linux/string.h" #include "linux/sched.h" +#include "asm/fixmap.h" #include "asm/processor.h" #include "asm/errno.h" #include "asm/current.h" ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] um: fix compile error for tt @ 2005-12-06 20:24 ` Pekka Enberg 0 siblings, 0 replies; 8+ messages in thread From: Pekka Enberg @ 2005-12-06 20:24 UTC (permalink / raw) To: akpm; +Cc: linux-kernel, jdike, user-mode-linux-devel Without the included patch, I get the following compile error for um: arch/um/kernel/tt/uaccess.c: In function `copy_from_user_tt': arch/um/kernel/tt/uaccess.c:11: error: `FIXADDR_USER_START' undeclared (first use in this function) arch/um/kernel/tt/uaccess.c:11: error: (Each undeclared identifier is reported only once arch/um/kernel/tt/uaccess.c:11: error: for each function it appears in.) The error only happens when I disable CONFIG_MODE_SKAS. Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi> --- uaccess-tt.h | 1 + 1 file changed, 1 insertion(+) Index: 2.6/arch/um/kernel/tt/include/uaccess-tt.h =================================================================== --- 2.6.orig/arch/um/kernel/tt/include/uaccess-tt.h +++ 2.6/arch/um/kernel/tt/include/uaccess-tt.h @@ -8,6 +8,7 @@ #include "linux/string.h" #include "linux/sched.h" +#include "asm/fixmap.h" #include "asm/processor.h" #include "asm/errno.h" #include "asm/current.h" ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [uml-devel] [PATCH] um: fix compile error for tt 2005-12-06 20:24 ` Pekka Enberg @ 2005-12-07 9:38 ` Blaisorblade -1 siblings, 0 replies; 8+ messages in thread From: Blaisorblade @ 2005-12-07 9:38 UTC (permalink / raw) To: user-mode-linux-devel; +Cc: Pekka Enberg, akpm, linux-kernel, jdike On Tuesday 06 December 2005 21:24, Pekka Enberg wrote: > Without the included patch, I get the following compile error for um: > > arch/um/kernel/tt/uaccess.c: In function `copy_from_user_tt': > arch/um/kernel/tt/uaccess.c:11: error: `FIXADDR_USER_START' undeclared > (first use in this function) arch/um/kernel/tt/uaccess.c:11: error: (Each > undeclared identifier is reported only once arch/um/kernel/tt/uaccess.c:11: > error: for each function it appears in.) > > The error only happens when I disable CONFIG_MODE_SKAS. Ok, fine, just a note - the header inclusion should be added to arch/um/include/um_uaccess.h where it is effectively used (the offending macros, using FIXADDR_USER_*, are __access_ok_vsyscall. For the rest it's ok. -- Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!". Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894) http://www.user-mode-linux.org/~blaisorblade ___________________________________ Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB http://mail.yahoo.it ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [uml-devel] [PATCH] um: fix compile error for tt @ 2005-12-07 9:38 ` Blaisorblade 0 siblings, 0 replies; 8+ messages in thread From: Blaisorblade @ 2005-12-07 9:38 UTC (permalink / raw) To: user-mode-linux-devel; +Cc: Pekka Enberg, akpm, linux-kernel, jdike On Tuesday 06 December 2005 21:24, Pekka Enberg wrote: > Without the included patch, I get the following compile error for um: > > arch/um/kernel/tt/uaccess.c: In function `copy_from_user_tt': > arch/um/kernel/tt/uaccess.c:11: error: `FIXADDR_USER_START' undeclared > (first use in this function) arch/um/kernel/tt/uaccess.c:11: error: (Each > undeclared identifier is reported only once arch/um/kernel/tt/uaccess.c:11: > error: for each function it appears in.) > > The error only happens when I disable CONFIG_MODE_SKAS. Ok, fine, just a note - the header inclusion should be added to arch/um/include/um_uaccess.h where it is effectively used (the offending macros, using FIXADDR_USER_*, are __access_ok_vsyscall. For the rest it's ok. -- Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!". Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894) http://www.user-mode-linux.org/~blaisorblade ___________________________________ Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB http://mail.yahoo.it ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [uml-devel] [PATCH] um: fix compile error for tt 2005-12-07 9:38 ` Blaisorblade @ 2005-12-07 13:39 ` Pekka J Enberg -1 siblings, 0 replies; 8+ messages in thread From: Pekka J Enberg @ 2005-12-07 13:39 UTC (permalink / raw) To: Blaisorblade; +Cc: user-mode-linux-devel, akpm, linux-kernel, jdike Hi, On Wed, 7 Dec 2005, Blaisorblade wrote: > Ok, fine, just a note - the header inclusion should be added to > > arch/um/include/um_uaccess.h > > where it is effectively used (the offending macros, using FIXADDR_USER_*, are > __access_ok_vsyscall. > > For the rest it's ok. Here's an updated patch. [PATCH] um: fix compile error for tt Without the included patch, I get the following compile error for um: arch/um/kernel/tt/uaccess.c: In function `copy_from_user_tt': arch/um/kernel/tt/uaccess.c:11: error: `FIXADDR_USER_START' undeclared (first use in this function) arch/um/kernel/tt/uaccess.c:11: error: (Each undeclared identifier is reported only once arch/um/kernel/tt/uaccess.c:11: error: for each function it appears in.) I get the compile error when I disable CONFIG_MODE_SKAS. Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi> --- include/um_uaccess.h | 2 ++ kernel/skas/include/uaccess-skas.h | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) Index: 2.6/arch/um/include/um_uaccess.h =================================================================== --- 2.6.orig/arch/um/include/um_uaccess.h +++ 2.6/arch/um/include/um_uaccess.h @@ -17,6 +17,8 @@ #include "uaccess-skas.h" #endif +#include "asm/fixmap.h" + #define __under_task_size(addr, size) \ (((unsigned long) (addr) < TASK_SIZE) && \ (((unsigned long) (addr) + (size)) < TASK_SIZE)) Index: 2.6/arch/um/kernel/skas/include/uaccess-skas.h =================================================================== --- 2.6.orig/arch/um/kernel/skas/include/uaccess-skas.h +++ 2.6/arch/um/kernel/skas/include/uaccess-skas.h @@ -7,7 +7,6 @@ #define __SKAS_UACCESS_H #include "asm/errno.h" -#include "asm/fixmap.h" /* No SKAS-specific checking. */ #define access_ok_skas(type, addr, size) 0 ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [uml-devel] [PATCH] um: fix compile error for tt @ 2005-12-07 13:39 ` Pekka J Enberg 0 siblings, 0 replies; 8+ messages in thread From: Pekka J Enberg @ 2005-12-07 13:39 UTC (permalink / raw) To: Blaisorblade; +Cc: user-mode-linux-devel, akpm, linux-kernel, jdike Hi, On Wed, 7 Dec 2005, Blaisorblade wrote: > Ok, fine, just a note - the header inclusion should be added to > > arch/um/include/um_uaccess.h > > where it is effectively used (the offending macros, using FIXADDR_USER_*, are > __access_ok_vsyscall. > > For the rest it's ok. Here's an updated patch. [PATCH] um: fix compile error for tt Without the included patch, I get the following compile error for um: arch/um/kernel/tt/uaccess.c: In function `copy_from_user_tt': arch/um/kernel/tt/uaccess.c:11: error: `FIXADDR_USER_START' undeclared (first use in this function) arch/um/kernel/tt/uaccess.c:11: error: (Each undeclared identifier is reported only once arch/um/kernel/tt/uaccess.c:11: error: for each function it appears in.) I get the compile error when I disable CONFIG_MODE_SKAS. Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi> --- include/um_uaccess.h | 2 ++ kernel/skas/include/uaccess-skas.h | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) Index: 2.6/arch/um/include/um_uaccess.h =================================================================== --- 2.6.orig/arch/um/include/um_uaccess.h +++ 2.6/arch/um/include/um_uaccess.h @@ -17,6 +17,8 @@ #include "uaccess-skas.h" #endif +#include "asm/fixmap.h" + #define __under_task_size(addr, size) \ (((unsigned long) (addr) < TASK_SIZE) && \ (((unsigned long) (addr) + (size)) < TASK_SIZE)) Index: 2.6/arch/um/kernel/skas/include/uaccess-skas.h =================================================================== --- 2.6.orig/arch/um/kernel/skas/include/uaccess-skas.h +++ 2.6/arch/um/kernel/skas/include/uaccess-skas.h @@ -7,7 +7,6 @@ #define __SKAS_UACCESS_H #include "asm/errno.h" -#include "asm/fixmap.h" /* No SKAS-specific checking. */ #define access_ok_skas(type, addr, size) 0 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [uml-devel] [PATCH] um: fix compile error for tt 2005-12-07 13:39 ` Pekka J Enberg @ 2005-12-07 16:16 ` Blaisorblade -1 siblings, 0 replies; 8+ messages in thread From: Blaisorblade @ 2005-12-07 16:16 UTC (permalink / raw) To: user-mode-linux-devel; +Cc: Pekka J Enberg, akpm, linux-kernel, jdike On Wednesday 07 December 2005 14:39, Pekka J Enberg wrote: > Hi, > > On Wed, 7 Dec 2005, Blaisorblade wrote: > > Ok, fine, just a note - the header inclusion should be added to > > > > arch/um/include/um_uaccess.h > > > > where it is effectively used (the offending macros, using FIXADDR_USER_*, > > are __access_ok_vsyscall. > > > > For the rest it's ok. > > Here's an updated patch. ACK - Andrew, please merge (and queue for -linus), or notify if it needs to be resent. Thanks. -- Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!". Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894) http://www.user-mode-linux.org/~blaisorblade ___________________________________ Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB http://mail.yahoo.it ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [uml-devel] [PATCH] um: fix compile error for tt @ 2005-12-07 16:16 ` Blaisorblade 0 siblings, 0 replies; 8+ messages in thread From: Blaisorblade @ 2005-12-07 16:16 UTC (permalink / raw) To: user-mode-linux-devel; +Cc: Pekka J Enberg, akpm, linux-kernel, jdike On Wednesday 07 December 2005 14:39, Pekka J Enberg wrote: > Hi, > > On Wed, 7 Dec 2005, Blaisorblade wrote: > > Ok, fine, just a note - the header inclusion should be added to > > > > arch/um/include/um_uaccess.h > > > > where it is effectively used (the offending macros, using FIXADDR_USER_*, > > are __access_ok_vsyscall. > > > > For the rest it's ok. > > Here's an updated patch. ACK - Andrew, please merge (and queue for -linus), or notify if it needs to be resent. Thanks. -- Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!". Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894) http://www.user-mode-linux.org/~blaisorblade ___________________________________ Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB http://mail.yahoo.it ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2005-12-07 16:17 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2005-12-06 20:24 [uml-devel] [PATCH] um: fix compile error for tt Pekka Enberg 2005-12-06 20:24 ` Pekka Enberg 2005-12-07 9:38 ` [uml-devel] " Blaisorblade 2005-12-07 9:38 ` Blaisorblade 2005-12-07 13:39 ` Pekka J Enberg 2005-12-07 13:39 ` Pekka J Enberg 2005-12-07 16:16 ` Blaisorblade 2005-12-07 16:16 ` Blaisorblade
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.