From: Eric Sesterhenn / snakebyte <snakebyte@gmx.de>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] [Patch] check u32 < 0 in cpufreq-nforce2
Date: Wed, 14 Dec 2005 12:26:49 +0000 [thread overview]
Message-ID: <1134563209.23516.2.camel@alice> (raw)
[-- Attachment #1: Type: text/plain, Size: 688 bytes --]
Hi,
arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c declares
pll as u32 which is unsigned, and checks it agains < 0.
This patch changes it from u32 to s32 so the check
makes sense, nforce2_write_pll() and nforce2_calc_pll()
also expect/return a signed int.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c.orig 2005-12-14 13:19:43.000000000 +0100
+++ arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c 2005-12-14 13:23:40.000000000 +0100
@@ -177,7 +177,8 @@ static unsigned int nforce2_fsb_read(int
*/
static int nforce2_set_fsb(unsigned int fsb)
{
- u32 pll, temp = 0;
+ u32 temp = 0;
+ s32 pll;
unsigned int tfsb;
int diff;
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next reply other threads:[~2005-12-14 12:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-14 12:26 Eric Sesterhenn / snakebyte [this message]
2005-12-14 12:49 ` [KJ] [Patch] check u32 < 0 in cpufreq-nforce2 Jesper Juhl
2005-12-14 12:58 ` Eric Sesterhenn / snakebyte
2005-12-14 13:33 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1134563209.23516.2.camel@alice \
--to=snakebyte@gmx.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.