All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [Patch] check u32 < 0 in cpufreq-nforce2
Date: Wed, 14 Dec 2005 13:33:35 +0000	[thread overview]
Message-ID: <20051214133335.GD3829@redhat.com> (raw)
In-Reply-To: <1134563209.23516.2.camel@alice>

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

On Wed, Dec 14, 2005 at 01:26:49PM +0100, Eric Sesterhenn / snakebyte wrote:
 > Hi,
 > 
 > arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c declares
 > pll as u32 which is unsigned, and checks it agains < 0.
 > This patch changes it from u32 to s32 so the check
 > makes sense, nforce2_write_pll() and nforce2_calc_pll()
 > also expect/return a signed int.
 > 
 > Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>

Already fixed in cpufreq.git / -mm
Will go to Linus post 2.6.15

		Dave


[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

      parent reply	other threads:[~2005-12-14 13:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-14 12:26 [KJ] [Patch] check u32 < 0 in cpufreq-nforce2 Eric Sesterhenn / snakebyte
2005-12-14 12:49 ` Jesper Juhl
2005-12-14 12:58 ` Eric Sesterhenn / snakebyte
2005-12-14 13:33 ` Dave Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051214133335.GD3829@redhat.com \
    --to=davej@redhat.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.