From: James Bottomley <James.Bottomley@steeleye.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Russell King <rmk+lkml@arm.linux.org.uk>,
Nicolas Pitre <nico@cam.org>, David Howells <dhowells@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-arch@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
mingo@redhat.com, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 1/12]: MUTEX: Implement mutexes
Date: Sun, 18 Dec 2005 13:41:26 -0600 [thread overview]
Message-ID: <1134934887.3517.15.camel@mulgrave> (raw)
In-Reply-To: <Pine.LNX.4.64.0512181027220.4827@g5.osdl.org>
On Sun, 2005-12-18 at 10:42 -0800, Linus Torvalds wrote:
> It's easy enough to add a "might_sleep()" to the up(). Not strictly true,
> but conceptually it would make sense to make up/down match in that sense.
> We'd have to mark the (few) places that do down_trylock() + up() in
> interrupt context with a special "up_in_interrupt()", but that would be ok
> even from a documentation standpoint.
Actually, I don't think you want might_sleep(): there are a few cases
where we do an up() from under a spinlock, which will spuriously trigger
this. I'd suggest WARN_ON(in_interrupt()) instead.
James
next prev parent reply other threads:[~2005-12-18 19:41 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-16 23:13 [PATCH 0/12]: MUTEX: Introduce mutex implementation David Howells
2005-12-16 23:13 ` [PATCH 3/12]: MUTEX: Rename DECLARE_MUTEX for arch/ dir David Howells
2005-12-16 23:13 ` [PATCH 1/12]: MUTEX: Implement mutexes David Howells
2005-12-17 3:58 ` Steven Rostedt
2005-12-17 7:35 ` Linus Torvalds
2005-12-17 19:21 ` David Howells
2005-12-17 20:11 ` Linus Torvalds
2005-12-17 21:44 ` Russell King
2005-12-18 1:29 ` Nicolas Pitre
2005-12-18 2:34 ` Linus Torvalds
2005-12-18 4:07 ` Nicolas Pitre
2005-12-18 4:18 ` Steven Rostedt
2005-12-18 6:30 ` Linus Torvalds
2005-12-18 9:26 ` Russell King
2005-12-18 18:42 ` Linus Torvalds
2005-12-18 19:41 ` James Bottomley [this message]
2005-12-18 19:54 ` Linus Torvalds
2005-12-19 1:48 ` Nicolas Pitre
2005-12-19 9:27 ` Russell King
2005-12-19 13:54 ` Matthew Wilcox
2005-12-19 15:49 ` Nicolas Pitre
2005-12-19 15:45 ` Nicolas Pitre
2005-12-18 17:29 ` Nicolas Pitre
2005-12-18 13:38 ` Alan Cox
2005-12-18 17:21 ` Nicolas Pitre
2005-12-17 7:55 ` Nick Piggin
2005-12-17 12:36 ` Steven Rostedt
2005-12-16 23:13 ` [PATCH 2/12]: MUTEX: Provide SWAP-based mutex for FRV David Howells
2005-12-16 23:13 ` [PATCH 6/12]: MUTEX: Rename DECLARE_MUTEX for fs/ dir David Howells
2005-12-16 23:13 ` [PATCH 7/12]: MUTEX: Rename DECLARE_MUTEX for include/asm-*/ dirs David Howells
2005-12-16 23:13 ` [PATCH 10/12]: MUTEX: Rename DECLARE_MUTEX for sound/ dir David Howells
2005-12-16 23:13 ` [PATCH 9/12]: MUTEX: Rename DECLARE_MUTEX for net/ dir David Howells
2005-12-16 23:13 ` [PATCH 4/12]: MUTEX: Rename DECLARE_MUTEX for drivers/ dir, A thru M David Howells
2005-12-16 23:13 ` [PATCH 11/12]: MUTEX: Rename DECLARE_MUTEX for miscellaneous directories David Howells
2005-12-16 23:13 ` [PATCH 8/12]: MUTEX: Rename DECLARE_MUTEX for kernel/ dir David Howells
2005-12-16 23:13 ` [PATCH 5/12]: MUTEX: Rename DECLARE_MUTEX for drivers/ dir, N thru Z David Howells
2005-12-16 23:13 ` [PATCH 12/12]: MUTEX: Provide synchronisation primitive testing module David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1134934887.3517.15.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nico@cam.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=rostedt@goodmis.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.