[KJ] [PATCH] use PCI_DMA_*BIT in ioc3-eth.c

[KJ] [PATCH] use PCI_DMA_*BIT in ioc3-eth.c

[Eric Sesterhenn / snakebyte]

[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]

hi,

this changes the 0xfff.. constants used for pci_set_dma* to
defines in the ioc3 driver.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>


--- linux-2.6.15-eric/drivers/net/ioc3-eth.c.orig	2006-01-06 00:02:54.000000000 +0100
+++ linux-2.6.15-eric/drivers/net/ioc3-eth.c	2006-01-06 00:07:14.000000000 +0100
@@ -1195,17 +1195,17 @@ static int ioc3_probe(struct pci_dev *pd
 	int err, pci_using_dac;
 
 	/* Configure DMA attributes. */
-	err = pci_set_dma_mask(pdev, 0xffffffffffffffffULL);
+	err = pci_set_dma_mask(pdev, PCI_DMA_64BIT);
 	if (!err) {
 		pci_using_dac = 1;
-		err = pci_set_consistent_dma_mask(pdev, 0xffffffffffffffffULL);
+		err = pci_set_consistent_dma_mask(pdev, PCI_DMA_64BIT);
 		if (err < 0) {
 			printk(KERN_ERR "%s: Unable to obtain 64 bit DMA "
 			       "for consistent allocations\n", pci_name(pdev));
 			goto out;
 		}
 	} else {
-		err = pci_set_dma_mask(pdev, 0xffffffffULL);
+		err = pci_set_dma_mask(pdev, PCI_DMA_32BIT);
 		if (err) {
 			printk(KERN_ERR "%s: No usable DMA configuration, "
 			       "aborting.\n", pci_name(pdev));



[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] use PCI_DMA_*BIT in ioc3-eth.c

[Tobias Klauser]

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

On 2006-01-06 at 00:11:52 +0100, Eric Sesterhenn / snakebyte <snakebyte@gmx.de> wrote:
> this changes the 0xfff.. constants used for pci_set_dma* to
> defines in the ioc3 driver.

This one is alread in -kj [1]. Guess I did them all, they're just not all in
mainline.

[1]
http://coderock.org/kj/2.6.15-rc5-kj1/2.6.15-rc5-kj1-broken-out/drivers_net_ioc3_eth_c_use_dma_32_64_bit_mask.patch

Cheers, Tobias

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] use PCI_DMA_*BIT in ioc3-eth.c

[Eric Sesterhenn / snakebyte]

[-- Attachment #1: Type: text/plain, Size: 533 bytes --]

On Fri, 2006-01-06 at 00:24 +0100, Tobias Klauser wrote:
> On 2006-01-06 at 00:11:52 +0100, Eric Sesterhenn / snakebyte <snakebyte@gmx.de> wrote:
> > this changes the 0xfff.. constants used for pci_set_dma* to
> > defines in the ioc3 driver.
> 
> This one is alread in -kj [1]. Guess I did them all, they're just not all in
> mainline.

Nice, this saves some work. guess we can remove this from the TODO
list then. same should apply to MOD_{DEC,INC}_USE_COUNT after
the two patches i send last month get into -kj or mainline.

Eric


[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors