* [KJ] [Patch] replace MODULE_PARM in net/fs_enet/fs_enet-main.c
@ 2006-01-10 13:04 Eric Sesterhenn / snakebyte
2006-01-10 19:42 ` Alexey Dobriyan
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Eric Sesterhenn / snakebyte @ 2006-01-10 13:04 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 599 bytes --]
hi,
this patch replaces the MODULE_PARM usage
with module_param.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.15-git5/drivers/net/fs_enet/fs_enet-main.c.orig 2006-01-10 14:00:05.000000000 +0100
+++ linux-2.6.15-git5/drivers/net/fs_enet/fs_enet-main.c 2006-01-10 14:00:22.000000000 +0100
@@ -58,7 +58,7 @@ MODULE_DESCRIPTION("Freescale Ethernet D
MODULE_LICENSE("GPL");
MODULE_VERSION(DRV_MODULE_VERSION);
-MODULE_PARM(fs_enet_debug, "i");
+module_param(fs_enet_debug, int, 0);
MODULE_PARM_DESC(fs_enet_debug,
"Freescale bitmapped debugging message enable value");
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [KJ] [Patch] replace MODULE_PARM in net/fs_enet/fs_enet-main.c
2006-01-10 13:04 [KJ] [Patch] replace MODULE_PARM in net/fs_enet/fs_enet-main.c Eric Sesterhenn / snakebyte
@ 2006-01-10 19:42 ` Alexey Dobriyan
2006-01-10 19:59 ` Eric Sesterhenn / snakebyte
2006-01-18 11:47 ` Vitaly Bordug
2 siblings, 0 replies; 4+ messages in thread
From: Alexey Dobriyan @ 2006-01-10 19:42 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 447 bytes --]
On Tue, Jan 10, 2006 at 02:04:35PM +0100, Eric Sesterhenn / snakebyte wrote:
> --- linux-2.6.15-git5/drivers/net/fs_enet/fs_enet-main.c.orig
> +++ linux-2.6.15-git5/drivers/net/fs_enet/fs_enet-main.c
> -MODULE_PARM(fs_enet_debug, "i");
> +module_param(fs_enet_debug, int, 0);
> MODULE_PARM_DESC(fs_enet_debug,
> "Freescale bitmapped debugging message enable value");
Is there any logic in choosing 0644 over 0 or vice versa?
/me confused
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [KJ] [Patch] replace MODULE_PARM in net/fs_enet/fs_enet-main.c
2006-01-10 13:04 [KJ] [Patch] replace MODULE_PARM in net/fs_enet/fs_enet-main.c Eric Sesterhenn / snakebyte
2006-01-10 19:42 ` Alexey Dobriyan
@ 2006-01-10 19:59 ` Eric Sesterhenn / snakebyte
2006-01-18 11:47 ` Vitaly Bordug
2 siblings, 0 replies; 4+ messages in thread
From: Eric Sesterhenn / snakebyte @ 2006-01-10 19:59 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1168 bytes --]
hi,
> > -MODULE_PARM(fs_enet_debug, "i");
> > +module_param(fs_enet_debug, int, 0);
> > MODULE_PARM_DESC(fs_enet_debug,
> > "Freescale bitmapped debugging message enable value");
>
> Is there any logic in choosing 0644 over 0 or vice versa?
>
> /me confused
This should be 0644, sorry. The logic behind this is that you can
change the debug setting during runtime because the file permissions
for the /proc entry allow you to change it.
For values that are only intended to be command line parameters, 0 is
always a safe bet, so we dont leak information. At least thats how
i understand it :)
Here is the changed patch
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.15-git5/drivers/net/fs_enet/fs_enet-main.c.orig 2006-01-10 14:00:05.000000000 +0100
+++ linux-2.6.15-git5/drivers/net/fs_enet/fs_enet-main.c 2006-01-10 14:00:22.000000000 +0100
@@ -58,7 +58,7 @@ MODULE_DESCRIPTION("Freescale Ethernet D
MODULE_LICENSE("GPL");
MODULE_VERSION(DRV_MODULE_VERSION);
-MODULE_PARM(fs_enet_debug, "i");
+module_param(fs_enet_debug, int, 0644);
MODULE_PARM_DESC(fs_enet_debug,
"Freescale bitmapped debugging message enable value");
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [KJ] [Patch] replace MODULE_PARM in net/fs_enet/fs_enet-main.c
2006-01-10 13:04 [KJ] [Patch] replace MODULE_PARM in net/fs_enet/fs_enet-main.c Eric Sesterhenn / snakebyte
2006-01-10 19:42 ` Alexey Dobriyan
2006-01-10 19:59 ` Eric Sesterhenn / snakebyte
@ 2006-01-18 11:47 ` Vitaly Bordug
2 siblings, 0 replies; 4+ messages in thread
From: Vitaly Bordug @ 2006-01-18 11:47 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 755 bytes --]
On Tue, 10 Jan 2006 20:59:31 +0100
Eric Sesterhenn / snakebyte <snakebyte@gmx.de> wrote:
[snip]
>
> Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
>
>
OK, I'll include this into my next changeset.
thanks.
> --- linux-2.6.15-git5/drivers/net/fs_enet/fs_enet-main.c.orig 2006-01-10 14:00:05.000000000 +0100
> +++ linux-2.6.15-git5/drivers/net/fs_enet/fs_enet-main.c 2006-01-10 14:00:22.000000000 +0100
> @@ -58,7 +58,7 @@ MODULE_DESCRIPTION("Freescale Ethernet D
> MODULE_LICENSE("GPL");
> MODULE_VERSION(DRV_MODULE_VERSION);
>
> -MODULE_PARM(fs_enet_debug, "i");
> +module_param(fs_enet_debug, int, 0644);
> MODULE_PARM_DESC(fs_enet_debug,
> "Freescale bitmapped debugging message enable value");
>
>
>
>
>
--
Sincerely,
Vitaly
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-01-18 11:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-10 13:04 [KJ] [Patch] replace MODULE_PARM in net/fs_enet/fs_enet-main.c Eric Sesterhenn / snakebyte
2006-01-10 19:42 ` Alexey Dobriyan
2006-01-10 19:59 ` Eric Sesterhenn / snakebyte
2006-01-18 11:47 ` Vitaly Bordug
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.