All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Greg KH <gregkh@suse.de>
Cc: Adrian Bunk <bunk@stusta.de>,
	Jes Sorensen <jes@trained-monkey.org>,
	torvalds@osdl.org, akpm@osdl.org, tony.luck@intel.com,
	linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-usb-devel@lists.sourceforge.net, R.E.Wolff@BitWizard.nl,
	paulus@samba.org, linuxppc-dev@ozlabs.org
Subject: Re: [linux-usb-devel] Re: [2.6 patch] remove unused tmp_buf_sem's
Date: Sun, 15 Jan 2006 15:46:16 +0000	[thread overview]
Message-ID: <1137339976.2350.2.camel@localhost.localdomain> (raw)
In-Reply-To: <20060114034903.GA23074@suse.de>

On Gwe, 2006-01-13 at 19:49 -0800, Greg KH wrote:
> On Sat, Jan 14, 2006 at 03:08:16AM +0100, Adrian Bunk wrote:
> > <--  snip  -->
> > 
> > 
> > tmp_buf_sem sems to be a common name for something completely unused...


That would be correct. The old tty driver layer used to call ->write
from both kernel and user contexts according to a flag. Drivers then all
ended up with the same code copying it into a tmp buffer and using a
locking semaphore. 

Linus took out that code and arranged that ->write always got a kernel
buffer so the remainders should indeed go.

Alan


WARNING: multiple messages have this Message-ID (diff)
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Greg KH <gregkh@suse.de>
Cc: akpm@osdl.org, Jes Sorensen <jes@trained-monkey.org>,
	tony.luck@intel.com, linux-ia64@vger.kernel.org,
	linux-usb-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, Adrian Bunk <bunk@stusta.de>,
	linuxppc-dev@ozlabs.org, torvalds@osdl.org,
	R.E.Wolff@BitWizard.nl
Subject: Re: [linux-usb-devel] Re: [2.6 patch] remove unused tmp_buf_sem's
Date: Sun, 15 Jan 2006 15:46:16 +0000	[thread overview]
Message-ID: <1137339976.2350.2.camel@localhost.localdomain> (raw)
In-Reply-To: <20060114034903.GA23074@suse.de>

On Gwe, 2006-01-13 at 19:49 -0800, Greg KH wrote:
> On Sat, Jan 14, 2006 at 03:08:16AM +0100, Adrian Bunk wrote:
> > <--  snip  -->
> > 
> > 
> > tmp_buf_sem sems to be a common name for something completely unused...


That would be correct. The old tty driver layer used to call ->write
from both kernel and user contexts according to a flag. Drivers then all
ended up with the same code copying it into a tmp buffer and using a
locking semaphore. 

Linus took out that code and arranged that ->write always got a kernel
buffer so the remainders should indeed go.

Alan

  reply	other threads:[~2006-01-15 15:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-11 11:52 [patch] remove unused semaphore from arch/ia64/hp/sim/simserial.c Jes Sorensen
2006-01-11 11:52 ` Jes Sorensen
2006-01-14  2:08 ` [2.6 patch] remove unused tmp_buf_sem's Adrian Bunk
2006-01-14  2:08   ` Adrian Bunk
2006-01-14  2:08   ` Adrian Bunk
2006-01-14  3:49   ` Greg KH
2006-01-14  3:49     ` Greg KH
2006-01-14  3:49     ` Greg KH
2006-01-15 15:46     ` Alan Cox [this message]
2006-01-15 15:46       ` [linux-usb-devel] " Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1137339976.2350.2.camel@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=R.E.Wolff@BitWizard.nl \
    --cc=akpm@osdl.org \
    --cc=bunk@stusta.de \
    --cc=gregkh@suse.de \
    --cc=jes@trained-monkey.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=tony.luck@intel.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.