[KJ] [Patch] change if() BUG(); to BUG_ON() in mm/pdflush.c

[KJ] [Patch] change if() BUG(); to BUG_ON() in mm/pdflush.c

[Eric Sesterhenn / snakebyte]

[-- Attachment #1: Type: text/plain, Size: 586 bytes --]

hi,

this changes an if() BUG(); statement to
BUG_ON() in mm/pdflush.c

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>

--- linux-2.6.15-git11/mm/pdflush.c.orig	2006-01-16 21:49:55.000000000 +0100
+++ linux-2.6.15-git11/mm/pdflush.c	2006-01-16 21:50:27.000000000 +0100
@@ -202,8 +202,7 @@ int pdflush_operation(void (*fn)(unsigne
 	unsigned long flags;
 	int ret = 0;
 
-	if (fn == NULL)
-		BUG();		/* Hard to diagnose if it's deferred */
+	BUG_ON(fn == NULL);	/* Hard to diagnose if it's deferred */
 
 	spin_lock_irqsave(&pdflush_lock, flags);
 	if (list_empty(&pdflush_list)) {



[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

[KJ] [Patch] change if() BUG(); to BUG_ON() in

[Eric Sesterhenn / snakebyte]

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

hi,

this patch changes the if() BUG(); construct in
drivers/net/ixgb/ixgb_osdep.h to a BUG_ON; so defining
BUG to a no-op is safe.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>

--- linux-2.6.15-git11/drivers/net/ixgb/ixgb_osdep.h.orig	2006-01-17 22:12:00.000000000 +0100
+++ linux-2.6.15-git11/drivers/net/ixgb/ixgb_osdep.h	2006-01-17 22:12:46.000000000 +0100
@@ -60,7 +60,7 @@ typedef enum {
 } boolean_t;
 
 #undef ASSERT
-#define ASSERT(x)	if(!(x)) BUG()
+#define ASSERT(x)	BUG_ON(!(x))
 #define MSGOUT(S, A, B)	printk(KERN_DEBUG S "\n", A, B)
 
 #ifdef DBG



[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors