From: Dave Hansen <haveblue@us.ibm.com>
To: Andy Whitcroft <apw@shadowen.org>
Cc: Andrew Morton <akpm@osdl.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] zonelists gfp_zone() is really gfp_zonelist()
Date: Tue, 17 Jan 2006 09:31:39 -0800 [thread overview]
Message-ID: <1137519100.5526.11.camel@localhost.localdomain> (raw)
In-Reply-To: <20060117155010.GA16135@shadowen.org>
On Tue, 2006-01-17 at 15:50 +0000, Andy Whitcroft wrote:
> +/*
> + * Extract the gfp modifier space index from the flags word. Note that
> + * this is not a zone number.
> + */
> +static inline int gfp_zonelist(gfp_t gfp)
> {
> - int zone = GFP_ZONEMASK & (__force int) gfp;
> - BUG_ON(zone >= GFP_ZONETYPES);
> - return zone;
> + int zonelist = GFP_ZONEMASK & (__force int) gfp;
> + BUG_ON(zonelist >= GFP_ZONETYPES);
> + return zonelist;
> }
Hmm, but it's not really a zonelist, either. It's an index into an
array of zonelists that gets you a zonelist. How about
gfp_to_zonelist_nr()?
-- Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <haveblue@us.ibm.com>
To: Andy Whitcroft <apw@shadowen.org>
Cc: Andrew Morton <akpm@osdl.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] zonelists gfp_zone() is really gfp_zonelist()
Date: Tue, 17 Jan 2006 09:31:39 -0800 [thread overview]
Message-ID: <1137519100.5526.11.camel@localhost.localdomain> (raw)
In-Reply-To: <20060117155010.GA16135@shadowen.org>
On Tue, 2006-01-17 at 15:50 +0000, Andy Whitcroft wrote:
> +/*
> + * Extract the gfp modifier space index from the flags word. Note that
> + * this is not a zone number.
> + */
> +static inline int gfp_zonelist(gfp_t gfp)
> {
> - int zone = GFP_ZONEMASK & (__force int) gfp;
> - BUG_ON(zone >= GFP_ZONETYPES);
> - return zone;
> + int zonelist = GFP_ZONEMASK & (__force int) gfp;
> + BUG_ON(zonelist >= GFP_ZONETYPES);
> + return zonelist;
> }
Hmm, but it's not really a zonelist, either. It's an index into an
array of zonelists that gets you a zonelist. How about
gfp_to_zonelist_nr()?
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-01-17 17:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-17 15:50 [PATCH] zonelists gfp_zone() is really gfp_zonelist() Andy Whitcroft
2006-01-17 15:50 ` Andy Whitcroft
2006-01-17 17:31 ` Dave Hansen [this message]
2006-01-17 17:31 ` Dave Hansen
2006-01-17 17:56 ` Andy Whitcroft
2006-01-17 17:56 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1137519100.5526.11.camel@localhost.localdomain \
--to=haveblue@us.ibm.com \
--cc=akpm@osdl.org \
--cc=apw@shadowen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.