* [2.6 patch] sound/pci/cs46xx/dsp_spos_scb_lib.c: fix an assertion
@ 2006-01-17 18:47 Adrian Bunk
2006-01-17 18:52 ` [Alsa-devel] " Lee Revell
2006-01-17 18:52 ` Lee Revell
0 siblings, 2 replies; 3+ messages in thread
From: Adrian Bunk @ 2006-01-17 18:47 UTC (permalink / raw)
To: perex; +Cc: alsa-devel, linux-kernel, D Binderman
D Binderman <dcb314@hotmail.com> reported the following in kernel
Bugzilla #5903 [1]:
<-- snip -->
I just tried to compile kernel 2.6.15.1 with the Intel C compiler.
It said
sound/pci/cs46xx/dsp_spos_scb_lib.c(673): warning #187: use of "=" where
"==" may have been intended
The source code is
snd_assert (rate = 48000);
I agree with the compiler. Suggest new code
snd_assert (rate == 48000);
<-- snip -->
Thankfully this bug would only become visible if the assertion was
false, but anyways it's a bug.
[1] http://bugzilla.kernel.org/show_bug.cgi?id=5903
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.15-mm4-full/sound/pci/cs46xx/dsp_spos_scb_lib.c.old 2006-01-16 20:20:23.000000000 +0100
+++ linux-2.6.15-mm4-full/sound/pci/cs46xx/dsp_spos_scb_lib.c 2006-01-16 20:21:17.000000000 +0100
@@ -677,7 +677,7 @@
if (pass_through) {
/* wont work with any other rate than
the native DSP rate */
- snd_assert (rate = 48000);
+ snd_assert (rate == 48000);
scb = cs46xx_dsp_create_generic_scb(chip,scb_name,(u32 *)&src_task_scb,
dest,"DMAREADER",parent_scb,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] sound/pci/cs46xx/dsp_spos_scb_lib.c: fix an assertion
2006-01-17 18:47 [2.6 patch] sound/pci/cs46xx/dsp_spos_scb_lib.c: fix an assertion Adrian Bunk
2006-01-17 18:52 ` [Alsa-devel] " Lee Revell
@ 2006-01-17 18:52 ` Lee Revell
1 sibling, 0 replies; 3+ messages in thread
From: Lee Revell @ 2006-01-17 18:52 UTC (permalink / raw)
To: Adrian Bunk; +Cc: perex, alsa-devel, linux-kernel, D Binderman
On Tue, 2006-01-17 at 19:47 +0100, Adrian Bunk wrote:
> D Binderman <dcb314@hotmail.com> reported the following in kernel
> Bugzilla #5903 [1]:
Already fixed in CVS
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Alsa-devel] [2.6 patch] sound/pci/cs46xx/dsp_spos_scb_lib.c: fix an assertion
2006-01-17 18:47 [2.6 patch] sound/pci/cs46xx/dsp_spos_scb_lib.c: fix an assertion Adrian Bunk
@ 2006-01-17 18:52 ` Lee Revell
2006-01-17 18:52 ` Lee Revell
1 sibling, 0 replies; 3+ messages in thread
From: Lee Revell @ 2006-01-17 18:52 UTC (permalink / raw)
To: Adrian Bunk; +Cc: perex, alsa-devel, linux-kernel, D Binderman
On Tue, 2006-01-17 at 19:47 +0100, Adrian Bunk wrote:
> D Binderman <dcb314@hotmail.com> reported the following in kernel
> Bugzilla #5903 [1]:
Already fixed in CVS
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-01-17 18:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-17 18:47 [2.6 patch] sound/pci/cs46xx/dsp_spos_scb_lib.c: fix an assertion Adrian Bunk
2006-01-17 18:52 ` [Alsa-devel] " Lee Revell
2006-01-17 18:52 ` Lee Revell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.