[KJ] [Patch 5/8] BUG_ON() Conversion in fs/dquot.c

[KJ] [Patch 5/8] BUG_ON() Conversion in fs/dquot.c

[Eric Sesterhenn / snakebyte]

[-- Attachment #1: Type: text/plain, Size: 1147 bytes --]

hi,

this changes if() BUG(); constructs to BUG_ON() which is
cleaner and can better optimized away

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>

--- linux-2.6.16-rc1-git4/fs/dquot.c.orig	2006-01-26 17:55:57.000000000 +0100
+++ linux-2.6.16-rc1-git4/fs/dquot.c	2006-01-26 17:56:34.000000000 +0100
@@ -420,8 +420,7 @@ static void invalidate_dquots(struct sup
 		if (dquot->dq_type != type)
 			continue;
 #ifdef __DQUOT_PARANOIA
-		if (atomic_read(&dquot->dq_count))
-			BUG();
+		BUG_ON(atomic_read(&dquot->dq_count));
 #endif
 		/* Quota now has no users and it has been written on last dqput() */
 		remove_dquot_hash(dquot);
@@ -560,8 +559,7 @@ we_slept:
 	atomic_dec(&dquot->dq_count);
 #ifdef __DQUOT_PARANOIA
 	/* sanity check */
-	if (!list_empty(&dquot->dq_free))
-		BUG();
+	BUG_ON(!list_empty(&dquot->dq_free));
 #endif
 	put_dquot_last(dquot);
 	spin_unlock(&dq_list_lock);
@@ -635,8 +633,7 @@ we_slept:
 		return NODQUOT;
 	}
 #ifdef __DQUOT_PARANOIA
-	if (!dquot->dq_sb)	/* Has somebody invalidated entry under us? */
-		BUG();
+	BUG_ON(!dquot->dq_sb);	/* Has somebody invalidated entry under us? */
 #endif
 
 	return dquot;



[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors