All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sesterhenn / snakebyte <snakebyte@gmx.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [Patch 7/7] BUG_ON() Conversion in mm/vmalloc.c
Date: Tue, 31 Jan 2006 14:53:15 +0000	[thread overview]
Message-ID: <1138719196.12413.4.camel@alice> (raw)
In-Reply-To: <1138712609.11570.21.camel@alice>

[-- Attachment #1: Type: text/plain, Size: 629 bytes --]

hi,

> > -			if (unlikely(!area->pages[i]))
> > -				BUG();
> > +			BUG_ON(unlikely(!area->pages[i]));
> >...
> 
> You can drop the unlikely.

of course... thanks.
Here is an updated patch

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>

--- linux-2.6.16-rc1-git4/mm/vmalloc.c.orig	2006-01-30 22:26:02.000000000 +0100
+++ linux-2.6.16-rc1-git4/mm/vmalloc.c	2006-01-30 22:26:56.000000000 +0100
@@ -321,8 +321,7 @@ void __vunmap(void *addr, int deallocate
 		int i;
 
 		for (i = 0; i < area->nr_pages; i++) {
-			if (unlikely(!area->pages[i]))
-				BUG();
+			BUG_ON(!area->pages[i]);
 			__free_page(area->pages[i]);
 		}
 



[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

      parent reply	other threads:[~2006-01-31 14:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-31 13:03 [KJ] [Patch 7/7] BUG_ON() Conversion in mm/vmalloc.c Eric Sesterhenn / snakebyte
2006-01-31 13:45 ` Adrian Bunk
2006-01-31 14:53 ` Eric Sesterhenn / snakebyte [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1138719196.12413.4.camel@alice \
    --to=snakebyte@gmx.de \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.