From: Adrian Bunk <bunk@stusta.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [Patch 7/7] BUG_ON() Conversion in mm/vmalloc.c
Date: Tue, 31 Jan 2006 13:45:17 +0000 [thread overview]
Message-ID: <20060131134517.GJ3655@stusta.de> (raw)
In-Reply-To: <1138712609.11570.21.camel@alice>
[-- Attachment #1: Type: text/plain, Size: 932 bytes --]
On Tue, Jan 31, 2006 at 02:03:29PM +0100, Eric Sesterhenn / snakebyte wrote:
> hi,
>
> this changes if() BUG(); constructs to BUG_ON() which is
> cleaner, contains unlikely() and can better optimized away.
>
> Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
>
> --- linux-2.6.16-rc1-git4/mm/vmalloc.c.orig 2006-01-30 22:26:02.000000000 +0100
> +++ linux-2.6.16-rc1-git4/mm/vmalloc.c 2006-01-30 22:26:56.000000000 +0100
> @@ -321,8 +321,7 @@ void __vunmap(void *addr, int deallocate
> int i;
>
> for (i = 0; i < area->nr_pages; i++) {
> - if (unlikely(!area->pages[i]))
> - BUG();
> + BUG_ON(unlikely(!area->pages[i]));
>...
You can drop the unlikely.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2006-01-31 13:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-31 13:03 [KJ] [Patch 7/7] BUG_ON() Conversion in mm/vmalloc.c Eric Sesterhenn / snakebyte
2006-01-31 13:45 ` Adrian Bunk [this message]
2006-01-31 14:53 ` Eric Sesterhenn / snakebyte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060131134517.GJ3655@stusta.de \
--to=bunk@stusta.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.