[PATCH 09/13] hrtimer: remove data field

[PATCH 09/13] hrtimer: remove data field

[Roman Zippel]

Remove the it_real_value from /proc/*/stat, during 1.2.x was the last
time it returned useful data (as it was directly maintained by the
scheduler), now it's only a waste of time to calculate it.

Signed-off-by: Roman Zippel <zippel@linux-m68k.org>

---

 fs/proc/array.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Index: linux-2.6-git/fs/proc/array.c
===================================================================
--- linux-2.6-git.orig/fs/proc/array.c	2006-02-12 18:32:46.000000000 +0100
+++ linux-2.6-git/fs/proc/array.c	2006-02-12 18:33:38.000000000 +0100
@@ -330,7 +330,6 @@ static int do_task_stat(struct task_stru
 	unsigned long  min_flt = 0,  maj_flt = 0;
 	cputime_t cutime, cstime, utime, stime;
 	unsigned long rsslim = 0;
-	DEFINE_KTIME(it_real_value);
 	struct task_struct *t;
 	char tcomm[sizeof(task->comm)];
 
@@ -386,7 +385,6 @@ static int do_task_stat(struct task_stru
 			utime = cputime_add(utime, task->signal->utime);
 			stime = cputime_add(stime, task->signal->stime);
 		}
-		it_real_value = task->signal->real_timer.expires;
 	}
 	ppid = pid_alive(task) ? task->group_leader->real_parent->tgid : 0;
 	read_unlock(&tasklist_lock);
@@ -413,7 +411,7 @@ static int do_task_stat(struct task_stru
 	start_time = nsec_to_clock_t(start_time);
 
 	res = sprintf(buffer,"%d (%s) %c %d %d %d %d %d %lu %lu \
-%lu %lu %lu %lu %lu %ld %ld %ld %ld %d %ld %llu %lu %ld %lu %lu %lu %lu %lu \
+%lu %lu %lu %lu %lu %ld %ld %ld %ld %d 0 %llu %lu %ld %lu %lu %lu %lu %lu \
 %lu %lu %lu %lu %lu %lu %lu %lu %d %d %lu %lu\n",
 		task->pid,
 		tcomm,
@@ -435,7 +433,6 @@ static int do_task_stat(struct task_stru
 		priority,
 		nice,
 		num_threads,
-		(long) ktime_to_clock_t(it_real_value),
 		start_time,
 		vsize,
 		mm ? get_mm_rss(mm) : 0,

Re: [PATCH 09/13] hrtimer: remove data field

[Lee Revell]

On Mon, 2006-02-13 at 02:11 +0100, Roman Zippel wrote:
> Remove the it_real_value from /proc/*/stat, during 1.2.x was the last
> time it returned useful data (as it was directly maintained by the
> scheduler), now it's only a waste of time to calculate it.

Won't this break apps that parse this file?

Lee

Re: [PATCH 09/13] hrtimer: remove data field

[Roman Zippel]

Hi,

On Sun, 12 Feb 2006, Lee Revell wrote:

> On Mon, 2006-02-13 at 02:11 +0100, Roman Zippel wrote:
> > Remove the it_real_value from /proc/*/stat, during 1.2.x was the last
> > time it returned useful data (as it was directly maintained by the
> > scheduler), now it's only a waste of time to calculate it.
> 
> Won't this break apps that parse this file?

No, it's now simply set to zero.

bye, Roman

Re: [PATCH 09/13] hrtimer: remove data field

[Ingo Molnar]

* Roman Zippel <zippel@linux-m68k.org> wrote:

> Remove the it_real_value from /proc/*/stat, during 1.2.x was the last 
> time it returned useful data (as it was directly maintained by the 
> scheduler), now it's only a waste of time to calculate it.

i'm happy with this change too - but i'd not assume anything about how 
useful this is to userspace apps ... So fine for -mm and v2.6.17, but 
not for v2.6.16.

Acked-by: Ingo Molnar <mingo@elte.hu>

	Ingo