Re: Dreamcast AICA driver

[Lee Revell <rlrevell@joe-job.com>]

On Sun, 2006-03-12 at 01:14 -0500, Lee Revell wrote:
> You should submit this to ALSA now, as a patch against CVS...


static int snd_aicapcm_free(snd_card_aica_t *dreamcastcard)
{
	release_mem_region(0xa0702c00, 0x4);
	release_mem_region(0xa0800000, 0x200000);
	return 0;
}

Actually this driver still has way too many magic numbers - if you're
not exactly sure what a constant does then document it with comments in
the header file.

It looks like many of these will be trivial to document:

	if (request_mem_region(0xa0702c00, 4, "AICA ARM control")== NULL) return -ENOMEM;
	if (request_mem_region(0xa0800000, 0x200000, "AICA Sound RAM") == NULL)

Lee



-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642