From: "Darren Jenkins\\" <darrenrjenkins@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: [KJ][Patch] check return value of request_irq in pcnet_cs.c
Date: Mon, 13 Mar 2006 04:37:33 +0000 [thread overview]
Message-ID: <1142224653.7791.26.camel@localhost.localdomain> (raw)
In-Reply-To: <1141029654.7765.6.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 836 bytes --]
G'day list
pcnet_cs.c called request_irq without checking its return value @ line
1036.
The patch below just checks the return value and returns -EBUSY on
failure.
This file also contains 4 space indenting so I might follow with a patch
to fix that too.
Signed-off-by: Darren Jenkins <darrenrjenkins@gmail.com>
--- linux-2.6.16-rc5/drivers/net/pcmcia/pcnet_cs.c.orig 2006-03-13 13:25:13.000000000 +1100
+++ linux-2.6.16-rc5/drivers/net/pcmcia/pcnet_cs.c 2006-03-13 13:46:07.000000000 +1100
@@ -1033,7 +1033,8 @@ static int pcnet_open(struct net_device
link->open++;
set_misc_reg(dev);
- request_irq(dev->irq, ei_irq_wrapper, SA_SHIRQ, dev_info, dev);
+ if (request_irq(dev->irq, ei_irq_wrapper, SA_SHIRQ, dev_info, dev) < 0 )
+ return -EBUSY
info->phy_id = info->eth_phy;
info->link_status = 0x00;
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2006-03-13 4:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-27 8:40 [KJ][Patch] check return value of request_region in matroxfb_base.c Darren Jenkins\
2006-03-01 7:12 ` [KJ][Patch] check return value of request region in ali5455.c Darren Jenkins\
2006-03-03 6:31 ` [KJ][Patch] check return value of request_region in Petr Vandrovec
2006-03-11 13:48 ` [KJ][Patch] check return value of request_irq in amiserial.c Darren Jenkins\
2006-03-13 4:37 ` Darren Jenkins\ [this message]
2006-03-13 5:00 ` [KJ][Patch] check return value of request_irq in pcnet_cs.c Randy.Dunlap
2006-03-13 5:16 ` Darren Jenkins\
2006-03-13 5:27 ` Randy.Dunlap
2006-03-13 6:16 ` Darren Jenkins\
2006-03-13 11:56 ` [KJ][Patch] check return value of request_irq in i82365.c Darren Jenkins\
2006-03-13 12:29 ` Tobias Klauser
2006-03-14 8:44 ` Darren Jenkins\
2006-03-14 16:26 ` Randy.Dunlap
2006-03-15 7:02 ` Darren Jenkins\
2006-03-15 7:32 ` Nishanth Aravamudan
2006-03-15 12:46 ` [KJ][Patch] check return value of request_region and request_irq Darren Jenkins\
2006-03-15 12:57 ` Tobias Klauser
2006-03-16 10:45 ` [KJ][Patch] check return value of request_region and Darren Jenkins\
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1142224653.7791.26.camel@localhost.localdomain \
--to=darrenrjenkins@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.