From: Nishanth Aravamudan <nacc@us.ibm.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ][Patch] check return value of request_irq in i82365.c
Date: Wed, 15 Mar 2006 07:32:30 +0000 [thread overview]
Message-ID: <20060315073230.GB5620@us.ibm.com> (raw)
In-Reply-To: <1141029654.7765.6.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 776 bytes --]
On 15.03.2006 [18:02:59 +1100], Darren Jenkins" wrote:
> On Tue, 2006-03-14 at 08:26 -0800, Randy.Dunlap wrote:
>
> > well.... if you have to make any more changes, add a space after
> > the "< 0)" and before the opening '{'.
> > The "grammar" isn't tough IMO. Maybe you are just used to not
> > using whitespace?
>
> White-space lol, I usually use a lot more, but I have never been
> restricted to 80 columns before and I'm not used to using the K&R coding
> style that you old folks all seem to use. :P
>
> Here is an improved patch. I guess I will start with the style cleanups,
> unless there are anymore problems.
Without looking at the thread, it's now impossible to know what the does
:) Always keep the description tag with each patch you send out.
Thanks,
Nish
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2006-03-15 7:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-27 8:40 [KJ][Patch] check return value of request_region in matroxfb_base.c Darren Jenkins\
2006-03-01 7:12 ` [KJ][Patch] check return value of request region in ali5455.c Darren Jenkins\
2006-03-03 6:31 ` [KJ][Patch] check return value of request_region in Petr Vandrovec
2006-03-11 13:48 ` [KJ][Patch] check return value of request_irq in amiserial.c Darren Jenkins\
2006-03-13 4:37 ` [KJ][Patch] check return value of request_irq in pcnet_cs.c Darren Jenkins\
2006-03-13 5:00 ` Randy.Dunlap
2006-03-13 5:16 ` Darren Jenkins\
2006-03-13 5:27 ` Randy.Dunlap
2006-03-13 6:16 ` Darren Jenkins\
2006-03-13 11:56 ` [KJ][Patch] check return value of request_irq in i82365.c Darren Jenkins\
2006-03-13 12:29 ` Tobias Klauser
2006-03-14 8:44 ` Darren Jenkins\
2006-03-14 16:26 ` Randy.Dunlap
2006-03-15 7:02 ` Darren Jenkins\
2006-03-15 7:32 ` Nishanth Aravamudan [this message]
2006-03-15 12:46 ` [KJ][Patch] check return value of request_region and request_irq Darren Jenkins\
2006-03-15 12:57 ` Tobias Klauser
2006-03-16 10:45 ` [KJ][Patch] check return value of request_region and Darren Jenkins\
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060315073230.GB5620@us.ibm.com \
--to=nacc@us.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.