From: Dave Hansen <haveblue@us.ibm.com>
To: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: Andrew Morton <akpm@osdl.org>, "Luck, Tony" <tony.luck@intel.com>,
Andi Kleen <ak@suse.de>,
Linux Kernel ML <linux-kernel@vger.kernel.org>,
linux-ia64@vger.kernel.org, linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH: 002/017]Memory hotplug for new nodes v.4.(change name
Date: Fri, 17 Mar 2006 17:12:18 +0000 [thread overview]
Message-ID: <1142615538.10906.67.camel@localhost.localdomain> (raw)
In-Reply-To: <20060317162757.C63B.Y-GOTO@jp.fujitsu.com>
On Fri, 2006-03-17 at 17:20 +0900, Yasunori Goto wrote:
> This patch changes name of old add_memory() to arch_add_memory.
> and use node id to get pgdat for the node at NODE_DATA().
>
> Note: Powerpc's old add_memory() is defined as __devinit. However,
> add_memory() is usually called only after bootup.
> I suppose it may be redundant. But, I'm not sure about powerpc.
> So, I keep it. (But, __meminit is better than __devinit at least.)
My thoughts when originally designing the API were that the architecture
may be the only bit that actually knows where the memory _is_. So, we
shouldn't involve the generic code in figuring this out.
You can see the result of this in the next patch because there is a new
function introduced to hide the arch-specific node lookup. If that was
simply done in the already arch-specific add_memory() function, then you
wouldn't need arch_nid_probe() and its related #ifdefs at all.
-- Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <haveblue@us.ibm.com>
To: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: Andrew Morton <akpm@osdl.org>, "Luck, Tony" <tony.luck@intel.com>,
Andi Kleen <ak@suse.de>,
Linux Kernel ML <linux-kernel@vger.kernel.org>,
linux-ia64@vger.kernel.org, linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH: 002/017]Memory hotplug for new nodes v.4.(change name old add_memory() to arch_add_memory())
Date: Fri, 17 Mar 2006 09:12:18 -0800 [thread overview]
Message-ID: <1142615538.10906.67.camel@localhost.localdomain> (raw)
In-Reply-To: <20060317162757.C63B.Y-GOTO@jp.fujitsu.com>
On Fri, 2006-03-17 at 17:20 +0900, Yasunori Goto wrote:
> This patch changes name of old add_memory() to arch_add_memory.
> and use node id to get pgdat for the node at NODE_DATA().
>
> Note: Powerpc's old add_memory() is defined as __devinit. However,
> add_memory() is usually called only after bootup.
> I suppose it may be redundant. But, I'm not sure about powerpc.
> So, I keep it. (But, __meminit is better than __devinit at least.)
My thoughts when originally designing the API were that the architecture
may be the only bit that actually knows where the memory _is_. So, we
shouldn't involve the generic code in figuring this out.
You can see the result of this in the next patch because there is a new
function introduced to hide the arch-specific node lookup. If that was
simply done in the already arch-specific add_memory() function, then you
wouldn't need arch_nid_probe() and its related #ifdefs at all.
-- Dave
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <haveblue@us.ibm.com>
To: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: Andrew Morton <akpm@osdl.org>, "Luck, Tony" <tony.luck@intel.com>,
Andi Kleen <ak@suse.de>,
Linux Kernel ML <linux-kernel@vger.kernel.org>,
linux-ia64@vger.kernel.org, linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH: 002/017]Memory hotplug for new nodes v.4.(change name old add_memory() to arch_add_memory())
Date: Fri, 17 Mar 2006 09:12:18 -0800 [thread overview]
Message-ID: <1142615538.10906.67.camel@localhost.localdomain> (raw)
In-Reply-To: <20060317162757.C63B.Y-GOTO@jp.fujitsu.com>
On Fri, 2006-03-17 at 17:20 +0900, Yasunori Goto wrote:
> This patch changes name of old add_memory() to arch_add_memory.
> and use node id to get pgdat for the node at NODE_DATA().
>
> Note: Powerpc's old add_memory() is defined as __devinit. However,
> add_memory() is usually called only after bootup.
> I suppose it may be redundant. But, I'm not sure about powerpc.
> So, I keep it. (But, __meminit is better than __devinit at least.)
My thoughts when originally designing the API were that the architecture
may be the only bit that actually knows where the memory _is_. So, we
shouldn't involve the generic code in figuring this out.
You can see the result of this in the next patch because there is a new
function introduced to hide the arch-specific node lookup. If that was
simply done in the already arch-specific add_memory() function, then you
wouldn't need arch_nid_probe() and its related #ifdefs at all.
-- Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-03-17 17:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-17 8:20 [PATCH: 002/017]Memory hotplug for new nodes v.4.(change name old add_memory() to arch_add_memory()) Yasunori Goto
2006-03-17 8:20 ` Yasunori Goto
2006-03-17 8:20 ` Yasunori Goto
2006-03-17 17:12 ` Dave Hansen [this message]
2006-03-17 17:12 ` Dave Hansen
2006-03-17 17:12 ` Dave Hansen
2006-03-18 1:26 ` [PATCH: 002/017]Memory hotplug for new nodes v.4.(change name KAMEZAWA Hiroyuki
2006-03-18 1:26 ` [PATCH: 002/017]Memory hotplug for new nodes v.4.(change name old add_memory() to arch_add_memory()) KAMEZAWA Hiroyuki
2006-03-18 1:26 ` KAMEZAWA Hiroyuki
2006-03-21 18:00 ` [PATCH: 002/017]Memory hotplug for new nodes v.4.(change name Dave Hansen
2006-03-21 18:00 ` [PATCH: 002/017]Memory hotplug for new nodes v.4.(change name old add_memory() to arch_add_memory()) Dave Hansen
2006-03-21 18:00 ` Dave Hansen
2006-03-22 0:05 ` [PATCH: 002/017]Memory hotplug for new nodes v.4.(change name KAMEZAWA Hiroyuki
2006-03-22 0:05 ` [PATCH: 002/017]Memory hotplug for new nodes v.4.(change name old add_memory() to arch_add_memory()) KAMEZAWA Hiroyuki
2006-03-22 0:05 ` KAMEZAWA Hiroyuki
2006-03-22 1:08 ` [PATCH: 002/017]Memory hotplug for new nodes v.4.(change name Dave Hansen
2006-03-22 1:08 ` [PATCH: 002/017]Memory hotplug for new nodes v.4.(change name old add_memory() to arch_add_memory()) Dave Hansen
2006-03-22 1:08 ` Dave Hansen
2006-03-22 1:38 ` [PATCH: 002/017]Memory hotplug for new nodes v.4.(change name KAMEZAWA Hiroyuki
2006-03-22 1:38 ` [PATCH: 002/017]Memory hotplug for new nodes v.4.(change name old add_memory() to arch_add_memory()) KAMEZAWA Hiroyuki
2006-03-22 1:38 ` KAMEZAWA Hiroyuki
2006-03-22 6:06 ` [PATCH: 002/017]Memory hotplug for new nodes v.4.(change name old add_memory() to arch_add_memor Yasunori Goto
2006-03-22 6:06 ` [PATCH: 002/017]Memory hotplug for new nodes v.4.(change name old add_memory() to arch_add_memory()) Yasunori Goto
2006-03-22 6:06 ` Yasunori Goto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1142615538.10906.67.camel@localhost.localdomain \
--to=haveblue@us.ibm.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tony.luck@intel.com \
--cc=y-goto@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.