* p4-clockmod not working in 2.6.16 @ 2006-03-21 20:55 Sasa Ostrouska 2006-03-21 21:01 ` Dave Jones 0 siblings, 1 reply; 17+ messages in thread From: Sasa Ostrouska @ 2006-03-21 20:55 UTC (permalink / raw) To: linux-kernel Hello people, I would like to advise you that in kernel 2.6.16 the p4-clockmod module cant recognise my P4 cpu anymore. This worked perfectly in kernel 2.6.15. I get the following error when I modprobe it: root@rc-vaio:/home/sasa# modprobe msr && modprobe cpuid && modprobe p4_clockmod && modprobe speedstep-lib && modprobe microcode && modprobe hwmon FATAL: Error inserting p4_clockmod (/lib/modules/2.6.16/kernel/arch/i386/kernel/cpu/cpufreq/p4-clockmod.ko): No such device Can somebody explain what happened or how can I set it up ? Many thanks and best regards Sasa Ostrouska ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: p4-clockmod not working in 2.6.16 2006-03-21 20:55 p4-clockmod not working in 2.6.16 Sasa Ostrouska @ 2006-03-21 21:01 ` Dave Jones 2006-03-21 21:57 ` Sasa Ostrouska 0 siblings, 1 reply; 17+ messages in thread From: Dave Jones @ 2006-03-21 21:01 UTC (permalink / raw) To: Sasa Ostrouska; +Cc: linux-kernel On Tue, Mar 21, 2006 at 09:55:28PM +0100, Sasa Ostrouska wrote: > Hello people, > > I would like to advise you that in kernel 2.6.16 the > p4-clockmod module cant recognise my P4 cpu anymore. > > This worked perfectly in kernel 2.6.15. I get the following > error when I modprobe it: > > root@rc-vaio:/home/sasa# modprobe msr && modprobe cpuid && modprobe > p4_clockmod && modprobe speedstep-lib && modprobe microcode && modprobe > hwmon > FATAL: Error inserting p4_clockmod > (/lib/modules/2.6.16/kernel/arch/i386/kernel/cpu/cpufreq/p4-clockmod.ko): No such device > > Can somebody explain what happened or how can I set it up ? Can you send /proc/cpuinfo and dmesg output please ? The only thing that recently changed in p4-clockmod is addition of an errata workaround that disables freqs <2GHz on certain CPUs. If the max freq is <2GHz this would disable it completely. Dave -- http://www.codemonkey.org.uk ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: p4-clockmod not working in 2.6.16 2006-03-21 21:01 ` Dave Jones @ 2006-03-21 21:57 ` Sasa Ostrouska 2006-03-21 21:59 ` Arjan van de Ven 2006-03-21 22:01 ` Dave Jones 0 siblings, 2 replies; 17+ messages in thread From: Sasa Ostrouska @ 2006-03-21 21:57 UTC (permalink / raw) To: Dave Jones; +Cc: linux-kernel On Tue, 2006-03-21 at 16:01 -0500, Dave Jones wrote: > On Tue, Mar 21, 2006 at 09:55:28PM +0100, Sasa Ostrouska wrote: > > Hello people, > > > > I would like to advise you that in kernel 2.6.16 the > > p4-clockmod module cant recognise my P4 cpu anymore. > > > > This worked perfectly in kernel 2.6.15. I get the following > > error when I modprobe it: > > > > root@rc-vaio:/home/sasa# modprobe msr && modprobe cpuid && modprobe > > p4_clockmod && modprobe speedstep-lib && modprobe microcode && modprobe > > hwmon > > FATAL: Error inserting p4_clockmod > > (/lib/modules/2.6.16/kernel/arch/i386/kernel/cpu/cpufreq/p4-clockmod.ko): No such device > > > > Can somebody explain what happened or how can I set it up ? > > Can you send /proc/cpuinfo and dmesg output please ? > The only thing that recently changed in p4-clockmod is addition > of an errata workaround that disables freqs <2GHz on certain CPUs. > > If the max freq is <2GHz this would disable it completely. > > Dave > Hi Dave, here it is, this is on a Sony Vaio PCG-GRT816S laptop: root@rc-vaio:/home/sasa# cat /proc/cpuinfo processor : 0 vendor_id : GenuineIntel cpu family : 15 model : 2 model name : Intel(R) Pentium(R) 4 CPU 2.80GHz stepping : 9 cpu MHz : 2807.083 cache size : 512 KB fdiv_bug : no hlt_bug : no f00f_bug : no coma_bug : no fpu : yes fpu_exception : yes cpuid level : 2 wp : yes flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe cid xtpr bogomips : 5617.52 ============================================================================ root@rc-vaio:/home/sasa# dmesg CPU 2.80GHz stepping 09 Checking 'hlt' instruction... OK. ENABLING IO-APIC IRQs ..TIMER: vector=0x31 apic1=0 pin1=16 apic2=-1 pin2=-1 ..MP-BIOS bug: 8254 timer not connected to IO-APIC ...trying to set up timer (IRQ0) through the 8259A ... failed. ...trying to set up timer as Virtual Wire IRQ... works. NET: Registered protocol family 16 ACPI: bus type pci registered PCI: PCI BIOS revision 2.10 entry at 0xfd996, last bus=1 PCI: Using configuration type 1 ACPI: Subsystem revision 20060127 ACPI: Interpreter enabled ACPI: Using IOAPIC for interrupt routing ACPI: PCI Root Bridge [PCI0] (0000:00) PCI: Probing PCI hardware (bus 00) Uncovering SIS963 that hid as a SIS503 (compatible=1) Enabling SiS 96x SMBus. Boot video device is 0000:01:00.0 ACPI: PCI Interrupt Routing Table [\_SB_.PCI0._PRT] ACPI: PCI Interrupt Link [LNKA] (IRQs 3 4 5 7 9 *10 11) ACPI: PCI Interrupt Link [LNKB] (IRQs 3 4 5 7 9 10 11) *0, disabled. ACPI: PCI Interrupt Link [LNKC] (IRQs 3 4 5 7 9 10 11) *0, disabled. ACPI: PCI Interrupt Link [LNKD] (IRQs 3 4 5 7 9 10 *11) ACPI: PCI Interrupt Link [LNKE] (IRQs 3 4 5 7 *9 10 11) ACPI: PCI Interrupt Link [LNKF] (IRQs 3 4 5 7 9 10 *11) ACPI: PCI Interrupt Link [LNKG] (IRQs 3 4 5 7 9 10 11) *0, disabled. ACPI: PCI Interrupt Link [LNKH] (IRQs 3 4 5 7 9 10 11) *0, disabled. ACPI: PCI Interrupt Routing Table [\_SB_.PCI0.PCI1._PRT] ACPI: Embedded Controller [EC0] (gpe 21) interrupt mode. Linux Plug and Play Support v0.97 (c) Adam Belay pnp: PnP ACPI init pnp: PnP ACPI: found 11 devices PCI: Using ACPI for IRQ routing PCI: If a device doesn't work, try "pci=routeirq". If it helps, post a report pnp: 00:04: ioport range 0x8000-0x808f could not be reserved pnp: 00:04: ioport range 0x8090-0x80ff has been reserved pnp: 00:04: ioport range 0x8100-0x811f has been reserved pnp: 00:04: ioport range 0x4d0-0x4d1 has been reserved pnp: 00:04: ioport range 0xfe00-0xfe00 has been reserved PCI: Failed to allocate mem resource #6:20000@f0000000 for 0000:01:00.0 PCI: Bridge: 0000:00:01.0 IO window: disabled. MEM window: d5000000-d5ffffff PREFETCH window: e0000000-efffffff PCI: Bus 2, cardbus bridge: 0000:00:0a.0 IO window: 00002400-000024ff IO window: 00002800-000028ff PREFETCH window: 50000000-51ffffff MEM window: 52000000-53ffffff PCI: Bus 6, cardbus bridge: 0000:00:0a.1 IO window: 00002c00-00002cff IO window: 00003000-000030ff PREFETCH window: 54000000-55ffffff MEM window: 56000000-57ffffff PCI: Enabling device 0000:00:0a.0 (0000 -> 0003) ACPI: PCI Interrupt 0000:00:0a.0[A] -> GSI 17 (level, low) -> IRQ 16 PCI: Enabling device 0000:00:0a.1 (0000 -> 0003) ACPI: PCI Interrupt 0000:00:0a.1[A] -> GSI 17 (level, low) -> IRQ 16 Machine check exception polling timer started. audit: initializing netlink socket (disabled) audit(1142855513.672:1): initialized Total HugeTLB memory allocated, 0 VFS: Disk quotas dquot_6.5.1 Dquot-cache hash table entries: 1024 (order 0, 4096 bytes) SELinux: Registering netfilter hooks Initializing Cryptographic API io scheduler noop registered io scheduler anticipatory registered (default) io scheduler deadline registered io scheduler cfq registered vesafb: framebuffer at 0xe0000000, mapped to 0xf0880000, using 3750k, total 65536k vesafb: mode is 800x600x32, linelength=3200, pages=1 vesafb: protected mode interface info at c000:f770 vesafb: scrolling: redraw vesafb: Truecolor: size=8:8:8:8, shift=24:16:8:0 Console: switching to colour frame buffer device 100x37 fb0: VESA VGA frame buffer device ACPI: AC Adapter [ACAD] (on-line) ACPI: Battery Slot [BAT1] (battery present) ACPI: Battery Slot [BAT2] (battery absent) PNP: PS/2 Controller [PNP0303:KBC,PNP0f13:MOUE] at 0x60,0x64 irq 1,12 serio: i8042 AUX port at 0x60,0x64 irq 12 serio: i8042 KBD port at 0x60,0x64 irq 1 Serial: 8250/16550 driver $Revision: 1.90 $ 4 ports, IRQ sharing disabled serial8250: ttyS0 at I/O 0x3f8 (irq = 4) is a 16550A 00:08: ttyS0 at I/O 0x3f8 (irq = 4) is a 16550A PCI: Enabling device 0000:00:02.6 (0000 -> 0001) ACPI: PCI Interrupt 0000:00:02.6[C] -> GSI 18 (level, low) -> IRQ 17 ACPI: PCI interrupt for device 0000:00:02.6 disabled Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2 ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx SIS5513: IDE controller at PCI slot 0000:00:02.5 SIS5513: chipset revision 0 SIS5513: not 100% native mode: will probe irqs later SIS5513: SiS 962/963 MuTIOL IDE UDMA133 controller ide0: BM-DMA at 0x1000-0x1007, BIOS settings: hda:DMA, hdb:pio ide1: BM-DMA at 0x1008-0x100f, BIOS settings: hdc:DMA, hdd:pio Probing IDE interface ide0... hda: IC25N080ATMR04-0, ATA DISK drive ide0 at 0x1f0-0x1f7,0x3f6 on irq 14 Probing IDE interface ide1... hdc: PIONEER DVD-RW DVR-K12D, ATAPI CD/DVD-ROM drive ide1 at 0x170-0x177,0x376 on irq 15 hda: max request size: 512KiB hda: 156301488 sectors (80026 MB) w/7884KiB Cache, CHS=16383/255/63, UDMA(100) hda: cache flushes supported hda: hda1 hda2 hda3 hdc: ATAPI 24X DVD-ROM DVD-R CD-R/RW drive, 2000kB Cache, UDMA(33) Uniform CD-ROM driver Revision: 3.20 mice: PS/2 mouse device common for all mice MC: drivers/edac/edac_mc.c version edac_mc Ver: 2.0.0 Mar 20 2006 NET: Registered protocol family 2 IP route cache hash table entries: 32768 (order: 5, 131072 bytes) TCP established hash table entries: 131072 (order: 7, 524288 bytes) TCP bind hash table entries: 65536 (order: 6, 262144 bytes) TCP: Hash tables configured (established 131072 bind 65536) TCP reno registered ip_conntrack version 2.4 (8175 buckets, 65400 max) - 172 bytes per conntrack input: AT Translated Set 2 keyboard as /class/input/input0 TCP bic registered NET: Registered protocol family 1 NET: Registered protocol family 17 Using IPI Shortcut mode ACPI wakeup devices: PWRB COMA EC0 USB0 USB1 USB2 USB3 ACM AUD LAN CB0 CB1 ACPI: (supports S0 S3 S4 S5) BIOS EDD facility v0.16 2004-Jun-25, 1 devices found ReiserFS: hda1: found reiserfs format "3.6" with standard journal ReiserFS: hda1: using ordered data mode ReiserFS: hda1: journal params: device hda1, size 8192, journal first block 18, max trans len 1024, max batch 900, max commit age 30, max trans age 30 ReiserFS: hda1: checking transaction log (hda1) ReiserFS: hda1: Using r5 hash to sort names VFS: Mounted root (reiserfs filesystem) readonly. Freeing unused kernel memory: 148k freed Adding 1839376k swap on /dev/hda3. Priority:-1 extents:1 across:1839376k Linux agpgart interface v0.101 (c) Dave Jones input: PS/2 Generic Mouse as /class/input/input1 ReiserFS: hda2: found reiserfs format "3.6" with standard journal ReiserFS: hda2: using ordered data mode ReiserFS: hda2: journal params: device hda2, size 8192, journal first block 18, max trans len 1024, max batch 900, max commit age 30, max trans age 30 ReiserFS: hda2: checking transaction log (hda2) ReiserFS: hda2: Using r5 hash to sort names ACPI: PCI Interrupt 0000:00:0a.0[A] -> GSI 17 (level, low) -> IRQ 16 Yenta: CardBus bridge found at 0000:00:0a.0 [104d:814e] Yenta: ISA IRQ mask 0x04b8, PCI irq 16 Socket status: 30000006 ACPI: PCI Interrupt 0000:00:0a.1[A] -> GSI 17 (level, low) -> IRQ 16 Yenta: CardBus bridge found at 0000:00:0a.1 [104d:814e] Yenta: ISA IRQ mask 0x04b8, PCI irq 16 Socket status: 30000006 nvidia: module license 'NVIDIA' taints kernel. ACPI: PCI Interrupt 0000:01:00.0[A] -> GSI 16 (level, low) -> IRQ 18 NVRM: loading NVIDIA Linux x86 NVIDIA Kernel Module 1.0-8174 Tue Nov 22 17:48:37 PST 2005 sis900.c: v1.08.09 Sep. 19 2005 ACPI: PCI Interrupt 0000:00:04.0[A] -> GSI 19 (level, low) -> IRQ 19 0000:00:04.0: Realtek RTL8201 PHY transceiver found at address 1. 0000:00:04.0: Using transceiver found at address 1 as default eth0: SiS 900 PCI Fast Ethernet at 0x2000, IRQ 19, 08:00:46:b4:10:b5. usbcore: registered new driver usbfs usbcore: registered new driver hub PCI: Enabling device 0000:00:03.3 (0000 -> 0002) ACPI: PCI Interrupt 0000:00:03.3[D] -> GSI 23 (level, low) -> IRQ 20 ehci_hcd 0000:00:03.3: EHCI Host Controller PCI: cache line size of 128 is not supported by device 0000:00:03.3 ehci_hcd 0000:00:03.3: new USB bus registered, assigned bus number 1 ehci_hcd 0000:00:03.3: irq 20, io mem 0xd4003000 ehci_hcd 0000:00:03.3: USB 2.0 started, EHCI 1.00, driver 10 Dec 2004 usb usb1: configuration #1 chosen from 1 choice hub 1-0:1.0: USB hub found hub 1-0:1.0: 6 ports detected ohci_hcd: 2005 April 22 USB 1.1 'Open' Host Controller (OHCI) Driver (PCI) ACPI: PCI Interrupt 0000:00:03.0[A] -> GSI 20 (level, low) -> IRQ 21 ohci_hcd 0000:00:03.0: OHCI Host Controller ohci_hcd 0000:00:03.0: new USB bus registered, assigned bus number 2 ohci_hcd 0000:00:03.0: irq 21, io mem 0xd4000000 usb usb2: configuration #1 chosen from 1 choice hub 2-0:1.0: USB hub found hub 2-0:1.0: 2 ports detected ACPI: PCI Interrupt 0000:00:03.1[B] -> GSI 21 (level, low) -> IRQ 22 ohci_hcd 0000:00:03.1: OHCI Host Controller ohci_hcd 0000:00:03.1: new USB bus registered, assigned bus number 3 ohci_hcd 0000:00:03.1: irq 22, io mem 0xd4001000 usb usb3: configuration #1 chosen from 1 choice hub 3-0:1.0: USB hub found hub 3-0:1.0: 2 ports detected PCI: Enabling device 0000:00:03.2 (0010 -> 0012) ACPI: PCI Interrupt 0000:00:03.2[C] -> GSI 22 (level, low) -> IRQ 23 ohci_hcd 0000:00:03.2: OHCI Host Controller ohci_hcd 0000:00:03.2: new USB bus registered, assigned bus number 4 ohci_hcd 0000:00:03.2: irq 23, io mem 0xd4002000 usb usb4: configuration #1 chosen from 1 choice hub 4-0:1.0: USB hub found hub 4-0:1.0: 2 ports detected usb 3-2: new low speed USB device using ohci_hcd and address 2 usb 3-2: configuration #1 chosen from 1 choice usb 4-2: new full speed USB device using ohci_hcd and address 2 ACPI: PCI Interrupt 0000:00:02.7[C] -> GSI 18 (level, low) -> IRQ 17 eth0: Media Link On 100mbps full-duplex usb 4-2: configuration #1 chosen from 1 choice intel8x0_measure_ac97_clock: measured 50479 usecs intel8x0: clocking to 48000 SCSI subsystem initialized Initializing USB Mass Storage driver... scsi0 : SCSI emulation for USB Mass Storage devices usb-storage: device found at 2 usb-storage: waiting for device to settle before scanning usbcore: registered new driver usb-storage USB Mass Storage support registered. usbcore: registered new driver hiddev input: Logitech USB Receiver as /class/input/input2 input: USB HID v1.10 Mouse [Logitech USB Receiver] on usb-0000:00:03.1-2 usbcore: registered new driver usbhid drivers/usb/input/hid-core.c: v2.6:USB HID core driver i2c-sis96x version 1.0.0 sis96x_smbus 0000:00:02.1: SiS96x SMBus base address: 0x8100 agpgart: Detected SiS 648 chipset agpgart: AGP aperture is 64M @ 0xd0000000 Vendor: Sony Model: MSC-U03 Rev: 2.00 Type: Direct-Access ANSI SCSI revision: 00 usb-storage: device scan complete sd 0:0:0:0: Attached scsi removable disk sda Real Time Clock Driver v1.12ac input: PC Speaker as /class/input/input3 parport: PnPBIOS parport detected. parport0: PC-style at 0x378 (0x778), irq 7, dma 3 [PCSPP,TRISTATE,COMPAT,ECP,DMA] USB Universal Host Controller Interface driver v2.3 NET: Registered protocol family 10 lo: Disabled Privacy Extensions IPv6 over IPv4 tunneling driver eth0: no IPv6 routers present lp0: using parport0 (interrupt-driven). agpgart: Found an AGP 3.0 compliant device at 0000:00:00.0. agpgart: Putting AGP V3 device at 0000:00:00.0 into 8x mode agpgart: SiS delay workaround: giving bridge time to recover. agpgart: Putting AGP V3 device at 0000:01:00.0 into 8x mode agpgart: Found an AGP 3.0 compliant device at 0000:00:00.0. agpgart: Putting AGP V3 device at 0000:00:00.0 into 8x mode agpgart: SiS delay workaround: giving bridge time to recover. agpgart: Putting AGP V3 device at 0000:01:00.0 into 8x mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode hda: dma_intr: status=0x51 { DriveReady SeekComplete Error } hda: dma_intr: error=0x40 { UncorrectableError }, LBAsect=150802800, high=8, low=16585072, sector=150802800 ide: failed opcode was: unknown end_request: I/O error, dev hda, sector 150802800 ReiserFS: hda2: warning: vs-13070: reiserfs_read_locked_inode: i/o failure occurred trying to find stat data of [5932063 5932077 0x0 SD] process `dig' is using obsolete setsockopt SO_BSDCOMPAT agpgart: Found an AGP 3.0 compliant device at 0000:00:00.0. agpgart: Putting AGP V3 device at 0000:00:00.0 into 8x mode agpgart: SiS delay workaround: giving bridge time to recover. agpgart: Putting AGP V3 device at 0000:01:00.0 into 8x mode agpgart: Found an AGP 3.0 compliant device at 0000:00:00.0. agpgart: Putting AGP V3 device at 0000:00:00.0 into 8x mode agpgart: SiS delay workaround: giving bridge time to recover. agpgart: Putting AGP V3 device at 0000:01:00.0 into 8x mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode CPU0: Temperature above threshold CPU0: Running in modulated clock mode root@rc-vaio:/home/sasa# Thanks, if you need something else please just let me know. Best Regards Sasa Ostrouska ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: p4-clockmod not working in 2.6.16 2006-03-21 21:57 ` Sasa Ostrouska @ 2006-03-21 21:59 ` Arjan van de Ven 2006-03-21 22:52 ` Sasa Ostrouska 2006-03-21 22:01 ` Dave Jones 1 sibling, 1 reply; 17+ messages in thread From: Arjan van de Ven @ 2006-03-21 21:59 UTC (permalink / raw) To: sasa.ostrouska; +Cc: Dave Jones, linux-kernel On Tue, 2006-03-21 at 22:57 +0100, Sasa Ostrouska wrote: > NVRM: loading NVIDIA Linux x86 NVIDIA Kernel Module 1.0-8174 Tue Nov does it happen without this as well ? ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: p4-clockmod not working in 2.6.16 2006-03-21 21:59 ` Arjan van de Ven @ 2006-03-21 22:52 ` Sasa Ostrouska 0 siblings, 0 replies; 17+ messages in thread From: Sasa Ostrouska @ 2006-03-21 22:52 UTC (permalink / raw) To: Arjan van de Ven; +Cc: Dave Jones, linux-kernel On Tue, 2006-03-21 at 22:59 +0100, Arjan van de Ven wrote: > On Tue, 2006-03-21 at 22:57 +0100, Sasa Ostrouska wrote: > > NVRM: loading NVIDIA Linux x86 NVIDIA Kernel Module 1.0-8174 Tue Nov > > does it happen without this as well ? > > Dear Arjan, Also without the nvidia module this was hapening, this was happening from 2.6.16-rc2 iirc. Rgds Sasa ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: p4-clockmod not working in 2.6.16 2006-03-21 21:57 ` Sasa Ostrouska 2006-03-21 21:59 ` Arjan van de Ven @ 2006-03-21 22:01 ` Dave Jones 2006-03-21 22:08 ` Sasa Ostrouska ` (2 more replies) 1 sibling, 3 replies; 17+ messages in thread From: Dave Jones @ 2006-03-21 22:01 UTC (permalink / raw) To: Sasa Ostrouska; +Cc: linux-kernel On Tue, Mar 21, 2006 at 10:57:10PM +0100, Sasa Ostrouska wrote: > Hi Dave, here it is, this is on a Sony Vaio PCG-GRT816S laptop: > CPU0: Temperature above threshold > CPU0: Running in modulated clock mode > .. ad infinitum .. *yowch*. Are you running that CPU fanless or something? Does the patch below help? Dave Fix the code to disable freqs less than 2GHz in N60 errata. Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com> Signed-off-by: Dave Jones <davej@redhat.com> Index: linux-2.6.15/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c =================================================================== --- linux-2.6.15.orig/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c +++ linux-2.6.15/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c @@ -244,7 +244,7 @@ static int cpufreq_p4_cpu_init(struct cp for (i=1; (p4clockmod_table[i].frequency != CPUFREQ_TABLE_END); i++) { if ((i<2) && (has_N44_O17_errata[policy->cpu])) p4clockmod_table[i].frequency = CPUFREQ_ENTRY_INVALID; - else if (has_N60_errata[policy->cpu] && p4clockmod_table[i].frequency < 2000000) + else if (has_N60_errata[policy->cpu] && ((stock_freq * i)/8) < 2000000) p4clockmod_table[i].frequency = CPUFREQ_ENTRY_INVALID; else p4clockmod_table[i].frequency = (stock_freq * i)/8; -- http://www.codemonkey.org.uk ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: p4-clockmod not working in 2.6.16 2006-03-21 22:01 ` Dave Jones @ 2006-03-21 22:08 ` Sasa Ostrouska 2006-03-21 22:13 ` Sasa Ostrouska 2006-03-22 5:57 ` Edgar Toernig 2 siblings, 0 replies; 17+ messages in thread From: Sasa Ostrouska @ 2006-03-21 22:08 UTC (permalink / raw) To: Dave Jones; +Cc: linux-kernel On Tue, 2006-03-21 at 17:01 -0500, Dave Jones wrote: > On Tue, Mar 21, 2006 at 10:57:10PM +0100, Sasa Ostrouska wrote: > > > Hi Dave, here it is, this is on a Sony Vaio PCG-GRT816S laptop: > > CPU0: Temperature above threshold > > CPU0: Running in modulated clock mode > > .. ad infinitum .. > > *yowch*. Are you running that CPU fanless or something? > No, but laptop is on the table :( I get many times this messages, also I'm compilling at the moment. But in any case also with normal use the fan is very active. > Does the patch below help? > > Dave > > > Fix the code to disable freqs less than 2GHz in N60 errata. > > Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com> > Signed-off-by: Dave Jones <davej@redhat.com> > > Index: linux-2.6.15/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c > =================================================================== > --- linux-2.6.15.orig/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c > +++ linux-2.6.15/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c > @@ -244,7 +244,7 @@ static int cpufreq_p4_cpu_init(struct cp > for (i=1; (p4clockmod_table[i].frequency != CPUFREQ_TABLE_END); i++) { > if ((i<2) && (has_N44_O17_errata[policy->cpu])) > p4clockmod_table[i].frequency = CPUFREQ_ENTRY_INVALID; > - else if (has_N60_errata[policy->cpu] && p4clockmod_table[i].frequency < 2000000) > + else if (has_N60_errata[policy->cpu] && ((stock_freq * i)/8) < 2000000) > p4clockmod_table[i].frequency = CPUFREQ_ENTRY_INVALID; > else > p4clockmod_table[i].frequency = (stock_freq * i)/8; > Let me try the patch and I will report. Many thanks and best regards Sasa Ostrouska ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: p4-clockmod not working in 2.6.16 2006-03-21 22:01 ` Dave Jones 2006-03-21 22:08 ` Sasa Ostrouska @ 2006-03-21 22:13 ` Sasa Ostrouska 2006-03-21 22:20 ` Dave Jones 2006-03-22 5:57 ` Edgar Toernig 2 siblings, 1 reply; 17+ messages in thread From: Sasa Ostrouska @ 2006-03-21 22:13 UTC (permalink / raw) To: Dave Jones; +Cc: linux-kernel On Tue, 2006-03-21 at 17:01 -0500, Dave Jones wrote: > On Tue, Mar 21, 2006 at 10:57:10PM +0100, Sasa Ostrouska wrote: > > > Hi Dave, here it is, this is on a Sony Vaio PCG-GRT816S laptop: > > CPU0: Temperature above threshold > > CPU0: Running in modulated clock mode > > .. ad infinitum .. > > *yowch*. Are you running that CPU fanless or something? > > Does the patch below help? > > Dave > > > Fix the code to disable freqs less than 2GHz in N60 errata. > > Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com> > Signed-off-by: Dave Jones <davej@redhat.com> > > Index: linux-2.6.15/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c > =================================================================== > --- linux-2.6.15.orig/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c > +++ linux-2.6.15/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c > @@ -244,7 +244,7 @@ static int cpufreq_p4_cpu_init(struct cp > for (i=1; (p4clockmod_table[i].frequency != CPUFREQ_TABLE_END); i++) { > if ((i<2) && (has_N44_O17_errata[policy->cpu])) > p4clockmod_table[i].frequency = CPUFREQ_ENTRY_INVALID; > - else if (has_N60_errata[policy->cpu] && p4clockmod_table[i].frequency < 2000000) > + else if (has_N60_errata[policy->cpu] && ((stock_freq * i)/8) < 2000000) > p4clockmod_table[i].frequency = CPUFREQ_ENTRY_INVALID; > else > p4clockmod_table[i].frequency = (stock_freq * i)/8; > Patch failed :( root@rc-vaio:/usr/src/linux-2.6.16# patch -p1 < ../linux-2.6.16-p4-clockmod.diff patching file arch/i386/kernel/cpu/cpufreq/p4-clockmod.c Hunk #1 FAILED at 244. 1 out of 1 hunk FAILED -- saving rejects to file arch/i386/kernel/cpu/cpufreq/p4-clockmod.c.rej root@rc-vaio:/usr/src/linux-2.6.16# rgds Sasa ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: p4-clockmod not working in 2.6.16 2006-03-21 22:13 ` Sasa Ostrouska @ 2006-03-21 22:20 ` Dave Jones 2006-03-21 22:51 ` Sasa Ostrouska 0 siblings, 1 reply; 17+ messages in thread From: Dave Jones @ 2006-03-21 22:20 UTC (permalink / raw) To: Sasa Ostrouska; +Cc: linux-kernel On Tue, Mar 21, 2006 at 11:13:45PM +0100, Sasa Ostrouska wrote: > Patch failed :( > > root@rc-vaio:/usr/src/linux-2.6.16# patch -p1 < ../linux-2.6.16-p4-clockmod.diff > patching file arch/i386/kernel/cpu/cpufreq/p4-clockmod.c > Hunk #1 FAILED at 244. > 1 out of 1 hunk FAILED -- saving rejects to file arch/i386/kernel/cpu/cpufreq/p4-clockmod.c.rej > root@rc-vaio:/usr/src/linux-2.6.16# Something isn't right with your tree. Are you sure that's a 2.6.16 ? (17:19:17:davej@linux-2.6.16)$ patch -p1 --dry-run < ~/cf patching file arch/i386/kernel/cpu/cpufreq/p4-clockmod.c (17:19:24:davej@linux-2.6.16)$ Dave -- http://www.codemonkey.org.uk ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: p4-clockmod not working in 2.6.16 2006-03-21 22:20 ` Dave Jones @ 2006-03-21 22:51 ` Sasa Ostrouska 0 siblings, 0 replies; 17+ messages in thread From: Sasa Ostrouska @ 2006-03-21 22:51 UTC (permalink / raw) To: Dave Jones; +Cc: linux-kernel On Tue, 2006-03-21 at 17:20 -0500, Dave Jones wrote: > On Tue, Mar 21, 2006 at 11:13:45PM +0100, Sasa Ostrouska wrote: > > > Patch failed :( > > > > root@rc-vaio:/usr/src/linux-2.6.16# patch -p1 < ../linux-2.6.16-p4-clockmod.diff > > patching file arch/i386/kernel/cpu/cpufreq/p4-clockmod.c > > Hunk #1 FAILED at 244. > > 1 out of 1 hunk FAILED -- saving rejects to file arch/i386/kernel/cpu/cpufreq/p4-clockmod.c.rej > > root@rc-vaio:/usr/src/linux-2.6.16# > > Something isn't right with your tree. Are you sure that's a 2.6.16 ? > > (17:19:17:davej@linux-2.6.16)$ patch -p1 --dry-run < ~/cf > patching file arch/i386/kernel/cpu/cpufreq/p4-clockmod.c > (17:19:24:davej@linux-2.6.16)$ > > Dave > Sure if the incremental patches are right then this is it. In any case the patch has not applied but changing that line as per your patch, I got it working. Now, it loads and it seems that it works. I looked at my CPU frequency scaling applet in GNOME and it shows only frequencies from 2,8GHz to 2,1GHz. I dont remember it well but if I'm not wrong earlier it was showing frequencies until 600MHz. Is this possible ? Thanks & Rgds Sasa ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: p4-clockmod not working in 2.6.16 2006-03-21 22:01 ` Dave Jones 2006-03-21 22:08 ` Sasa Ostrouska 2006-03-21 22:13 ` Sasa Ostrouska @ 2006-03-22 5:57 ` Edgar Toernig 2006-03-22 6:20 ` Mike Galbraith 2 siblings, 1 reply; 17+ messages in thread From: Edgar Toernig @ 2006-03-22 5:57 UTC (permalink / raw) To: Dave Jones; +Cc: linux-kernel Dave Jones wrote: > > Fix the code to disable freqs less than 2GHz in N60 errata. > > - else if (has_N60_errata[policy->cpu] && p4clockmod_table[i].frequency < 2000000) > + else if (has_N60_errata[policy->cpu] && ((stock_freq * i)/8) < 2000000) Doesn't change anything here - I still get _all_ frequencies where I think I shouldn't: | processor : 0 | vendor_id : GenuineIntel | cpu family : 15 | model : 2 | model name : Intel(R) Pentium(R) 4 CPU 3.00GHz | stepping : 9 | cpu MHz : 3000.000 [same for cpu 1, it's a single P4 with HT] Looks like the f29 cpu that should have the errata. | > cat /sys/devices/system/cpu/cpu1/cpufreq/scaling_available_frequencies | 375000 750000 1125000 1500000 1875000 2250000 2625000 3000000 | > dmesg|fgrep clockmod | p4-clockmod: P4/Xeon(TM) CPU On-Demand Clock Modulation available Further: the directory cpufreq in /sys is there only for cpu1 - not for cpu0: | > ls /sys/devices/system/cpu/cpu? | /sys/devices/system/cpu/cpu0: | topology | | /sys/devices/system/cpu/cpu1: | cpufreq topology And at last: reading Intel's errata it should be good enough to not go below 25% instead limiting all below 2GHz. I'm not even sure whether the 2GHz mentioned there is the reduced or the nominal clock. Running 2GHz on 12.5% would be a really fast CPU. | N60. Processor May Hang under Certain Frequencies and 12.5% | STPCLK# Duty Cycle | | Problem: If a system de-asserts STPCLK# at a 12.5% duty cycle, the | processor is running below 2 GHz, and the processor thermal | control circuit (TCC) on-demand clock modulation is active, | the processor may hang. This erratum does not occur under | the automatic mode of the TCC. | | Implication: When this erratum occurs, the processor will hang. | | Workaround: If use of the on-demand mode of the processor's TCC is desired | in conjunction with STPCLK# modulation, then assure that STPCLK# | is not asserted at a 12.5% duty cycle. Ciao, ET. ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: p4-clockmod not working in 2.6.16 2006-03-22 5:57 ` Edgar Toernig @ 2006-03-22 6:20 ` Mike Galbraith [not found] ` <1144147663.2588.247.camel@elsdt-scarecrow.arc.com> 0 siblings, 1 reply; 17+ messages in thread From: Mike Galbraith @ 2006-03-22 6:20 UTC (permalink / raw) To: Edgar Toernig; +Cc: Dave Jones, linux-kernel On Wed, 2006-03-22 at 06:57 +0100, Edgar Toernig wrote: > And at last: reading Intel's errata it should be good enough to not go > below 25% instead limiting all below 2GHz. I'm not even sure whether > the 2GHz mentioned there is the reduced or the nominal clock. Running > 2GHz on 12.5% would be a really fast CPU. > > | N60. Processor May Hang under Certain Frequencies and 12.5% > | STPCLK# Duty Cycle > | > | Problem: If a system de-asserts STPCLK# at a 12.5% duty cycle, the > | processor is running below 2 GHz, and the processor thermal > | control circuit (TCC) on-demand clock modulation is active, > | the processor may hang. This erratum does not occur under > | the automatic mode of the TCC. > | > | Implication: When this erratum occurs, the processor will hang. > | > | Workaround: If use of the on-demand mode of the processor's TCC is desired > | in conjunction with STPCLK# modulation, then assure that STPCLK# > | is not asserted at a 12.5% duty cycle. Yeah, I read that too, and it looked to me like someone might have used a bit too mich blunt force. (not sure though) I disabled it so I could save a tree or two, and it seems to work fine. Of course, if it does ever have a seizure, I don't get to gripe ;-) -Mike ^ permalink raw reply [flat|nested] 17+ messages in thread
[parent not found: <1144147663.2588.247.camel@elsdt-scarecrow.arc.com>]
* Re: p4-clockmod not working in 2.6.16 [not found] ` <1144147663.2588.247.camel@elsdt-scarecrow.arc.com> @ 2006-04-05 12:02 ` Tim Phipps [not found] ` <1144245205.7571.11.camel@homer> 0 siblings, 1 reply; 17+ messages in thread From: Tim Phipps @ 2006-04-05 12:02 UTC (permalink / raw) To: Tim Phipps, linux-kernel; +Cc: Mike Galbraith, Edgar Toernig, Dave Jones [-- Attachment #1: Type: text/plain, Size: 887 bytes --] On Tuesday 04 Apr 2006 11:47, Tim Phipps wrote: > On Wed, 2006-03-22 at 06:20, Mike Galbraith wrote: > > On Wed, 2006-03-22 at 06:57 +0100, Edgar Toernig wrote: > > > | N60. Processor May Hang under Certain Frequencies and 12.5% > > > | STPCLK# Duty Cycle > > > | > > > | Problem: If a system de-asserts STPCLK# at a 12.5% duty cycle, > > > | the processor is running below 2 GHz, and the processor thermal > > > | control circuit (TCC) on-demand clock modulation is active, the > > > | processor may hang. This erratum does not occur under the automatic > > > | mode of the TCC. > Here's a patch to 2.6.17-rc1 that disables the 12.5% DC on any CPU that has N60. The frequencies in the errata are a bit vague so this is the safe bet and it only disables one of the eight frequencies rather than the current behaviour which disables all of mine! Cheers, Tim. [-- Attachment #2: kpatch-p4clockmod --] [-- Type: text/x-diff, Size: 658 bytes --] --- linux-2.6.17-rc1/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c.orig 2006-04-04 14:54:49.000000000 +0100 +++ linux-2.6.17-rc1/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c 2006-04-04 15:19:02.000000000 +0100 @@ -244,7 +244,7 @@ for (i=1; (p4clockmod_table[i].frequency != CPUFREQ_TABLE_END); i++) { if ((i<2) && (has_N44_O17_errata[policy->cpu])) p4clockmod_table[i].frequency = CPUFREQ_ENTRY_INVALID; - else if (has_N60_errata[policy->cpu] && ((stock_freq * i)/8) < 2000000) + else if ((i<2) && (has_N60_errata[policy->cpu])) p4clockmod_table[i].frequency = CPUFREQ_ENTRY_INVALID; else p4clockmod_table[i].frequency = (stock_freq * i)/8; ^ permalink raw reply [flat|nested] 17+ messages in thread
[parent not found: <1144245205.7571.11.camel@homer>]
* Re: p4-clockmod not working in 2.6.16 [not found] ` <1144245205.7571.11.camel@homer> @ 2006-04-05 13:59 ` Mike Galbraith 2006-04-13 12:20 ` Tim Phipps 0 siblings, 1 reply; 17+ messages in thread From: Mike Galbraith @ 2006-04-05 13:59 UTC (permalink / raw) To: Tim Phipps; +Cc: linux-kernel, Edgar Toernig, Dave Jones On Wed, 2006-04-05 at 13:02 +0100, Tim Phipps wrote: > On Tuesday 04 Apr 2006 11:47, Tim Phipps wrote: > > On Wed, 2006-03-22 at 06:20, Mike Galbraith wrote: > > > On Wed, 2006-03-22 at 06:57 +0100, Edgar Toernig wrote: > > > > | N60. Processor May Hang under Certain Frequencies and 12.5% > > > > | STPCLK# Duty Cycle > > > > | > > > > | Problem: If a system de-asserts STPCLK# at a 12.5% duty cycle, > > > > | the processor is running below 2 GHz, and the processor thermal > > > > | control circuit (TCC) on-demand clock modulation is active, the > > > > | processor may hang. This erratum does not occur under the automatic > > > > | mode of the TCC. > > > Here's a patch to 2.6.17-rc1 that disables the 12.5% DC on any CPU that has > N60. The frequencies in the errata are a bit vague so this is the safe bet > and it only disables one of the eight frequencies rather than the current > behaviour which disables all of mine! Works for me. Perhaps you should update... dprintk("has errata -- disabling frequencies lower than 2ghz\n"); ...,slap a Signed-off-by: on it and see if it flys. -Mike P.S. server can't find computer.systems.pipex.net: NXDOMAIN ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: p4-clockmod not working in 2.6.16 2006-04-05 13:59 ` Mike Galbraith @ 2006-04-13 12:20 ` Tim Phipps 2006-04-13 12:42 ` Jesper Juhl 0 siblings, 1 reply; 17+ messages in thread From: Tim Phipps @ 2006-04-13 12:20 UTC (permalink / raw) To: Mike Galbraith; +Cc: linux-kernel, Edgar Toernig, Dave Jones [-- Attachment #1: Type: text/plain, Size: 616 bytes --] On Wednesday 05 Apr 2006 14:59, Mike Galbraith wrote: > On Wed, 2006-04-05 at 13:02 +0100, Tim Phipps wrote: > > Here's a patch to 2.6.17-rc1 that disables the 12.5% DC on any CPU that > > has N60. The frequencies in the errata are a bit vague so this is the > > safe bet and it only disables one of the eight frequencies rather than > > the current behaviour which disables all of mine! > > Works for me. Perhaps you should update... > dprintk("has errata -- disabling frequencies lower than 2ghz\n"); > ...,slap a Signed-off-by: on it and see if it flys. Not sure how to do a Signed-off-by but here's the patch. [-- Attachment #2: kpatch-p4clockmod --] [-- Type: text/plain, Size: 1043 bytes --] --- linux-2.6.17-rc1/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c.orig 2006-04-10 17:12:23.000000000 +0100 +++ linux-2.6.17-rc1/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c 2006-04-10 17:23:44.000000000 +0100 @@ -17,6 +17,7 @@ * * Date Errata Description * 20020525 N44, O17 12.5% or 25% DC causes lockup + * 20060410 N60 12.5% DC causes lockup * */ @@ -231,7 +232,7 @@ case 0x0f29: has_N60_errata[policy->cpu] = 1; - dprintk("has errata -- disabling frequencies lower than 2GHz\n"); + dprintk("has errata -- disabling 12.5%% duty cycle\n"); break; } @@ -244,7 +245,7 @@ for (i=1; (p4clockmod_table[i].frequency != CPUFREQ_TABLE_END); i++) { if ((i<2) && (has_N44_O17_errata[policy->cpu])) p4clockmod_table[i].frequency = CPUFREQ_ENTRY_INVALID; - else if (has_N60_errata[policy->cpu] && ((stock_freq * i)/8) < 2000000) + else if ((i<2) && has_N60_errata[policy->cpu]) p4clockmod_table[i].frequency = CPUFREQ_ENTRY_INVALID; else p4clockmod_table[i].frequency = (stock_freq * i)/8; ^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: p4-clockmod not working in 2.6.16 2006-04-13 12:20 ` Tim Phipps @ 2006-04-13 12:42 ` Jesper Juhl 2006-04-13 13:59 ` [PATCH 001/001] cpufreq: p4_clockmod errata N60 handling is over zealous Tim Phipps 0 siblings, 1 reply; 17+ messages in thread From: Jesper Juhl @ 2006-04-13 12:42 UTC (permalink / raw) To: Tim Phipps; +Cc: Mike Galbraith, linux-kernel, Edgar Toernig, Dave Jones On 4/13/06, Tim Phipps <tim@phipps-hutton.freeserve.co.uk> wrote: > On Wednesday 05 Apr 2006 14:59, Mike Galbraith wrote: > > On Wed, 2006-04-05 at 13:02 +0100, Tim Phipps wrote: > > > Here's a patch to 2.6.17-rc1 that disables the 12.5% DC on any CPU that > > > has N60. The frequencies in the errata are a bit vague so this is the > > > safe bet and it only disables one of the eight frequencies rather than > > > the current behaviour which disables all of mine! > > > > Works for me. Perhaps you should update... > > dprintk("has errata -- disabling frequencies lower than 2ghz\n"); > > ...,slap a Signed-off-by: on it and see if it flys. > > Not sure how to do a Signed-off-by but here's the patch. > It's simple. Here's what you do : 1. Read Documentation/SubmittingPatches, especially the "Developer's Certificate of Origin 1.1" bit. 2. Make sure you agree/comply with above mentioned Developer's cert., then add a line like this just above your patch: Signed-off-by: Tim Phipps <tim@phipps-hutton.freeserve.co.uk> (ohh and please submit patches inline in emails if at all possible, not as attachments, thanks) :-) -- Jesper Juhl <jesper.juhl@gmail.com> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html ^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 001/001] cpufreq: p4_clockmod errata N60 handling is over zealous 2006-04-13 12:42 ` Jesper Juhl @ 2006-04-13 13:59 ` Tim Phipps 0 siblings, 0 replies; 17+ messages in thread From: Tim Phipps @ 2006-04-13 13:59 UTC (permalink / raw) To: Linus Torvalds Cc: Jesper Juhl, Mike Galbraith, linux-kernel, Edgar Toernig, Dave Jones From: Tim Phipps <tim@phipps-hutton.freeserve.co.uk> > > On Wednesday 05 Apr 2006 14:59, Mike Galbraith wrote: > > > On Wed, 2006-04-05 at 13:02 +0100, Tim Phipps wrote: > > > > Here's a patch to 2.6.17-rc1 that disables the 12.5% DC on any CPU > > > > that has N60. The frequencies in the errata are a bit vague so this > > > > is the safe bet and it only disables one of the eight frequencies > > > > rather than the current behaviour which disables all of mine! > > > > > > Works for me. Perhaps you should update... > > > dprintk("has errata -- disabling frequencies lower than 2ghz\n"); > > > ...,slap a Signed-off-by: on it and see if it flys. Signed-off-by: Tim Phipps <tim@phipps-hutton.freeserve.co.uk> --- --- linux-2.6.17-rc1/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c.orig 2006-04-10 17:12:23.000000000 +0100 +++ linux-2.6.17-rc1/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c 2006-04-10 17:23:44.000000000 +0100 @@ -17,6 +17,7 @@ * * Date Errata Description * 20020525 N44, O17 12.5% or 25% DC causes lockup + * 20060410 N60 12.5% DC causes lockup * */ @@ -231,7 +232,7 @@ static int cpufreq_p4_cpu_init(struct cp case 0x0f29: has_N60_errata[policy->cpu] = 1; - dprintk("has errata -- disabling frequencies lower than 2GHz\n"); + dprintk("has errata -- disabling 12.5%% duty cycle\n"); break; } @@ -244,7 +245,7 @@ static int cpufreq_p4_cpu_init(struct cp for (i=1; (p4clockmod_table[i].frequency != CPUFREQ_TABLE_END); i++) { if ((i<2) && (has_N44_O17_errata[policy->cpu])) p4clockmod_table[i].frequency = CPUFREQ_ENTRY_INVALID; - else if (has_N60_errata[policy->cpu] && ((stock_freq * i)/8) < 2000000) + else if ((i<2) && has_N60_errata[policy->cpu]) p4clockmod_table[i].frequency = CPUFREQ_ENTRY_INVALID; else p4clockmod_table[i].frequency = (stock_freq * i)/8; ^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2006-04-13 13:59 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-21 20:55 p4-clockmod not working in 2.6.16 Sasa Ostrouska
2006-03-21 21:01 ` Dave Jones
2006-03-21 21:57 ` Sasa Ostrouska
2006-03-21 21:59 ` Arjan van de Ven
2006-03-21 22:52 ` Sasa Ostrouska
2006-03-21 22:01 ` Dave Jones
2006-03-21 22:08 ` Sasa Ostrouska
2006-03-21 22:13 ` Sasa Ostrouska
2006-03-21 22:20 ` Dave Jones
2006-03-21 22:51 ` Sasa Ostrouska
2006-03-22 5:57 ` Edgar Toernig
2006-03-22 6:20 ` Mike Galbraith
[not found] ` <1144147663.2588.247.camel@elsdt-scarecrow.arc.com>
2006-04-05 12:02 ` Tim Phipps
[not found] ` <1144245205.7571.11.camel@homer>
2006-04-05 13:59 ` Mike Galbraith
2006-04-13 12:20 ` Tim Phipps
2006-04-13 12:42 ` Jesper Juhl
2006-04-13 13:59 ` [PATCH 001/001] cpufreq: p4_clockmod errata N60 handling is over zealous Tim Phipps
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.