Re: [KJ][Patch] fix kbuild warning in sisfb.o

["Darren Jenkins\\" <darrenrjenkins@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1229 bytes --]

Sam

I don't know weather you are aware of this one yet, but we have just
found an issue where 'struct pci_device_id' should be marked
__devinitdata (see Documentation/pci.txt) as the pci code apparently
only uses it in the driver initialisation, but the 'struct pci_driver'
will still hold a pointer to it, giving a kbuild warning. See below.
This definitely looks like a false positive that should be removed.

Darren Jenkins


On Fri, 2006-03-31 at 09:00 -0800, Greg KH wrote:
> On Sat, Apr 01, 2006 at 12:11:18AM +1100, Darren Jenkins" wrote:
> > G'day list
> > 
> > This one was a lot harder to find, but much easier to fix.
> > 
> > WARNING: drivers/video/sis/sisfb.o - Section mismatch: reference
> > to .init.data: from .data between 'sisfb_driver' (at offset 0xf8) and
> > 'sisfb_ops'
> > 
> > 
> > This is caused by the 'pci_driver struct' in sis_main.c having a pointer
> > to a 'pci_device_id struct' in 'sis_main.h' that is marked as
> > __devinitdata.
> > 
> > The patch below just removes the __devinitdata annotation from the
> > 'pci_device_id struct', which seems like the best solution here.
> 
> No, this should be just fine.  devinitdata should be just fine for PCI
> device ids.
> 
> thanks,
> 
> greg k-h


[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors