From: Greg KH <greg@kroah.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ][Patch] fix kbuild warning in sisfb.o
Date: Fri, 31 Mar 2006 17:00:01 +0000 [thread overview]
Message-ID: <20060331170001.GA26432@kroah.com> (raw)
In-Reply-To: <1143810678.7834.13.camel@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 702 bytes --]
On Sat, Apr 01, 2006 at 12:11:18AM +1100, Darren Jenkins" wrote:
> G'day list
>
> This one was a lot harder to find, but much easier to fix.
>
> WARNING: drivers/video/sis/sisfb.o - Section mismatch: reference
> to .init.data: from .data between 'sisfb_driver' (at offset 0xf8) and
> 'sisfb_ops'
>
>
> This is caused by the 'pci_driver struct' in sis_main.c having a pointer
> to a 'pci_device_id struct' in 'sis_main.h' that is marked as
> __devinitdata.
>
> The patch below just removes the __devinitdata annotation from the
> 'pci_device_id struct', which seems like the best solution here.
No, this should be just fine. devinitdata should be just fine for PCI
device ids.
thanks,
greg k-h
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2006-03-31 17:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-31 13:11 [KJ][Patch] fix kbuild warning in sisfb.o Darren Jenkins\
2006-03-31 13:29 ` Adrian Bunk
2006-03-31 13:55 ` Matthew Wilcox
2006-03-31 13:55 ` Matthew Wilcox
2006-03-31 17:00 ` Greg KH [this message]
2006-04-01 2:12 ` Darren Jenkins\
2006-04-01 7:38 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060331170001.GA26432@kroah.com \
--to=greg@kroah.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.