Re: [Patch] Overrun in sound/pci/au88x0/au88x0_pcm.c

[Lee Revell <rlrevell@joe-job.com>]

Please send all ALSA bug fixes to alsa-devel (cc'ed)

On Mon, 2006-04-10 at 12:13 +0200, Eric Sesterhenn wrote:
> hi,
> 
> since idx is used as an index for vortex_pcm_prettyname[VORTEX_PCM_LAST],
> it should not be equal to VORTEX_PCM_LAST. This fixes coverity bug id #572
> 
> Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
> 
> --- linux-2.6.17-rc1/sound/pci/au88x0/au88x0_pcm.c.orig	2006-04-10 12:10:22.000000000 +0200
> +++ linux-2.6.17-rc1/sound/pci/au88x0/au88x0_pcm.c	2006-04-10 12:10:41.000000000 +0200
> @@ -506,7 +506,7 @@ static int __devinit snd_vortex_new_pcm(
>  	int i;
>  	int err, nr_capt;
>  
> -	if ((chip == 0) || (idx < 0) || (idx > VORTEX_PCM_LAST))
> +	if ((chip == 0) || (idx < 0) || (idx >= VORTEX_PCM_LAST))
>  		return -ENODEV;
>  
>  	/* idx indicates which kind of PCM device. ADB, SPDIF, I2S and A3D share the 
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 



-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642