From: Adrian McMenamin <adrian@mcmen.demon.co.uk>
To: Takashi Iwai <tiwai@suse.de>
Cc: Alsa-devel <alsa-devel@lists.sourceforge.net>,
linux-sh <linuxsh-dev@lists.sourceforge.net>,
Paul Mundt <lethal@linux-sh.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Alsa-devel] Re: Patch for AICA sound support on SEGA Dreamcast
Date: Sat, 15 Apr 2006 20:34:07 +0100 [thread overview]
Message-ID: <1145129647.9504.3.camel@localhost.localdomain> (raw)
In-Reply-To: <s5hvetqac7i.wl%tiwai@suse.de>
On Mon, 2006-04-03 at 17:52 +0200, Takashi Iwai wrote:
> > +static void __exit aica_exit(void)
> > +{
> > +
> > + if (likely(dreamcastcard->card)) {
>
> You don't need such an optimization in this place at all.
>
> > + snd_aicapcm_free(dreamcastcard);
> > + snd_card_free(dreamcastcard->card);
> > + kfree(dreamcastcard);
> > + if (likely(pd)) {
> > + struct device_driver *drv = (&pd->dev)->driver;
> > + device_release_driver(&pd->dev);
> > + driver_unregister(drv);
> > + platform_device_unregister(pd);
> > + }
>
> This should be in remove callback.
>
What is the remove callback?
prev parent reply other threads:[~2006-04-15 19:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-03 14:45 Patch for AICA sound support on SEGA Dreamcast Adrian McMenamin
2006-04-03 15:52 ` Takashi Iwai
2006-04-03 17:48 ` Adrian McMenamin
2006-04-03 18:29 ` Takashi Iwai
2006-04-03 22:36 ` [Alsa-devel] " Adrian McMenamin
2006-04-03 22:36 ` Adrian McMenamin
2006-04-03 18:00 ` Carlos Munoz
2006-04-03 18:32 ` Takashi Iwai
2006-04-04 0:16 ` Alistair John Strachan
2006-04-04 0:36 ` [Alsa-devel] " Lee Revell
2006-04-04 7:12 ` Adrian McMenamin
2006-04-04 13:57 ` [Alsa-devel] " Lee Revell
2006-04-04 21:17 ` Adrian McMenamin
2006-04-04 21:23 ` Lee Revell
2006-04-15 19:34 ` Adrian McMenamin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1145129647.9504.3.camel@localhost.localdomain \
--to=adrian@mcmen.demon.co.uk \
--cc=alsa-devel@lists.sourceforge.net \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxsh-dev@lists.sourceforge.net \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.