Re: Re: Patch for AICA sound support on SEGA Dreamcast

[Adrian McMenamin <adrian@mcmen.demon.co.uk>]

On Mon, 2006-04-03 at 20:36 -0400, Lee Revell wrote:
> On Tue, 2006-04-04 at 01:16 +0100, Alistair John Strachan wrote:
> > I think this write-up provides justification. However, it is not part
> > of linux/Documentation/CodingStyle. Perhaps somebody should add these
> > details to this file, so that new code follows this currently
> > 'unwritten' rule. 
> 
> Well, if you look at the current ALSA code, the only typedefs provided
> are for backwards compatibility.  They were all removed from the drivers
> months ago.  The problem is that you were working against old code.  The
> main coding style rule is to follow the conventions of the nearby code,
> which would mean no typedefs in the ALSA driver case.
> 


Well, the typedefs are going - look in my personal CVS
(http://newgolddream.dyndns.info/cgi-bin/cvsweb ) and you'll see that
most are now gone.

I wrote the code, however, against the 2.6.15 kernel, not an
unreasonable proposition given that it was the current kernel until
about 2 weeks ago.





-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642