All of lore.kernel.org
 help / color / mirror / Atom feed
* ALSA regression: oops on shutdown
@ 2006-04-23 23:57 Alexey Dobriyan
  2006-04-24  1:57   ` Andrew Morton
  0 siblings, 1 reply; 23+ messages in thread
From: Alexey Dobriyan @ 2006-04-23 23:57 UTC (permalink / raw)
  To: linux-kernel; +Cc: Jaroslav Kysela, alsa-devel

ALSA oops I reported against 2.6.16-rc1-mm4 [1] sneaked into mainline
after release.
----------------------------
EIP is at remove_proc_entry
Process rmmod

snd_info_unregister             [snd]
snd_pcm_oss_proc_done           [snd_pcm_oss]
snd_pcm_oss_unregister_minor    [snd_pcm_oss]
snd_pcm_notify                  [snd_pcm]
sys_delete_module
do_munmap
syscall_call
----------------------------
Fine-grained bisecting points to commit 21a3479a0b606d36fe24093f70a1c27328cec286

    [ALSA] PCM midlevel & PCM OSS - make procfs & OSS plugin code optional

.config is

	CONFIG_SOUND=m
	CONFIG_SND=m
	CONFIG_SND_TIMER=m
	CONFIG_SND_PCM=m
	CONFIG_SND_OSSEMUL=y
	CONFIG_SND_MIXER_OSS=m
	CONFIG_SND_PCM_OSS=m
	CONFIG_SND_AC97_CODEC=m
	CONFIG_SND_AC97_BUS=m
	CONFIG_SND_INTEL8X0=m

[1] google-groups "2.6.16-rc1-mm4: ALSA oops at remove_proc_entry"

[2] cat ~/bin/google-groups
#!/bin/sh

case "$#" in
0)
	$BROWSER http://groups.google.com/advanced_search
	;;
1)
	$BROWSER http://groups.google.com/groups?as_q="$1"
	;;
esac


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: ALSA regression: oops on shutdown
  2006-04-23 23:57 ALSA regression: oops on shutdown Alexey Dobriyan
@ 2006-04-24  1:57   ` Andrew Morton
  0 siblings, 0 replies; 23+ messages in thread
From: Andrew Morton @ 2006-04-24  1:57 UTC (permalink / raw)
  To: Alexey Dobriyan; +Cc: linux-kernel, perex, alsa-devel

Alexey Dobriyan <adobriyan@gmail.com> wrote:
>
> ALSA oops I reported against 2.6.16-rc1-mm4 [1] sneaked into mainline
>  after release.

One wonders why the ALSA developers merged up which was known to cause
oopses.


>  ----------------------------
>  EIP is at remove_proc_entry
>  Process rmmod
> 
>  snd_info_unregister             [snd]
>  snd_pcm_oss_proc_done           [snd_pcm_oss]
>  snd_pcm_oss_unregister_minor    [snd_pcm_oss]
>  snd_pcm_notify                  [snd_pcm]
>  sys_delete_module
>  do_munmap
>  syscall_call
>  ----------------------------
>  Fine-grained bisecting points to commit 21a3479a0b606d36fe24093f70a1c27328cec286
> 
>      [ALSA] PCM midlevel & PCM OSS - make procfs & OSS plugin code optional
> 
>  .config is
> 
>  	CONFIG_SOUND=m
>  	CONFIG_SND=m
>  	CONFIG_SND_TIMER=m
>  	CONFIG_SND_PCM=m
>  	CONFIG_SND_OSSEMUL=y
>  	CONFIG_SND_MIXER_OSS=m
>  	CONFIG_SND_PCM_OSS=m
>  	CONFIG_SND_AC97_CODEC=m
>  	CONFIG_SND_AC97_BUS=m
>  	CONFIG_SND_INTEL8X0=m

Cannot reproduce it.  Please send full .config and precise means of
reproduction, thanks.



-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: ALSA regression: oops on shutdown
@ 2006-04-24  1:57   ` Andrew Morton
  0 siblings, 0 replies; 23+ messages in thread
From: Andrew Morton @ 2006-04-24  1:57 UTC (permalink / raw)
  To: Alexey Dobriyan; +Cc: linux-kernel, perex, alsa-devel

Alexey Dobriyan <adobriyan@gmail.com> wrote:
>
> ALSA oops I reported against 2.6.16-rc1-mm4 [1] sneaked into mainline
>  after release.

One wonders why the ALSA developers merged up which was known to cause
oopses.


>  ----------------------------
>  EIP is at remove_proc_entry
>  Process rmmod
> 
>  snd_info_unregister             [snd]
>  snd_pcm_oss_proc_done           [snd_pcm_oss]
>  snd_pcm_oss_unregister_minor    [snd_pcm_oss]
>  snd_pcm_notify                  [snd_pcm]
>  sys_delete_module
>  do_munmap
>  syscall_call
>  ----------------------------
>  Fine-grained bisecting points to commit 21a3479a0b606d36fe24093f70a1c27328cec286
> 
>      [ALSA] PCM midlevel & PCM OSS - make procfs & OSS plugin code optional
> 
>  .config is
> 
>  	CONFIG_SOUND=m
>  	CONFIG_SND=m
>  	CONFIG_SND_TIMER=m
>  	CONFIG_SND_PCM=m
>  	CONFIG_SND_OSSEMUL=y
>  	CONFIG_SND_MIXER_OSS=m
>  	CONFIG_SND_PCM_OSS=m
>  	CONFIG_SND_AC97_CODEC=m
>  	CONFIG_SND_AC97_BUS=m
>  	CONFIG_SND_INTEL8X0=m

Cannot reproduce it.  Please send full .config and precise means of
reproduction, thanks.


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: ALSA regression: oops on shutdown
  2006-04-24  1:57   ` Andrew Morton
@ 2006-04-24  2:37     ` Alexey Dobriyan
  -1 siblings, 0 replies; 23+ messages in thread
From: Alexey Dobriyan @ 2006-04-24  2:37 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel, perex, alsa-devel

On 4/23/06, Andrew Morton <akpm@osdl.org> wrote:
> Alexey Dobriyan <adobriyan@gmail.com> wrote:
> >
> > ALSA oops I reported against 2.6.16-rc1-mm4 [1] sneaked into mainline
> >  after release.
>
> One wonders why the ALSA developers merged up which was known to cause
> oopses.

To be fair, I bisected it only to git-alsa.patch back then and only
now found enough time, so
blame me.


-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid\x120709&bid&3057&dat\x121642

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: ALSA regression: oops on shutdown
@ 2006-04-24  2:37     ` Alexey Dobriyan
  0 siblings, 0 replies; 23+ messages in thread
From: Alexey Dobriyan @ 2006-04-24  2:37 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel, perex, alsa-devel

On 4/23/06, Andrew Morton <akpm@osdl.org> wrote:
> Alexey Dobriyan <adobriyan@gmail.com> wrote:
> >
> > ALSA oops I reported against 2.6.16-rc1-mm4 [1] sneaked into mainline
> >  after release.
>
> One wonders why the ALSA developers merged up which was known to cause
> oopses.

To be fair, I bisected it only to git-alsa.patch back then and only
now found enough time, so
blame me.

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: Re: ALSA regression: oops on shutdown
  2006-04-24  2:37     ` Alexey Dobriyan
  (?)
  (?)
@ 2006-04-24  2:39     ` Lee Revell
  -1 siblings, 0 replies; 23+ messages in thread
From: Lee Revell @ 2006-04-24  2:39 UTC (permalink / raw)
  To: Alexey Dobriyan; +Cc: Andrew Morton, linux-kernel, perex, alsa-devel

On Sun, 2006-04-23 at 19:37 -0700, Alexey Dobriyan wrote:
> On 4/23/06, Andrew Morton <akpm@osdl.org> wrote:
> > Alexey Dobriyan <adobriyan@gmail.com> wrote:
> > >
> > > ALSA oops I reported against 2.6.16-rc1-mm4 [1] sneaked into mainline
> > >  after release.
> >
> > One wonders why the ALSA developers merged up which was known to cause
> > oopses.
> 
> To be fair, I bisected it only to git-alsa.patch back then and only
> now found enough time, so
> blame me.

Do you have procfs disabled?  Full config is needed to debug this more.

Lee



-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Alsa-devel] Re: ALSA regression: oops on shutdown
  2006-04-24  2:37     ` Alexey Dobriyan
  (?)
@ 2006-04-24  2:39     ` Lee Revell
  2006-04-24  3:11         ` [Alsa-devel] " Alexey Dobriyan
  -1 siblings, 1 reply; 23+ messages in thread
From: Lee Revell @ 2006-04-24  2:39 UTC (permalink / raw)
  To: Alexey Dobriyan; +Cc: Andrew Morton, linux-kernel, perex, alsa-devel

On Sun, 2006-04-23 at 19:37 -0700, Alexey Dobriyan wrote:
> On 4/23/06, Andrew Morton <akpm@osdl.org> wrote:
> > Alexey Dobriyan <adobriyan@gmail.com> wrote:
> > >
> > > ALSA oops I reported against 2.6.16-rc1-mm4 [1] sneaked into mainline
> > >  after release.
> >
> > One wonders why the ALSA developers merged up which was known to cause
> > oopses.
> 
> To be fair, I bisected it only to git-alsa.patch back then and only
> now found enough time, so
> blame me.

Do you have procfs disabled?  Full config is needed to debug this more.

Lee


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: Re: ALSA regression: oops on shutdown
  2006-04-24  2:39     ` [Alsa-devel] " Lee Revell
@ 2006-04-24  3:11         ` Alexey Dobriyan
  0 siblings, 0 replies; 23+ messages in thread
From: Alexey Dobriyan @ 2006-04-24  3:11 UTC (permalink / raw)
  To: Lee Revell; +Cc: Andrew Morton, linux-kernel, perex, alsa-devel

On Sun, Apr 23, 2006 at 10:39:19PM -0400, Lee Revell wrote:

Andrew asked about precise steps of reproduction:

	rmmod snd_pcm_oss

which is part of Gentoo install scripts (/etc/init.d/alsasound:134-140, to
be precise) (basically lsmod | grep snd | xargs rmmod).

BUG: unable to handle kernel paging request at virtual address 6b6b6b6b
 printing eip:
c016c6a4
*pde = 00000000
Oops: 0000 [#1]
PREEMPT
Modules linked in: snd_pcm_oss snd_mixer_oss snd_intel8x0 snd_ac97_codec snd_ac97_bus snd_pcm snd_timer snd soundcore snd_page_alloc ehci_hcd uhci_hcd usbcore
CPU:    0
EIP:    0060:[<c016c6a4>]    Not tainted VLI
EFLAGS: 00010286   (2.6.17-rc2-6b426e785cb81e53dc2fc4dcf997661472b470ef #1)
EIP is at remove_proc_entry+0x2c/0x11c
eax: 00000000   ebx: deb48b80   ecx: ffffffff   edx: de11ed24
esi: de11ed24   edi: 6b6b6b6b   ebp: de4cb000   esp: de4cbf28
ds: 007b   es: 007b   ss: 0068
Process rmmod (pid: 7735, threadinfo=de4cb000 task=c1487a90)
Stack: <0>de11ed24 6b6b6b6b deb48b80 de11ed24 bf8590cc df93603b de4f0e78 00000000
       df965fc8 de4f0d84 df967e74 df966184 de4f0d88 df95292d df967f00 00000000
       c0125f7a 00000000 5f646e73 5f6d6370 0073736f de85d4a4 b7f27000 c013789d
Call Trace:
 [<df93603b>] snd_info_unregister+0x2e/0x44 [snd]
 [<df965fc8>] snd_pcm_oss_proc_done+0x19/0x30 [snd_pcm_oss]
 [<df966184>] snd_pcm_oss_unregister_minor+0x3b/0x3f [snd_pcm_oss]
 [<df95292d>] snd_pcm_notify+0x4a/0x91 [snd_pcm]
 [<c0125f7a>] sys_delete_module+0x113/0x138
 [<c013789d>] do_munmap+0xe2/0xef
 [<c010259b>] syscall_call+0x7/0xb
Code: 85 d2 56 53 51 51 89 14 24 89 44 24 04 75 13 8d 4c 24 04 89 e2 e8 dd f7 ff ff 85 c0 0f 85 f2 00 00 00 8b 7c 24 04 31 c0 83 c9 ff <f2> ae f7 d1 49 b0 01 89 ce e8 fa 13 fa ff 8b 04 24 8d 58 38 83
EIP: [<c016c6a4>] remove_proc_entry+0x2c/0x11c SS:ESP 0068:de4cbf28
 BUG: rmmod/7735, lock held at task exit time!
 [df960920] {register_mutex}
.. held by:             rmmod: 7735 [c1487a90, 118]
... acquired at:               snd_pcm_notify+0x10/0x91 [snd_pcm]

> Do you have procfs disabled?

No, /proc is on.

> Full config is needed to debug this more.

# Linux kernel version: 2.6.17-rc2-6b426e785cb81e53dc2fc4dcf997661472b470ef
CONFIG_X86_32=y
CONFIG_SEMAPHORE_SLEEPERS=y
CONFIG_X86=y
CONFIG_MMU=y
CONFIG_GENERIC_ISA_DMA=y
CONFIG_GENERIC_IOMAP=y
CONFIG_GENERIC_HWEIGHT=y
CONFIG_ARCH_MAY_HAVE_PC_FDC=y
CONFIG_DMI=y
CONFIG_EXPERIMENTAL=y
CONFIG_BROKEN_ON_SMP=y
CONFIG_LOCK_KERNEL=y
CONFIG_INIT_ENV_ARG_LIMIT=32
CONFIG_LOCALVERSION=""
CONFIG_SWAP=y
CONFIG_SYSVIPC=y
CONFIG_SYSCTL=y
CONFIG_IKCONFIG=y
CONFIG_IKCONFIG_PROC=y
CONFIG_INITRAMFS_SOURCE=""
CONFIG_VM86=y
CONFIG_CC_OPTIMIZE_FOR_SIZE=y
CONFIG_EMBEDDED=y
CONFIG_KALLSYMS=y
CONFIG_HOTPLUG=y
CONFIG_PRINTK=y
CONFIG_BUG=y
CONFIG_ELF_CORE=y
CONFIG_BASE_FULL=y
CONFIG_FUTEX=y
CONFIG_EPOLL=y
CONFIG_SHMEM=y
CONFIG_SLAB=y
CONFIG_BASE_SMALL=0
CONFIG_MODULES=y
CONFIG_MODULE_UNLOAD=y
CONFIG_KMOD=y
CONFIG_IOSCHED_NOOP=y
CONFIG_IOSCHED_CFQ=y
CONFIG_DEFAULT_CFQ=y
CONFIG_DEFAULT_IOSCHED="cfq"
CONFIG_X86_PC=y
CONFIG_MPENTIUM4=y
CONFIG_X86_CMPXCHG=y
CONFIG_X86_XADD=y
CONFIG_X86_L1_CACHE_SHIFT=7
CONFIG_RWSEM_XCHGADD_ALGORITHM=y
CONFIG_GENERIC_CALIBRATE_DELAY=y
CONFIG_X86_WP_WORKS_OK=y
CONFIG_X86_INVLPG=y
CONFIG_X86_BSWAP=y
CONFIG_X86_POPAD_OK=y
CONFIG_X86_CMPXCHG64=y
CONFIG_X86_GOOD_APIC=y
CONFIG_X86_INTEL_USERCOPY=y
CONFIG_X86_USE_PPRO_CHECKSUM=y
CONFIG_X86_TSC=y
CONFIG_PREEMPT=y
CONFIG_PREEMPT_BKL=y
CONFIG_X86_MCE=y
CONFIG_NOHIGHMEM=y
CONFIG_VMSPLIT_3G=y
CONFIG_PAGE_OFFSET=0xC0000000
CONFIG_ARCH_FLATMEM_ENABLE=y
CONFIG_ARCH_SPARSEMEM_ENABLE=y
CONFIG_ARCH_SELECT_MEMORY_MODEL=y
CONFIG_SELECT_MEMORY_MODEL=y
CONFIG_FLATMEM_MANUAL=y
CONFIG_FLATMEM=y
CONFIG_FLAT_NODE_MEM_MAP=y
CONFIG_SPARSEMEM_STATIC=y
CONFIG_SPLIT_PTLOCK_CPUS=4
CONFIG_MTRR=y
CONFIG_REGPARM=y
CONFIG_HZ_250=y
CONFIG_HZ=250
CONFIG_PHYSICAL_START=0x100000
CONFIG_PM=y
CONFIG_ACPI=y
CONFIG_ACPI_PROCESSOR=y
CONFIG_ACPI_THERMAL=y
CONFIG_ACPI_BLACKLIST_YEAR=0
CONFIG_ACPI_EC=y
CONFIG_ACPI_POWER=y
CONFIG_ACPI_SYSTEM=y
CONFIG_PCI=y
CONFIG_PCI_GOANY=y
CONFIG_PCI_BIOS=y
CONFIG_PCI_DIRECT=y
CONFIG_PCI_MMCONFIG=y
CONFIG_ISA_DMA_API=y
CONFIG_BINFMT_ELF=y
CONFIG_NET=y
CONFIG_PACKET=y
CONFIG_UNIX=y
CONFIG_INET=y
CONFIG_IP_FIB_HASH=y
CONFIG_TCP_CONG_BIC=y
CONFIG_STANDALONE=y
CONFIG_PREVENT_FIRMWARE_BUILD=y
CONFIG_PNP=y
CONFIG_PNPACPI=y
CONFIG_BLK_DEV_LOOP=m
CONFIG_IDE=y
CONFIG_BLK_DEV_IDE=y
CONFIG_BLK_DEV_IDEDISK=y
CONFIG_IDEDISK_MULTI_MODE=y
CONFIG_BLK_DEV_IDECD=m
CONFIG_IDE_GENERIC=y
CONFIG_BLK_DEV_IDEPCI=y
CONFIG_IDEPCI_SHARE_IRQ=y
CONFIG_BLK_DEV_GENERIC=y
CONFIG_BLK_DEV_IDEDMA_PCI=y
CONFIG_IDEDMA_PCI_AUTO=y
CONFIG_BLK_DEV_PIIX=y
CONFIG_BLK_DEV_IDEDMA=y
CONFIG_IDEDMA_AUTO=y
CONFIG_SCSI=m
CONFIG_BLK_DEV_SD=m
CONFIG_NETDEVICES=y
CONFIG_NET_ETHERNET=y
CONFIG_MII=y
CONFIG_NET_PCI=y
CONFIG_8139TOO=y
CONFIG_8139TOO_PIO=y
CONFIG_INPUT=y
CONFIG_INPUT_MOUSEDEV=y
CONFIG_INPUT_MOUSEDEV_SCREEN_X=1024
CONFIG_INPUT_MOUSEDEV_SCREEN_Y=768
CONFIG_INPUT_KEYBOARD=y
CONFIG_KEYBOARD_ATKBD=y
CONFIG_INPUT_MOUSE=y
CONFIG_MOUSE_PS2=y
CONFIG_SERIO=y
CONFIG_SERIO_I8042=y
CONFIG_SERIO_LIBPS2=y
CONFIG_VT=y
CONFIG_VT_CONSOLE=y
CONFIG_HW_CONSOLE=y
CONFIG_SERIAL_8250=y
CONFIG_SERIAL_8250_NR_UARTS=4
CONFIG_SERIAL_8250_RUNTIME_UARTS=0
CONFIG_SERIAL_CORE=y
CONFIG_UNIX98_PTYS=y
CONFIG_RTC=y
CONFIG_AGP=y
CONFIG_AGP_INTEL=y
CONFIG_DRM=y
CONFIG_DRM_I915=y
CONFIG_FB=y
CONFIG_FB_CFB_FILLRECT=y
CONFIG_FB_CFB_COPYAREA=y
CONFIG_FB_CFB_IMAGEBLIT=y
CONFIG_FB_MODE_HELPERS=y
CONFIG_FB_INTEL=y
CONFIG_VGA_CONSOLE=y
CONFIG_DUMMY_CONSOLE=y
CONFIG_SOUND=m
CONFIG_SND=m
CONFIG_SND_TIMER=m
CONFIG_SND_PCM=m
CONFIG_SND_OSSEMUL=y
CONFIG_SND_MIXER_OSS=m
CONFIG_SND_PCM_OSS=m
CONFIG_SND_AC97_CODEC=m
CONFIG_SND_AC97_BUS=m
CONFIG_SND_INTEL8X0=m
CONFIG_USB_ARCH_HAS_HCD=y
CONFIG_USB_ARCH_HAS_OHCI=y
CONFIG_USB_ARCH_HAS_EHCI=y
CONFIG_USB=m
CONFIG_USB_EHCI_HCD=m
CONFIG_USB_UHCI_HCD=m
CONFIG_USB_STORAGE=m
CONFIG_EXT2_FS=y
CONFIG_REISERFS_FS=y
CONFIG_ISO9660_FS=m
CONFIG_JOLIET=y
CONFIG_FAT_FS=m
CONFIG_VFAT_FS=m
CONFIG_FAT_DEFAULT_CODEPAGE=866
CONFIG_FAT_DEFAULT_IOCHARSET="koi8-r"
CONFIG_PROC_FS=y
CONFIG_SYSFS=y
CONFIG_TMPFS=y
CONFIG_RAMFS=y
CONFIG_UFS_FS=y
CONFIG_CIFS=m
CONFIG_PARTITION_ADVANCED=y
CONFIG_MSDOS_PARTITION=y
CONFIG_BSD_DISKLABEL=y
CONFIG_NLS=y
CONFIG_NLS_DEFAULT="utf8"
CONFIG_NLS_CODEPAGE_866=m
CONFIG_NLS_KOI8_R=m
CONFIG_NLS_UTF8=y
CONFIG_MAGIC_SYSRQ=y
CONFIG_DEBUG_KERNEL=y
CONFIG_LOG_BUF_SHIFT=15
CONFIG_DETECT_SOFTLOCKUP=y
CONFIG_DEBUG_SLAB=y
CONFIG_DEBUG_PREEMPT=y
CONFIG_DEBUG_MUTEXES=y
CONFIG_DEBUG_BUGVERBOSE=y
CONFIG_DEBUG_VM=y
CONFIG_FORCED_INLINING=y
CONFIG_DEBUG_STACKOVERFLOW=y
CONFIG_DEBUG_STACK_USAGE=y
CONFIG_STACK_BACKTRACE_COLS=1
CONFIG_DEBUG_RODATA=y
CONFIG_4KSTACKS=y
CONFIG_DOUBLEFAULT=y
CONFIG_CRC32=y
CONFIG_GENERIC_HARDIRQS=y
CONFIG_GENERIC_IRQ_PROBE=y
CONFIG_X86_BIOS_REBOOT=y
CONFIG_KTIME_SCALAR=y



-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Alsa-devel] Re: ALSA regression: oops on shutdown
@ 2006-04-24  3:11         ` Alexey Dobriyan
  0 siblings, 0 replies; 23+ messages in thread
From: Alexey Dobriyan @ 2006-04-24  3:11 UTC (permalink / raw)
  To: Lee Revell; +Cc: Andrew Morton, linux-kernel, perex, alsa-devel

On Sun, Apr 23, 2006 at 10:39:19PM -0400, Lee Revell wrote:

Andrew asked about precise steps of reproduction:

	rmmod snd_pcm_oss

which is part of Gentoo install scripts (/etc/init.d/alsasound:134-140, to
be precise) (basically lsmod | grep snd | xargs rmmod).

BUG: unable to handle kernel paging request at virtual address 6b6b6b6b
 printing eip:
c016c6a4
*pde = 00000000
Oops: 0000 [#1]
PREEMPT
Modules linked in: snd_pcm_oss snd_mixer_oss snd_intel8x0 snd_ac97_codec snd_ac97_bus snd_pcm snd_timer snd soundcore snd_page_alloc ehci_hcd uhci_hcd usbcore
CPU:    0
EIP:    0060:[<c016c6a4>]    Not tainted VLI
EFLAGS: 00010286   (2.6.17-rc2-6b426e785cb81e53dc2fc4dcf997661472b470ef #1)
EIP is at remove_proc_entry+0x2c/0x11c
eax: 00000000   ebx: deb48b80   ecx: ffffffff   edx: de11ed24
esi: de11ed24   edi: 6b6b6b6b   ebp: de4cb000   esp: de4cbf28
ds: 007b   es: 007b   ss: 0068
Process rmmod (pid: 7735, threadinfo=de4cb000 task=c1487a90)
Stack: <0>de11ed24 6b6b6b6b deb48b80 de11ed24 bf8590cc df93603b de4f0e78 00000000
       df965fc8 de4f0d84 df967e74 df966184 de4f0d88 df95292d df967f00 00000000
       c0125f7a 00000000 5f646e73 5f6d6370 0073736f de85d4a4 b7f27000 c013789d
Call Trace:
 [<df93603b>] snd_info_unregister+0x2e/0x44 [snd]
 [<df965fc8>] snd_pcm_oss_proc_done+0x19/0x30 [snd_pcm_oss]
 [<df966184>] snd_pcm_oss_unregister_minor+0x3b/0x3f [snd_pcm_oss]
 [<df95292d>] snd_pcm_notify+0x4a/0x91 [snd_pcm]
 [<c0125f7a>] sys_delete_module+0x113/0x138
 [<c013789d>] do_munmap+0xe2/0xef
 [<c010259b>] syscall_call+0x7/0xb
Code: 85 d2 56 53 51 51 89 14 24 89 44 24 04 75 13 8d 4c 24 04 89 e2 e8 dd f7 ff ff 85 c0 0f 85 f2 00 00 00 8b 7c 24 04 31 c0 83 c9 ff <f2> ae f7 d1 49 b0 01 89 ce e8 fa 13 fa ff 8b 04 24 8d 58 38 83
EIP: [<c016c6a4>] remove_proc_entry+0x2c/0x11c SS:ESP 0068:de4cbf28
 BUG: rmmod/7735, lock held at task exit time!
 [df960920] {register_mutex}
.. held by:             rmmod: 7735 [c1487a90, 118]
... acquired at:               snd_pcm_notify+0x10/0x91 [snd_pcm]

> Do you have procfs disabled?

No, /proc is on.

> Full config is needed to debug this more.

# Linux kernel version: 2.6.17-rc2-6b426e785cb81e53dc2fc4dcf997661472b470ef
CONFIG_X86_32=y
CONFIG_SEMAPHORE_SLEEPERS=y
CONFIG_X86=y
CONFIG_MMU=y
CONFIG_GENERIC_ISA_DMA=y
CONFIG_GENERIC_IOMAP=y
CONFIG_GENERIC_HWEIGHT=y
CONFIG_ARCH_MAY_HAVE_PC_FDC=y
CONFIG_DMI=y
CONFIG_EXPERIMENTAL=y
CONFIG_BROKEN_ON_SMP=y
CONFIG_LOCK_KERNEL=y
CONFIG_INIT_ENV_ARG_LIMIT=32
CONFIG_LOCALVERSION=""
CONFIG_SWAP=y
CONFIG_SYSVIPC=y
CONFIG_SYSCTL=y
CONFIG_IKCONFIG=y
CONFIG_IKCONFIG_PROC=y
CONFIG_INITRAMFS_SOURCE=""
CONFIG_VM86=y
CONFIG_CC_OPTIMIZE_FOR_SIZE=y
CONFIG_EMBEDDED=y
CONFIG_KALLSYMS=y
CONFIG_HOTPLUG=y
CONFIG_PRINTK=y
CONFIG_BUG=y
CONFIG_ELF_CORE=y
CONFIG_BASE_FULL=y
CONFIG_FUTEX=y
CONFIG_EPOLL=y
CONFIG_SHMEM=y
CONFIG_SLAB=y
CONFIG_BASE_SMALL=0
CONFIG_MODULES=y
CONFIG_MODULE_UNLOAD=y
CONFIG_KMOD=y
CONFIG_IOSCHED_NOOP=y
CONFIG_IOSCHED_CFQ=y
CONFIG_DEFAULT_CFQ=y
CONFIG_DEFAULT_IOSCHED="cfq"
CONFIG_X86_PC=y
CONFIG_MPENTIUM4=y
CONFIG_X86_CMPXCHG=y
CONFIG_X86_XADD=y
CONFIG_X86_L1_CACHE_SHIFT=7
CONFIG_RWSEM_XCHGADD_ALGORITHM=y
CONFIG_GENERIC_CALIBRATE_DELAY=y
CONFIG_X86_WP_WORKS_OK=y
CONFIG_X86_INVLPG=y
CONFIG_X86_BSWAP=y
CONFIG_X86_POPAD_OK=y
CONFIG_X86_CMPXCHG64=y
CONFIG_X86_GOOD_APIC=y
CONFIG_X86_INTEL_USERCOPY=y
CONFIG_X86_USE_PPRO_CHECKSUM=y
CONFIG_X86_TSC=y
CONFIG_PREEMPT=y
CONFIG_PREEMPT_BKL=y
CONFIG_X86_MCE=y
CONFIG_NOHIGHMEM=y
CONFIG_VMSPLIT_3G=y
CONFIG_PAGE_OFFSET=0xC0000000
CONFIG_ARCH_FLATMEM_ENABLE=y
CONFIG_ARCH_SPARSEMEM_ENABLE=y
CONFIG_ARCH_SELECT_MEMORY_MODEL=y
CONFIG_SELECT_MEMORY_MODEL=y
CONFIG_FLATMEM_MANUAL=y
CONFIG_FLATMEM=y
CONFIG_FLAT_NODE_MEM_MAP=y
CONFIG_SPARSEMEM_STATIC=y
CONFIG_SPLIT_PTLOCK_CPUS=4
CONFIG_MTRR=y
CONFIG_REGPARM=y
CONFIG_HZ_250=y
CONFIG_HZ=250
CONFIG_PHYSICAL_START=0x100000
CONFIG_PM=y
CONFIG_ACPI=y
CONFIG_ACPI_PROCESSOR=y
CONFIG_ACPI_THERMAL=y
CONFIG_ACPI_BLACKLIST_YEAR=0
CONFIG_ACPI_EC=y
CONFIG_ACPI_POWER=y
CONFIG_ACPI_SYSTEM=y
CONFIG_PCI=y
CONFIG_PCI_GOANY=y
CONFIG_PCI_BIOS=y
CONFIG_PCI_DIRECT=y
CONFIG_PCI_MMCONFIG=y
CONFIG_ISA_DMA_API=y
CONFIG_BINFMT_ELF=y
CONFIG_NET=y
CONFIG_PACKET=y
CONFIG_UNIX=y
CONFIG_INET=y
CONFIG_IP_FIB_HASH=y
CONFIG_TCP_CONG_BIC=y
CONFIG_STANDALONE=y
CONFIG_PREVENT_FIRMWARE_BUILD=y
CONFIG_PNP=y
CONFIG_PNPACPI=y
CONFIG_BLK_DEV_LOOP=m
CONFIG_IDE=y
CONFIG_BLK_DEV_IDE=y
CONFIG_BLK_DEV_IDEDISK=y
CONFIG_IDEDISK_MULTI_MODE=y
CONFIG_BLK_DEV_IDECD=m
CONFIG_IDE_GENERIC=y
CONFIG_BLK_DEV_IDEPCI=y
CONFIG_IDEPCI_SHARE_IRQ=y
CONFIG_BLK_DEV_GENERIC=y
CONFIG_BLK_DEV_IDEDMA_PCI=y
CONFIG_IDEDMA_PCI_AUTO=y
CONFIG_BLK_DEV_PIIX=y
CONFIG_BLK_DEV_IDEDMA=y
CONFIG_IDEDMA_AUTO=y
CONFIG_SCSI=m
CONFIG_BLK_DEV_SD=m
CONFIG_NETDEVICES=y
CONFIG_NET_ETHERNET=y
CONFIG_MII=y
CONFIG_NET_PCI=y
CONFIG_8139TOO=y
CONFIG_8139TOO_PIO=y
CONFIG_INPUT=y
CONFIG_INPUT_MOUSEDEV=y
CONFIG_INPUT_MOUSEDEV_SCREEN_X=1024
CONFIG_INPUT_MOUSEDEV_SCREEN_Y=768
CONFIG_INPUT_KEYBOARD=y
CONFIG_KEYBOARD_ATKBD=y
CONFIG_INPUT_MOUSE=y
CONFIG_MOUSE_PS2=y
CONFIG_SERIO=y
CONFIG_SERIO_I8042=y
CONFIG_SERIO_LIBPS2=y
CONFIG_VT=y
CONFIG_VT_CONSOLE=y
CONFIG_HW_CONSOLE=y
CONFIG_SERIAL_8250=y
CONFIG_SERIAL_8250_NR_UARTS=4
CONFIG_SERIAL_8250_RUNTIME_UARTS=0
CONFIG_SERIAL_CORE=y
CONFIG_UNIX98_PTYS=y
CONFIG_RTC=y
CONFIG_AGP=y
CONFIG_AGP_INTEL=y
CONFIG_DRM=y
CONFIG_DRM_I915=y
CONFIG_FB=y
CONFIG_FB_CFB_FILLRECT=y
CONFIG_FB_CFB_COPYAREA=y
CONFIG_FB_CFB_IMAGEBLIT=y
CONFIG_FB_MODE_HELPERS=y
CONFIG_FB_INTEL=y
CONFIG_VGA_CONSOLE=y
CONFIG_DUMMY_CONSOLE=y
CONFIG_SOUND=m
CONFIG_SND=m
CONFIG_SND_TIMER=m
CONFIG_SND_PCM=m
CONFIG_SND_OSSEMUL=y
CONFIG_SND_MIXER_OSS=m
CONFIG_SND_PCM_OSS=m
CONFIG_SND_AC97_CODEC=m
CONFIG_SND_AC97_BUS=m
CONFIG_SND_INTEL8X0=m
CONFIG_USB_ARCH_HAS_HCD=y
CONFIG_USB_ARCH_HAS_OHCI=y
CONFIG_USB_ARCH_HAS_EHCI=y
CONFIG_USB=m
CONFIG_USB_EHCI_HCD=m
CONFIG_USB_UHCI_HCD=m
CONFIG_USB_STORAGE=m
CONFIG_EXT2_FS=y
CONFIG_REISERFS_FS=y
CONFIG_ISO9660_FS=m
CONFIG_JOLIET=y
CONFIG_FAT_FS=m
CONFIG_VFAT_FS=m
CONFIG_FAT_DEFAULT_CODEPAGE=866
CONFIG_FAT_DEFAULT_IOCHARSET="koi8-r"
CONFIG_PROC_FS=y
CONFIG_SYSFS=y
CONFIG_TMPFS=y
CONFIG_RAMFS=y
CONFIG_UFS_FS=y
CONFIG_CIFS=m
CONFIG_PARTITION_ADVANCED=y
CONFIG_MSDOS_PARTITION=y
CONFIG_BSD_DISKLABEL=y
CONFIG_NLS=y
CONFIG_NLS_DEFAULT="utf8"
CONFIG_NLS_CODEPAGE_866=m
CONFIG_NLS_KOI8_R=m
CONFIG_NLS_UTF8=y
CONFIG_MAGIC_SYSRQ=y
CONFIG_DEBUG_KERNEL=y
CONFIG_LOG_BUF_SHIFT=15
CONFIG_DETECT_SOFTLOCKUP=y
CONFIG_DEBUG_SLAB=y
CONFIG_DEBUG_PREEMPT=y
CONFIG_DEBUG_MUTEXES=y
CONFIG_DEBUG_BUGVERBOSE=y
CONFIG_DEBUG_VM=y
CONFIG_FORCED_INLINING=y
CONFIG_DEBUG_STACKOVERFLOW=y
CONFIG_DEBUG_STACK_USAGE=y
CONFIG_STACK_BACKTRACE_COLS=1
CONFIG_DEBUG_RODATA=y
CONFIG_4KSTACKS=y
CONFIG_DOUBLEFAULT=y
CONFIG_CRC32=y
CONFIG_GENERIC_HARDIRQS=y
CONFIG_GENERIC_IRQ_PROBE=y
CONFIG_X86_BIOS_REBOOT=y
CONFIG_KTIME_SCALAR=y


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: Re: ALSA regression: oops on shutdown
  2006-04-24  3:11         ` [Alsa-devel] " Alexey Dobriyan
@ 2006-04-24  3:51           ` Alexey Dobriyan
  -1 siblings, 0 replies; 23+ messages in thread
From: Alexey Dobriyan @ 2006-04-24  3:51 UTC (permalink / raw)
  To: Lee Revell; +Cc: Andrew Morton, linux-kernel, perex, alsa-devel

On Mon, Apr 24, 2006 at 07:11:42AM +0400, Alexey Dobriyan wrote:
> On Sun, Apr 23, 2006 at 10:39:19PM -0400, Lee Revell wrote:
>
> Andrew asked about precise steps of reproduction:
>
> 	rmmod snd_pcm_oss
>
> which is part of Gentoo install scripts (/etc/init.d/alsasound:134-140, to
> be precise) (basically lsmod | grep snd | xargs rmmod).
>
> BUG: unable to handle kernel paging request at virtual address 6b6b6b6b
>  printing eip:
> c016c6a4
> *pde = 00000000
> Oops: 0000 [#1]
> PREEMPT
> Modules linked in: snd_pcm_oss snd_mixer_oss snd_intel8x0 snd_ac97_codec snd_ac97_bus snd_pcm snd_timer snd soundcore snd_page_alloc ehci_hcd uhci_hcd usbcore
> CPU:    0
> EIP:    0060:[<c016c6a4>]    Not tainted VLI
> EFLAGS: 00010286   (2.6.17-rc2-6b426e785cb81e53dc2fc4dcf997661472b470ef #1)
> EIP is at remove_proc_entry+0x2c/0x11c
> eax: 00000000   ebx: deb48b80   ecx: ffffffff   edx: de11ed24
> esi: de11ed24   edi: 6b6b6b6b   ebp: de4cb000   esp: de4cbf28
> ds: 007b   es: 007b   ss: 0068
> Process rmmod (pid: 7735, threadinfo=de4cb000 task=c1487a90)
> Stack: <0>de11ed24 6b6b6b6b deb48b80 de11ed24 bf8590cc df93603b de4f0e78 00000000
>        df965fc8 de4f0d84 df967e74 df966184 de4f0d88 df95292d df967f00 00000000
>        c0125f7a 00000000 5f646e73 5f6d6370 0073736f de85d4a4 b7f27000 c013789d
> Call Trace:
>  [<df93603b>] snd_info_unregister+0x2e/0x44 [snd]
>  [<df965fc8>] snd_pcm_oss_proc_done+0x19/0x30 [snd_pcm_oss]
>  [<df966184>] snd_pcm_oss_unregister_minor+0x3b/0x3f [snd_pcm_oss]
>  [<df95292d>] snd_pcm_notify+0x4a/0x91 [snd_pcm]
>  [<c0125f7a>] sys_delete_module+0x113/0x138
>  [<c013789d>] do_munmap+0xe2/0xef
>  [<c010259b>] syscall_call+0x7/0xb
> Code: 85 d2 56 53 51 51 89 14 24 89 44 24 04 75 13 8d 4c 24 04 89 e2 e8 dd f7 ff ff 85 c0 0f 85 f2 00 00 00 8b 7c 24 04 31 c0 83 c9 ff <f2> ae f7 d1 49 b0 01 89 ce e8 fa 13 fa ff 8b 04 24 8d 58 38 83
> EIP: [<c016c6a4>] remove_proc_entry+0x2c/0x11c SS:ESP 0068:de4cbf28
>  BUG: rmmod/7735, lock held at task exit time!
>  [df960920] {register_mutex}
> .. held by:             rmmod: 7735 [c1487a90, 118]
> ... acquired at:               snd_pcm_notify+0x10/0x91 [snd_pcm]

Other symptoms are 6 (six) "prealloc" files, 3 "oss" files and 1 "oss"
directory (according to highlighting):

$ ls /proc/asound/
card0  devices  modules  oss  oss  prealloc  prealloc  prealloc  timers
			      ^^^
			      directory

cards  ICH5     oss      oss  pcm  prealloc  prealloc  prealloc  version

"ls -l" thinks all 4 "oss" files are files (again, according to
highlighting).



-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Alsa-devel] Re: ALSA regression: oops on shutdown
@ 2006-04-24  3:51           ` Alexey Dobriyan
  0 siblings, 0 replies; 23+ messages in thread
From: Alexey Dobriyan @ 2006-04-24  3:51 UTC (permalink / raw)
  To: Lee Revell; +Cc: Andrew Morton, linux-kernel, perex, alsa-devel

On Mon, Apr 24, 2006 at 07:11:42AM +0400, Alexey Dobriyan wrote:
> On Sun, Apr 23, 2006 at 10:39:19PM -0400, Lee Revell wrote:
>
> Andrew asked about precise steps of reproduction:
>
> 	rmmod snd_pcm_oss
>
> which is part of Gentoo install scripts (/etc/init.d/alsasound:134-140, to
> be precise) (basically lsmod | grep snd | xargs rmmod).
>
> BUG: unable to handle kernel paging request at virtual address 6b6b6b6b
>  printing eip:
> c016c6a4
> *pde = 00000000
> Oops: 0000 [#1]
> PREEMPT
> Modules linked in: snd_pcm_oss snd_mixer_oss snd_intel8x0 snd_ac97_codec snd_ac97_bus snd_pcm snd_timer snd soundcore snd_page_alloc ehci_hcd uhci_hcd usbcore
> CPU:    0
> EIP:    0060:[<c016c6a4>]    Not tainted VLI
> EFLAGS: 00010286   (2.6.17-rc2-6b426e785cb81e53dc2fc4dcf997661472b470ef #1)
> EIP is at remove_proc_entry+0x2c/0x11c
> eax: 00000000   ebx: deb48b80   ecx: ffffffff   edx: de11ed24
> esi: de11ed24   edi: 6b6b6b6b   ebp: de4cb000   esp: de4cbf28
> ds: 007b   es: 007b   ss: 0068
> Process rmmod (pid: 7735, threadinfo=de4cb000 task=c1487a90)
> Stack: <0>de11ed24 6b6b6b6b deb48b80 de11ed24 bf8590cc df93603b de4f0e78 00000000
>        df965fc8 de4f0d84 df967e74 df966184 de4f0d88 df95292d df967f00 00000000
>        c0125f7a 00000000 5f646e73 5f6d6370 0073736f de85d4a4 b7f27000 c013789d
> Call Trace:
>  [<df93603b>] snd_info_unregister+0x2e/0x44 [snd]
>  [<df965fc8>] snd_pcm_oss_proc_done+0x19/0x30 [snd_pcm_oss]
>  [<df966184>] snd_pcm_oss_unregister_minor+0x3b/0x3f [snd_pcm_oss]
>  [<df95292d>] snd_pcm_notify+0x4a/0x91 [snd_pcm]
>  [<c0125f7a>] sys_delete_module+0x113/0x138
>  [<c013789d>] do_munmap+0xe2/0xef
>  [<c010259b>] syscall_call+0x7/0xb
> Code: 85 d2 56 53 51 51 89 14 24 89 44 24 04 75 13 8d 4c 24 04 89 e2 e8 dd f7 ff ff 85 c0 0f 85 f2 00 00 00 8b 7c 24 04 31 c0 83 c9 ff <f2> ae f7 d1 49 b0 01 89 ce e8 fa 13 fa ff 8b 04 24 8d 58 38 83
> EIP: [<c016c6a4>] remove_proc_entry+0x2c/0x11c SS:ESP 0068:de4cbf28
>  BUG: rmmod/7735, lock held at task exit time!
>  [df960920] {register_mutex}
> .. held by:             rmmod: 7735 [c1487a90, 118]
> ... acquired at:               snd_pcm_notify+0x10/0x91 [snd_pcm]

Other symptoms are 6 (six) "prealloc" files, 3 "oss" files and 1 "oss"
directory (according to highlighting):

$ ls /proc/asound/
card0  devices  modules  oss  oss  prealloc  prealloc  prealloc  timers
			      ^^^
			      directory

cards  ICH5     oss      oss  pcm  prealloc  prealloc  prealloc  version

"ls -l" thinks all 4 "oss" files are files (again, according to
highlighting).


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: Re: ALSA regression: oops on shutdown
  2006-04-24  1:57   ` Andrew Morton
  (?)
  (?)
@ 2006-04-24 13:00   ` Takashi Iwai
  -1 siblings, 0 replies; 23+ messages in thread
From: Takashi Iwai @ 2006-04-24 13:00 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Alexey Dobriyan, linux-kernel, perex, alsa-devel

At Sun, 23 Apr 2006 18:57:21 -0700,
Andrew Morton wrote:
> 
> Alexey Dobriyan <adobriyan@gmail.com> wrote:
> >
> > ALSA oops I reported against 2.6.16-rc1-mm4 [1] sneaked into mainline
> >  after release.
> 
> One wonders why the ALSA developers merged up which was known to cause
> oopses.

The Oops triggered in rc1 was a different one, and it was my fault.
It happend only with the combination of multiple playback capability
and the kernel OSS emulation, which wasn't tested well (who uses OSS?
:-)

But the bug reported here is a different one, currently occuring only
with mm kernel.  I'll check it later...


Takashi


-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Alsa-devel] Re: ALSA regression: oops on shutdown
  2006-04-24  1:57   ` Andrew Morton
                     ` (2 preceding siblings ...)
  (?)
@ 2006-04-24 13:00   ` Takashi Iwai
  -1 siblings, 0 replies; 23+ messages in thread
From: Takashi Iwai @ 2006-04-24 13:00 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Alexey Dobriyan, linux-kernel, perex, alsa-devel

At Sun, 23 Apr 2006 18:57:21 -0700,
Andrew Morton wrote:
> 
> Alexey Dobriyan <adobriyan@gmail.com> wrote:
> >
> > ALSA oops I reported against 2.6.16-rc1-mm4 [1] sneaked into mainline
> >  after release.
> 
> One wonders why the ALSA developers merged up which was known to cause
> oopses.

The Oops triggered in rc1 was a different one, and it was my fault.
It happend only with the combination of multiple playback capability
and the kernel OSS emulation, which wasn't tested well (who uses OSS?
:-)

But the bug reported here is a different one, currently occuring only
with mm kernel.  I'll check it later...


Takashi

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: Re: ALSA regression: oops on shutdown
  2006-04-24  3:51           ` [Alsa-devel] " Alexey Dobriyan
  (?)
@ 2006-04-24 13:34           ` Takashi Iwai
  -1 siblings, 0 replies; 23+ messages in thread
From: Takashi Iwai @ 2006-04-24 13:34 UTC (permalink / raw)
  To: Alexey Dobriyan
  Cc: Lee Revell, Andrew Morton, linux-kernel, perex, alsa-devel

At Mon, 24 Apr 2006 07:51:44 +0400,
Alexey Dobriyan wrote:
> 
> On Mon, Apr 24, 2006 at 07:11:42AM +0400, Alexey Dobriyan wrote:
> > On Sun, Apr 23, 2006 at 10:39:19PM -0400, Lee Revell wrote:
> >
> > Andrew asked about precise steps of reproduction:
> >
> > 	rmmod snd_pcm_oss
> >
> > which is part of Gentoo install scripts (/etc/init.d/alsasound:134-140, to
> > be precise) (basically lsmod | grep snd | xargs rmmod).
> >
> > BUG: unable to handle kernel paging request at virtual address 6b6b6b6b
> >  printing eip:
> > c016c6a4
> > *pde = 00000000
> > Oops: 0000 [#1]
> > PREEMPT
> > Modules linked in: snd_pcm_oss snd_mixer_oss snd_intel8x0 snd_ac97_codec snd_ac97_bus snd_pcm snd_timer snd soundcore snd_page_alloc ehci_hcd uhci_hcd usbcore
> > CPU:    0
> > EIP:    0060:[<c016c6a4>]    Not tainted VLI
> > EFLAGS: 00010286   (2.6.17-rc2-6b426e785cb81e53dc2fc4dcf997661472b470ef #1)
> > EIP is at remove_proc_entry+0x2c/0x11c
> > eax: 00000000   ebx: deb48b80   ecx: ffffffff   edx: de11ed24
> > esi: de11ed24   edi: 6b6b6b6b   ebp: de4cb000   esp: de4cbf28
> > ds: 007b   es: 007b   ss: 0068
> > Process rmmod (pid: 7735, threadinfo=de4cb000 task=c1487a90)
> > Stack: <0>de11ed24 6b6b6b6b deb48b80 de11ed24 bf8590cc df93603b de4f0e78 00000000
> >        df965fc8 de4f0d84 df967e74 df966184 de4f0d88 df95292d df967f00 00000000
> >        c0125f7a 00000000 5f646e73 5f6d6370 0073736f de85d4a4 b7f27000 c013789d
> > Call Trace:
> >  [<df93603b>] snd_info_unregister+0x2e/0x44 [snd]
> >  [<df965fc8>] snd_pcm_oss_proc_done+0x19/0x30 [snd_pcm_oss]
> >  [<df966184>] snd_pcm_oss_unregister_minor+0x3b/0x3f [snd_pcm_oss]
> >  [<df95292d>] snd_pcm_notify+0x4a/0x91 [snd_pcm]
> >  [<c0125f7a>] sys_delete_module+0x113/0x138
> >  [<c013789d>] do_munmap+0xe2/0xef
> >  [<c010259b>] syscall_call+0x7/0xb
> > Code: 85 d2 56 53 51 51 89 14 24 89 44 24 04 75 13 8d 4c 24 04 89 e2 e8 dd f7 ff ff 85 c0 0f 85 f2 00 00 00 8b 7c 24 04 31 c0 83 c9 ff <f2> ae f7 d1 49 b0 01 89 ce e8 fa 13 fa ff 8b 04 24 8d 58 38 83
> > EIP: [<c016c6a4>] remove_proc_entry+0x2c/0x11c SS:ESP 0068:de4cbf28
> >  BUG: rmmod/7735, lock held at task exit time!
> >  [df960920] {register_mutex}
> > .. held by:             rmmod: 7735 [c1487a90, 118]
> > ... acquired at:               snd_pcm_notify+0x10/0x91 [snd_pcm]
> 
> Other symptoms are 6 (six) "prealloc" files, 3 "oss" files and 1 "oss"
> directory (according to highlighting):
> 
> $ ls /proc/asound/
> card0  devices  modules  oss  oss  prealloc  prealloc  prealloc  timers
> 			      ^^^
> 			      directory
> 
> cards  ICH5     oss      oss  pcm  prealloc  prealloc  prealloc  version
> 
> "ls -l" thinks all 4 "oss" files are files (again, according to
> highlighting).

That's odd.  It implies that the proc file paths are flatten.
The "oss" should appear like:

  /proc/asound/oss/devices
  /proc/asound/oss/sndstat
  /proc/asound/card0/pcm0p/sub0/oss
  /proc/asound/card0/pcm0c/sub0/oss

Any incompatibilites with procfs interface in mm?


Takashi


-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Alsa-devel] Re: ALSA regression: oops on shutdown
  2006-04-24  3:51           ` [Alsa-devel] " Alexey Dobriyan
  (?)
  (?)
@ 2006-04-24 13:34           ` Takashi Iwai
  2006-04-24 14:26             ` Takashi Iwai
  2006-04-24 14:26             ` Takashi Iwai
  -1 siblings, 2 replies; 23+ messages in thread
From: Takashi Iwai @ 2006-04-24 13:34 UTC (permalink / raw)
  To: Alexey Dobriyan
  Cc: Lee Revell, Andrew Morton, linux-kernel, perex, alsa-devel

At Mon, 24 Apr 2006 07:51:44 +0400,
Alexey Dobriyan wrote:
> 
> On Mon, Apr 24, 2006 at 07:11:42AM +0400, Alexey Dobriyan wrote:
> > On Sun, Apr 23, 2006 at 10:39:19PM -0400, Lee Revell wrote:
> >
> > Andrew asked about precise steps of reproduction:
> >
> > 	rmmod snd_pcm_oss
> >
> > which is part of Gentoo install scripts (/etc/init.d/alsasound:134-140, to
> > be precise) (basically lsmod | grep snd | xargs rmmod).
> >
> > BUG: unable to handle kernel paging request at virtual address 6b6b6b6b
> >  printing eip:
> > c016c6a4
> > *pde = 00000000
> > Oops: 0000 [#1]
> > PREEMPT
> > Modules linked in: snd_pcm_oss snd_mixer_oss snd_intel8x0 snd_ac97_codec snd_ac97_bus snd_pcm snd_timer snd soundcore snd_page_alloc ehci_hcd uhci_hcd usbcore
> > CPU:    0
> > EIP:    0060:[<c016c6a4>]    Not tainted VLI
> > EFLAGS: 00010286   (2.6.17-rc2-6b426e785cb81e53dc2fc4dcf997661472b470ef #1)
> > EIP is at remove_proc_entry+0x2c/0x11c
> > eax: 00000000   ebx: deb48b80   ecx: ffffffff   edx: de11ed24
> > esi: de11ed24   edi: 6b6b6b6b   ebp: de4cb000   esp: de4cbf28
> > ds: 007b   es: 007b   ss: 0068
> > Process rmmod (pid: 7735, threadinfo=de4cb000 task=c1487a90)
> > Stack: <0>de11ed24 6b6b6b6b deb48b80 de11ed24 bf8590cc df93603b de4f0e78 00000000
> >        df965fc8 de4f0d84 df967e74 df966184 de4f0d88 df95292d df967f00 00000000
> >        c0125f7a 00000000 5f646e73 5f6d6370 0073736f de85d4a4 b7f27000 c013789d
> > Call Trace:
> >  [<df93603b>] snd_info_unregister+0x2e/0x44 [snd]
> >  [<df965fc8>] snd_pcm_oss_proc_done+0x19/0x30 [snd_pcm_oss]
> >  [<df966184>] snd_pcm_oss_unregister_minor+0x3b/0x3f [snd_pcm_oss]
> >  [<df95292d>] snd_pcm_notify+0x4a/0x91 [snd_pcm]
> >  [<c0125f7a>] sys_delete_module+0x113/0x138
> >  [<c013789d>] do_munmap+0xe2/0xef
> >  [<c010259b>] syscall_call+0x7/0xb
> > Code: 85 d2 56 53 51 51 89 14 24 89 44 24 04 75 13 8d 4c 24 04 89 e2 e8 dd f7 ff ff 85 c0 0f 85 f2 00 00 00 8b 7c 24 04 31 c0 83 c9 ff <f2> ae f7 d1 49 b0 01 89 ce e8 fa 13 fa ff 8b 04 24 8d 58 38 83
> > EIP: [<c016c6a4>] remove_proc_entry+0x2c/0x11c SS:ESP 0068:de4cbf28
> >  BUG: rmmod/7735, lock held at task exit time!
> >  [df960920] {register_mutex}
> > .. held by:             rmmod: 7735 [c1487a90, 118]
> > ... acquired at:               snd_pcm_notify+0x10/0x91 [snd_pcm]
> 
> Other symptoms are 6 (six) "prealloc" files, 3 "oss" files and 1 "oss"
> directory (according to highlighting):
> 
> $ ls /proc/asound/
> card0  devices  modules  oss  oss  prealloc  prealloc  prealloc  timers
> 			      ^^^
> 			      directory
> 
> cards  ICH5     oss      oss  pcm  prealloc  prealloc  prealloc  version
> 
> "ls -l" thinks all 4 "oss" files are files (again, according to
> highlighting).

That's odd.  It implies that the proc file paths are flatten.
The "oss" should appear like:

  /proc/asound/oss/devices
  /proc/asound/oss/sndstat
  /proc/asound/card0/pcm0p/sub0/oss
  /proc/asound/card0/pcm0c/sub0/oss

Any incompatibilites with procfs interface in mm?


Takashi

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: Re: ALSA regression: oops on shutdown
  2006-04-24 13:34           ` [Alsa-devel] " Takashi Iwai
  2006-04-24 14:26             ` Takashi Iwai
@ 2006-04-24 14:26             ` Takashi Iwai
  1 sibling, 0 replies; 23+ messages in thread
From: Takashi Iwai @ 2006-04-24 14:26 UTC (permalink / raw)
  To: Alexey Dobriyan
  Cc: Lee Revell, Andrew Morton, linux-kernel, perex, alsa-devel

At Mon, 24 Apr 2006 15:34:30 +0200,
I wrote:
> 
> At Mon, 24 Apr 2006 07:51:44 +0400,
> Alexey Dobriyan wrote:
> > 
> > On Mon, Apr 24, 2006 at 07:11:42AM +0400, Alexey Dobriyan wrote:
> > > On Sun, Apr 23, 2006 at 10:39:19PM -0400, Lee Revell wrote:
> > >
> > > Andrew asked about precise steps of reproduction:
> > >
> > > 	rmmod snd_pcm_oss
> > >
> > > which is part of Gentoo install scripts (/etc/init.d/alsasound:134-140, to
> > > be precise) (basically lsmod | grep snd | xargs rmmod).
> > >
> > > BUG: unable to handle kernel paging request at virtual address 6b6b6b6b
> > >  printing eip:
> > > c016c6a4
> > > *pde = 00000000
> > > Oops: 0000 [#1]
> > > PREEMPT
> > > Modules linked in: snd_pcm_oss snd_mixer_oss snd_intel8x0 snd_ac97_codec snd_ac97_bus snd_pcm snd_timer snd soundcore snd_page_alloc ehci_hcd uhci_hcd usbcore
> > > CPU:    0
> > > EIP:    0060:[<c016c6a4>]    Not tainted VLI
> > > EFLAGS: 00010286   (2.6.17-rc2-6b426e785cb81e53dc2fc4dcf997661472b470ef #1)
> > > EIP is at remove_proc_entry+0x2c/0x11c
> > > eax: 00000000   ebx: deb48b80   ecx: ffffffff   edx: de11ed24
> > > esi: de11ed24   edi: 6b6b6b6b   ebp: de4cb000   esp: de4cbf28
> > > ds: 007b   es: 007b   ss: 0068
> > > Process rmmod (pid: 7735, threadinfo=de4cb000 task=c1487a90)
> > > Stack: <0>de11ed24 6b6b6b6b deb48b80 de11ed24 bf8590cc df93603b de4f0e78 00000000
> > >        df965fc8 de4f0d84 df967e74 df966184 de4f0d88 df95292d df967f00 00000000
> > >        c0125f7a 00000000 5f646e73 5f6d6370 0073736f de85d4a4 b7f27000 c013789d
> > > Call Trace:
> > >  [<df93603b>] snd_info_unregister+0x2e/0x44 [snd]
> > >  [<df965fc8>] snd_pcm_oss_proc_done+0x19/0x30 [snd_pcm_oss]
> > >  [<df966184>] snd_pcm_oss_unregister_minor+0x3b/0x3f [snd_pcm_oss]
> > >  [<df95292d>] snd_pcm_notify+0x4a/0x91 [snd_pcm]
> > >  [<c0125f7a>] sys_delete_module+0x113/0x138
> > >  [<c013789d>] do_munmap+0xe2/0xef
> > >  [<c010259b>] syscall_call+0x7/0xb
> > > Code: 85 d2 56 53 51 51 89 14 24 89 44 24 04 75 13 8d 4c 24 04 89 e2 e8 dd f7 ff ff 85 c0 0f 85 f2 00 00 00 8b 7c 24 04 31 c0 83 c9 ff <f2> ae f7 d1 49 b0 01 89 ce e8 fa 13 fa ff 8b 04 24 8d 58 38 83
> > > EIP: [<c016c6a4>] remove_proc_entry+0x2c/0x11c SS:ESP 0068:de4cbf28
> > >  BUG: rmmod/7735, lock held at task exit time!
> > >  [df960920] {register_mutex}
> > > .. held by:             rmmod: 7735 [c1487a90, 118]
> > > ... acquired at:               snd_pcm_notify+0x10/0x91 [snd_pcm]
> > 
> > Other symptoms are 6 (six) "prealloc" files, 3 "oss" files and 1 "oss"
> > directory (according to highlighting):
> > 
> > $ ls /proc/asound/
> > card0  devices  modules  oss  oss  prealloc  prealloc  prealloc  timers
> > 			      ^^^
> > 			      directory
> > 
> > cards  ICH5     oss      oss  pcm  prealloc  prealloc  prealloc  version
> > 
> > "ls -l" thinks all 4 "oss" files are files (again, according to
> > highlighting).
> 
> That's odd.  It implies that the proc file paths are flatten.

But, not all entries seem flatten (e.g. pcm0p, sub0, etc).
Could you show the output of "tree /proc/asound" ?


Takashi


-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Alsa-devel] Re: ALSA regression: oops on shutdown
  2006-04-24 13:34           ` [Alsa-devel] " Takashi Iwai
@ 2006-04-24 14:26             ` Takashi Iwai
  2006-04-24 15:30               ` Alexey Dobriyan
  2006-04-24 15:30               ` Alexey Dobriyan
  2006-04-24 14:26             ` Takashi Iwai
  1 sibling, 2 replies; 23+ messages in thread
From: Takashi Iwai @ 2006-04-24 14:26 UTC (permalink / raw)
  To: Alexey Dobriyan
  Cc: Lee Revell, Andrew Morton, linux-kernel, perex, alsa-devel

At Mon, 24 Apr 2006 15:34:30 +0200,
I wrote:
> 
> At Mon, 24 Apr 2006 07:51:44 +0400,
> Alexey Dobriyan wrote:
> > 
> > On Mon, Apr 24, 2006 at 07:11:42AM +0400, Alexey Dobriyan wrote:
> > > On Sun, Apr 23, 2006 at 10:39:19PM -0400, Lee Revell wrote:
> > >
> > > Andrew asked about precise steps of reproduction:
> > >
> > > 	rmmod snd_pcm_oss
> > >
> > > which is part of Gentoo install scripts (/etc/init.d/alsasound:134-140, to
> > > be precise) (basically lsmod | grep snd | xargs rmmod).
> > >
> > > BUG: unable to handle kernel paging request at virtual address 6b6b6b6b
> > >  printing eip:
> > > c016c6a4
> > > *pde = 00000000
> > > Oops: 0000 [#1]
> > > PREEMPT
> > > Modules linked in: snd_pcm_oss snd_mixer_oss snd_intel8x0 snd_ac97_codec snd_ac97_bus snd_pcm snd_timer snd soundcore snd_page_alloc ehci_hcd uhci_hcd usbcore
> > > CPU:    0
> > > EIP:    0060:[<c016c6a4>]    Not tainted VLI
> > > EFLAGS: 00010286   (2.6.17-rc2-6b426e785cb81e53dc2fc4dcf997661472b470ef #1)
> > > EIP is at remove_proc_entry+0x2c/0x11c
> > > eax: 00000000   ebx: deb48b80   ecx: ffffffff   edx: de11ed24
> > > esi: de11ed24   edi: 6b6b6b6b   ebp: de4cb000   esp: de4cbf28
> > > ds: 007b   es: 007b   ss: 0068
> > > Process rmmod (pid: 7735, threadinfo=de4cb000 task=c1487a90)
> > > Stack: <0>de11ed24 6b6b6b6b deb48b80 de11ed24 bf8590cc df93603b de4f0e78 00000000
> > >        df965fc8 de4f0d84 df967e74 df966184 de4f0d88 df95292d df967f00 00000000
> > >        c0125f7a 00000000 5f646e73 5f6d6370 0073736f de85d4a4 b7f27000 c013789d
> > > Call Trace:
> > >  [<df93603b>] snd_info_unregister+0x2e/0x44 [snd]
> > >  [<df965fc8>] snd_pcm_oss_proc_done+0x19/0x30 [snd_pcm_oss]
> > >  [<df966184>] snd_pcm_oss_unregister_minor+0x3b/0x3f [snd_pcm_oss]
> > >  [<df95292d>] snd_pcm_notify+0x4a/0x91 [snd_pcm]
> > >  [<c0125f7a>] sys_delete_module+0x113/0x138
> > >  [<c013789d>] do_munmap+0xe2/0xef
> > >  [<c010259b>] syscall_call+0x7/0xb
> > > Code: 85 d2 56 53 51 51 89 14 24 89 44 24 04 75 13 8d 4c 24 04 89 e2 e8 dd f7 ff ff 85 c0 0f 85 f2 00 00 00 8b 7c 24 04 31 c0 83 c9 ff <f2> ae f7 d1 49 b0 01 89 ce e8 fa 13 fa ff 8b 04 24 8d 58 38 83
> > > EIP: [<c016c6a4>] remove_proc_entry+0x2c/0x11c SS:ESP 0068:de4cbf28
> > >  BUG: rmmod/7735, lock held at task exit time!
> > >  [df960920] {register_mutex}
> > > .. held by:             rmmod: 7735 [c1487a90, 118]
> > > ... acquired at:               snd_pcm_notify+0x10/0x91 [snd_pcm]
> > 
> > Other symptoms are 6 (six) "prealloc" files, 3 "oss" files and 1 "oss"
> > directory (according to highlighting):
> > 
> > $ ls /proc/asound/
> > card0  devices  modules  oss  oss  prealloc  prealloc  prealloc  timers
> > 			      ^^^
> > 			      directory
> > 
> > cards  ICH5     oss      oss  pcm  prealloc  prealloc  prealloc  version
> > 
> > "ls -l" thinks all 4 "oss" files are files (again, according to
> > highlighting).
> 
> That's odd.  It implies that the proc file paths are flatten.

But, not all entries seem flatten (e.g. pcm0p, sub0, etc).
Could you show the output of "tree /proc/asound" ?


Takashi

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: Re: ALSA regression: oops on shutdown
  2006-04-24 14:26             ` Takashi Iwai
  2006-04-24 15:30               ` Alexey Dobriyan
@ 2006-04-24 15:30               ` Alexey Dobriyan
  1 sibling, 0 replies; 23+ messages in thread
From: Alexey Dobriyan @ 2006-04-24 15:30 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: Lee Revell, Andrew Morton, linux-kernel, perex, alsa-devel

On Mon, Apr 24, 2006 at 04:26:10PM +0200, Takashi Iwai wrote:
> At Mon, 24 Apr 2006 15:34:30 +0200,
> I wrote:
> > 
> > At Mon, 24 Apr 2006 07:51:44 +0400,
> > Alexey Dobriyan wrote:
> > > 
> > > On Mon, Apr 24, 2006 at 07:11:42AM +0400, Alexey Dobriyan wrote:
> > > > On Sun, Apr 23, 2006 at 10:39:19PM -0400, Lee Revell wrote:
> > > >
> > > > Andrew asked about precise steps of reproduction:
> > > >
> > > > 	rmmod snd_pcm_oss
> > > >
> > > > which is part of Gentoo install scripts (/etc/init.d/alsasound:134-140, to
> > > > be precise) (basically lsmod | grep snd | xargs rmmod).
> > > >
> > > > BUG: unable to handle kernel paging request at virtual address 6b6b6b6b
> > > >  printing eip:
> > > > c016c6a4
> > > > *pde = 00000000
> > > > Oops: 0000 [#1]
> > > > PREEMPT
> > > > Modules linked in: snd_pcm_oss snd_mixer_oss snd_intel8x0 snd_ac97_codec snd_ac97_bus snd_pcm snd_timer snd soundcore snd_page_alloc ehci_hcd uhci_hcd usbcore
> > > > CPU:    0
> > > > EIP:    0060:[<c016c6a4>]    Not tainted VLI
> > > > EFLAGS: 00010286   (2.6.17-rc2-6b426e785cb81e53dc2fc4dcf997661472b470ef #1)
> > > > EIP is at remove_proc_entry+0x2c/0x11c
> > > > eax: 00000000   ebx: deb48b80   ecx: ffffffff   edx: de11ed24
> > > > esi: de11ed24   edi: 6b6b6b6b   ebp: de4cb000   esp: de4cbf28
> > > > ds: 007b   es: 007b   ss: 0068
> > > > Process rmmod (pid: 7735, threadinfo=de4cb000 task=c1487a90)
> > > > Stack: <0>de11ed24 6b6b6b6b deb48b80 de11ed24 bf8590cc df93603b de4f0e78 00000000
> > > >        df965fc8 de4f0d84 df967e74 df966184 de4f0d88 df95292d df967f00 00000000
> > > >        c0125f7a 00000000 5f646e73 5f6d6370 0073736f de85d4a4 b7f27000 c013789d
> > > > Call Trace:
> > > >  [<df93603b>] snd_info_unregister+0x2e/0x44 [snd]
> > > >  [<df965fc8>] snd_pcm_oss_proc_done+0x19/0x30 [snd_pcm_oss]
> > > >  [<df966184>] snd_pcm_oss_unregister_minor+0x3b/0x3f [snd_pcm_oss]
> > > >  [<df95292d>] snd_pcm_notify+0x4a/0x91 [snd_pcm]
> > > >  [<c0125f7a>] sys_delete_module+0x113/0x138
> > > >  [<c013789d>] do_munmap+0xe2/0xef
> > > >  [<c010259b>] syscall_call+0x7/0xb
> > > > Code: 85 d2 56 53 51 51 89 14 24 89 44 24 04 75 13 8d 4c 24 04 89 e2 e8 dd f7 ff ff 85 c0 0f 85 f2 00 00 00 8b 7c 24 04 31 c0 83 c9 ff <f2> ae f7 d1 49 b0 01 89 ce e8 fa 13 fa ff 8b 04 24 8d 58 38 83
> > > > EIP: [<c016c6a4>] remove_proc_entry+0x2c/0x11c SS:ESP 0068:de4cbf28
> > > >  BUG: rmmod/7735, lock held at task exit time!
> > > >  [df960920] {register_mutex}
> > > > .. held by:             rmmod: 7735 [c1487a90, 118]
> > > > ... acquired at:               snd_pcm_notify+0x10/0x91 [snd_pcm]
> > >
> > > Other symptoms are 6 (six) "prealloc" files, 3 "oss" files and 1 "oss"
> > > directory (according to highlighting):
> > >
> > > $ ls /proc/asound/
> > > card0  devices  modules  oss  oss  prealloc  prealloc  prealloc  timers
> > > 			      ^^^
> > > 			      directory
> > >
> > > cards  ICH5     oss      oss  pcm  prealloc  prealloc  prealloc  version
> > >
> > > "ls -l" thinks all 4 "oss" files are files (again, according to
> > > highlighting).
> >
> > That's odd.  It implies that the proc file paths are flatten.
>
> But, not all entries seem flatten (e.g. pcm0p, sub0, etc).
> Could you show the output of "tree /proc/asound" ?

2.6.16 (good)			2.6.17-rc2-whatever (bad)
---------------------------------------------------------
/proc/asound/			/proc/asound/
|-- ICH5 -> card0		|-- ICH5 -> card0
|-- card0			|-- card0
|   |-- codec97#0		|   |-- codec97#0
|   |   |-- ac97#0-0		|   |   |-- ac97#0-0
|   |   `-- ac97#0-0+regs	|   |   `-- ac97#0-0+regs
|   |-- id			|   |-- id
|   |-- intel8x0		|   |-- intel8x0
|   |-- oss_mixer		|   `-- oss_mixer
|   |-- pcm0c			|-- cards
|   |   |-- info		|-- devices
|   |   |-- oss			|-- modules
|   |   `-- sub0		|-- oss
|   |       |-- hw_params	|-- oss
|   |       |-- info		|-- oss
|   |       |-- prealloc	|-- oss
|   |       |-- status		|-- pcm
|   |       `-- sw_params	|-- prealloc
|   |-- pcm0p			|-- prealloc
|   |   |-- info		|-- prealloc
|   |   |-- oss			|-- prealloc
|   |   `-- sub0		|-- prealloc
|   |       |-- hw_params	|-- prealloc
|   |       |-- info		|-- timers
|   |       |-- prealloc	`-- version
|   |       |-- status
|   |       `-- sw_params	3 directories, 21 files
|   |-- pcm1c
|   |   |-- info
|   |   |-- oss
|   |   `-- sub0
|   |       |-- hw_params
|   |       |-- info
|   |       |-- prealloc
|   |       |-- status
|   |       `-- sw_params
|   |-- pcm2c
|   |   |-- info
|   |   `-- sub0
|   |       |-- hw_params
|   |       |-- info
|   |       |-- prealloc
|   |       |-- status
|   |       `-- sw_params
|   |-- pcm3c
|   |   |-- info
|   |   `-- sub0
|   |       |-- hw_params
|   |       |-- info
|   |       |-- prealloc
|   |       |-- status
|   |       `-- sw_params
|   `-- pcm4p
|       |-- info
|       `-- sub0
|           |-- hw_params
|           |-- info
|           |-- prealloc
|           |-- status
|           `-- sw_params
|-- cards
|-- devices
|-- modules
|-- oss
|   |-- devices
|   `-- sndstat
|-- pcm
|-- timers
`-- version

16 directories, 52 files



-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Alsa-devel] Re: ALSA regression: oops on shutdown
  2006-04-24 14:26             ` Takashi Iwai
@ 2006-04-24 15:30               ` Alexey Dobriyan
  2006-04-24 16:34                   ` [Alsa-devel] " Takashi Iwai
  2006-04-24 15:30               ` Alexey Dobriyan
  1 sibling, 1 reply; 23+ messages in thread
From: Alexey Dobriyan @ 2006-04-24 15:30 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: Lee Revell, Andrew Morton, linux-kernel, perex, alsa-devel

On Mon, Apr 24, 2006 at 04:26:10PM +0200, Takashi Iwai wrote:
> At Mon, 24 Apr 2006 15:34:30 +0200,
> I wrote:
> > 
> > At Mon, 24 Apr 2006 07:51:44 +0400,
> > Alexey Dobriyan wrote:
> > > 
> > > On Mon, Apr 24, 2006 at 07:11:42AM +0400, Alexey Dobriyan wrote:
> > > > On Sun, Apr 23, 2006 at 10:39:19PM -0400, Lee Revell wrote:
> > > >
> > > > Andrew asked about precise steps of reproduction:
> > > >
> > > > 	rmmod snd_pcm_oss
> > > >
> > > > which is part of Gentoo install scripts (/etc/init.d/alsasound:134-140, to
> > > > be precise) (basically lsmod | grep snd | xargs rmmod).
> > > >
> > > > BUG: unable to handle kernel paging request at virtual address 6b6b6b6b
> > > >  printing eip:
> > > > c016c6a4
> > > > *pde = 00000000
> > > > Oops: 0000 [#1]
> > > > PREEMPT
> > > > Modules linked in: snd_pcm_oss snd_mixer_oss snd_intel8x0 snd_ac97_codec snd_ac97_bus snd_pcm snd_timer snd soundcore snd_page_alloc ehci_hcd uhci_hcd usbcore
> > > > CPU:    0
> > > > EIP:    0060:[<c016c6a4>]    Not tainted VLI
> > > > EFLAGS: 00010286   (2.6.17-rc2-6b426e785cb81e53dc2fc4dcf997661472b470ef #1)
> > > > EIP is at remove_proc_entry+0x2c/0x11c
> > > > eax: 00000000   ebx: deb48b80   ecx: ffffffff   edx: de11ed24
> > > > esi: de11ed24   edi: 6b6b6b6b   ebp: de4cb000   esp: de4cbf28
> > > > ds: 007b   es: 007b   ss: 0068
> > > > Process rmmod (pid: 7735, threadinfo=de4cb000 task=c1487a90)
> > > > Stack: <0>de11ed24 6b6b6b6b deb48b80 de11ed24 bf8590cc df93603b de4f0e78 00000000
> > > >        df965fc8 de4f0d84 df967e74 df966184 de4f0d88 df95292d df967f00 00000000
> > > >        c0125f7a 00000000 5f646e73 5f6d6370 0073736f de85d4a4 b7f27000 c013789d
> > > > Call Trace:
> > > >  [<df93603b>] snd_info_unregister+0x2e/0x44 [snd]
> > > >  [<df965fc8>] snd_pcm_oss_proc_done+0x19/0x30 [snd_pcm_oss]
> > > >  [<df966184>] snd_pcm_oss_unregister_minor+0x3b/0x3f [snd_pcm_oss]
> > > >  [<df95292d>] snd_pcm_notify+0x4a/0x91 [snd_pcm]
> > > >  [<c0125f7a>] sys_delete_module+0x113/0x138
> > > >  [<c013789d>] do_munmap+0xe2/0xef
> > > >  [<c010259b>] syscall_call+0x7/0xb
> > > > Code: 85 d2 56 53 51 51 89 14 24 89 44 24 04 75 13 8d 4c 24 04 89 e2 e8 dd f7 ff ff 85 c0 0f 85 f2 00 00 00 8b 7c 24 04 31 c0 83 c9 ff <f2> ae f7 d1 49 b0 01 89 ce e8 fa 13 fa ff 8b 04 24 8d 58 38 83
> > > > EIP: [<c016c6a4>] remove_proc_entry+0x2c/0x11c SS:ESP 0068:de4cbf28
> > > >  BUG: rmmod/7735, lock held at task exit time!
> > > >  [df960920] {register_mutex}
> > > > .. held by:             rmmod: 7735 [c1487a90, 118]
> > > > ... acquired at:               snd_pcm_notify+0x10/0x91 [snd_pcm]
> > >
> > > Other symptoms are 6 (six) "prealloc" files, 3 "oss" files and 1 "oss"
> > > directory (according to highlighting):
> > >
> > > $ ls /proc/asound/
> > > card0  devices  modules  oss  oss  prealloc  prealloc  prealloc  timers
> > > 			      ^^^
> > > 			      directory
> > >
> > > cards  ICH5     oss      oss  pcm  prealloc  prealloc  prealloc  version
> > >
> > > "ls -l" thinks all 4 "oss" files are files (again, according to
> > > highlighting).
> >
> > That's odd.  It implies that the proc file paths are flatten.
>
> But, not all entries seem flatten (e.g. pcm0p, sub0, etc).
> Could you show the output of "tree /proc/asound" ?

2.6.16 (good)			2.6.17-rc2-whatever (bad)
---------------------------------------------------------
/proc/asound/			/proc/asound/
|-- ICH5 -> card0		|-- ICH5 -> card0
|-- card0			|-- card0
|   |-- codec97#0		|   |-- codec97#0
|   |   |-- ac97#0-0		|   |   |-- ac97#0-0
|   |   `-- ac97#0-0+regs	|   |   `-- ac97#0-0+regs
|   |-- id			|   |-- id
|   |-- intel8x0		|   |-- intel8x0
|   |-- oss_mixer		|   `-- oss_mixer
|   |-- pcm0c			|-- cards
|   |   |-- info		|-- devices
|   |   |-- oss			|-- modules
|   |   `-- sub0		|-- oss
|   |       |-- hw_params	|-- oss
|   |       |-- info		|-- oss
|   |       |-- prealloc	|-- oss
|   |       |-- status		|-- pcm
|   |       `-- sw_params	|-- prealloc
|   |-- pcm0p			|-- prealloc
|   |   |-- info		|-- prealloc
|   |   |-- oss			|-- prealloc
|   |   `-- sub0		|-- prealloc
|   |       |-- hw_params	|-- prealloc
|   |       |-- info		|-- timers
|   |       |-- prealloc	`-- version
|   |       |-- status
|   |       `-- sw_params	3 directories, 21 files
|   |-- pcm1c
|   |   |-- info
|   |   |-- oss
|   |   `-- sub0
|   |       |-- hw_params
|   |       |-- info
|   |       |-- prealloc
|   |       |-- status
|   |       `-- sw_params
|   |-- pcm2c
|   |   |-- info
|   |   `-- sub0
|   |       |-- hw_params
|   |       |-- info
|   |       |-- prealloc
|   |       |-- status
|   |       `-- sw_params
|   |-- pcm3c
|   |   |-- info
|   |   `-- sub0
|   |       |-- hw_params
|   |       |-- info
|   |       |-- prealloc
|   |       |-- status
|   |       `-- sw_params
|   `-- pcm4p
|       |-- info
|       `-- sub0
|           |-- hw_params
|           |-- info
|           |-- prealloc
|           |-- status
|           `-- sw_params
|-- cards
|-- devices
|-- modules
|-- oss
|   |-- devices
|   `-- sndstat
|-- pcm
|-- timers
`-- version

16 directories, 52 files


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: Re: ALSA regression: oops on shutdown
  2006-04-24 15:30               ` Alexey Dobriyan
@ 2006-04-24 16:34                   ` Takashi Iwai
  0 siblings, 0 replies; 23+ messages in thread
From: Takashi Iwai @ 2006-04-24 16:34 UTC (permalink / raw)
  To: Alexey Dobriyan
  Cc: Lee Revell, Andrew Morton, linux-kernel, perex, alsa-devel

At Mon, 24 Apr 2006 19:30:33 +0400,
Alexey Dobriyan wrote:
> 
> On Mon, Apr 24, 2006 at 04:26:10PM +0200, Takashi Iwai wrote:
> > At Mon, 24 Apr 2006 15:34:30 +0200,
> > I wrote:
> > > 
> > > At Mon, 24 Apr 2006 07:51:44 +0400,
> > > Alexey Dobriyan wrote:
> > > > 
> > > > On Mon, Apr 24, 2006 at 07:11:42AM +0400, Alexey Dobriyan wrote:
> > > > > On Sun, Apr 23, 2006 at 10:39:19PM -0400, Lee Revell wrote:
> > > > >
> > > > > Andrew asked about precise steps of reproduction:
> > > > >
> > > > > 	rmmod snd_pcm_oss
> > > > >
> > > > > which is part of Gentoo install scripts (/etc/init.d/alsasound:134-140, to
> > > > > be precise) (basically lsmod | grep snd | xargs rmmod).
> > > > >
> > > > > BUG: unable to handle kernel paging request at virtual address 6b6b6b6b
> > > > >  printing eip:
> > > > > c016c6a4
> > > > > *pde = 00000000
> > > > > Oops: 0000 [#1]
> > > > > PREEMPT
> > > > > Modules linked in: snd_pcm_oss snd_mixer_oss snd_intel8x0 snd_ac97_codec snd_ac97_bus snd_pcm snd_timer snd soundcore snd_page_alloc ehci_hcd uhci_hcd usbcore
> > > > > CPU:    0
> > > > > EIP:    0060:[<c016c6a4>]    Not tainted VLI
> > > > > EFLAGS: 00010286   (2.6.17-rc2-6b426e785cb81e53dc2fc4dcf997661472b470ef #1)
> > > > > EIP is at remove_proc_entry+0x2c/0x11c
> > > > > eax: 00000000   ebx: deb48b80   ecx: ffffffff   edx: de11ed24
> > > > > esi: de11ed24   edi: 6b6b6b6b   ebp: de4cb000   esp: de4cbf28
> > > > > ds: 007b   es: 007b   ss: 0068
> > > > > Process rmmod (pid: 7735, threadinfo=de4cb000 task=c1487a90)
> > > > > Stack: <0>de11ed24 6b6b6b6b deb48b80 de11ed24 bf8590cc df93603b de4f0e78 00000000
> > > > >        df965fc8 de4f0d84 df967e74 df966184 de4f0d88 df95292d df967f00 00000000
> > > > >        c0125f7a 00000000 5f646e73 5f6d6370 0073736f de85d4a4 b7f27000 c013789d
> > > > > Call Trace:
> > > > >  [<df93603b>] snd_info_unregister+0x2e/0x44 [snd]
> > > > >  [<df965fc8>] snd_pcm_oss_proc_done+0x19/0x30 [snd_pcm_oss]
> > > > >  [<df966184>] snd_pcm_oss_unregister_minor+0x3b/0x3f [snd_pcm_oss]
> > > > >  [<df95292d>] snd_pcm_notify+0x4a/0x91 [snd_pcm]
> > > > >  [<c0125f7a>] sys_delete_module+0x113/0x138
> > > > >  [<c013789d>] do_munmap+0xe2/0xef
> > > > >  [<c010259b>] syscall_call+0x7/0xb
> > > > > Code: 85 d2 56 53 51 51 89 14 24 89 44 24 04 75 13 8d 4c 24 04 89 e2 e8 dd f7 ff ff 85 c0 0f 85 f2 00 00 00 8b 7c 24 04 31 c0 83 c9 ff <f2> ae f7 d1 49 b0 01 89 ce e8 fa 13 fa ff 8b 04 24 8d 58 38 83
> > > > > EIP: [<c016c6a4>] remove_proc_entry+0x2c/0x11c SS:ESP 0068:de4cbf28
> > > > >  BUG: rmmod/7735, lock held at task exit time!
> > > > >  [df960920] {register_mutex}
> > > > > .. held by:             rmmod: 7735 [c1487a90, 118]
> > > > > ... acquired at:               snd_pcm_notify+0x10/0x91 [snd_pcm]
> > > >
> > > > Other symptoms are 6 (six) "prealloc" files, 3 "oss" files and 1 "oss"
> > > > directory (according to highlighting):
> > > >
> > > > $ ls /proc/asound/
> > > > card0  devices  modules  oss  oss  prealloc  prealloc  prealloc  timers
> > > > 			      ^^^
> > > > 			      directory
> > > >
> > > > cards  ICH5     oss      oss  pcm  prealloc  prealloc  prealloc  version
> > > >
> > > > "ls -l" thinks all 4 "oss" files are files (again, according to
> > > > highlighting).
> > >
> > > That's odd.  It implies that the proc file paths are flatten.
> >
> > But, not all entries seem flatten (e.g. pcm0p, sub0, etc).
> > Could you show the output of "tree /proc/asound" ?
> 
> 2.6.16 (good)			2.6.17-rc2-whatever (bad)
> ---------------------------------------------------------
> /proc/asound/			/proc/asound/
> |-- ICH5 -> card0		|-- ICH5 -> card0
> |-- card0			|-- card0
> |   |-- codec97#0		|   |-- codec97#0
> |   |   |-- ac97#0-0		|   |   |-- ac97#0-0
> |   |   `-- ac97#0-0+regs	|   |   `-- ac97#0-0+regs
> |   |-- id			|   |-- id
> |   |-- intel8x0		|   |-- intel8x0
> |   |-- oss_mixer		|   `-- oss_mixer
> |   |-- pcm0c			|-- cards
> |   |   |-- info		|-- devices
> |   |   |-- oss			|-- modules
> |   |   `-- sub0		|-- oss
> |   |       |-- hw_params	|-- oss
> |   |       |-- info		|-- oss
> |   |       |-- prealloc	|-- oss
> |   |       |-- status		|-- pcm
> |   |       `-- sw_params	|-- prealloc
> |   |-- pcm0p			|-- prealloc
> |   |   |-- info		|-- prealloc
> |   |   |-- oss			|-- prealloc
> |   |   `-- sub0		|-- prealloc
> |   |       |-- hw_params	|-- prealloc
> |   |       |-- info		|-- timers
> |   |       |-- prealloc	`-- version
> |   |       |-- status
> |   |       `-- sw_params	3 directories, 21 files
> |   |-- pcm1c
> |   |   |-- info
> |   |   |-- oss
> |   |   `-- sub0
> |   |       |-- hw_params
> |   |       |-- info
> |   |       |-- prealloc
> |   |       |-- status
> |   |       `-- sw_params
> |   |-- pcm2c
> |   |   |-- info
> |   |   `-- sub0
> |   |       |-- hw_params
> |   |       |-- info
> |   |       |-- prealloc
> |   |       |-- status
> |   |       `-- sw_params
> |   |-- pcm3c
> |   |   |-- info
> |   |   `-- sub0
> |   |       |-- hw_params
> |   |       |-- info
> |   |       |-- prealloc
> |   |       |-- status
> |   |       `-- sw_params
> |   `-- pcm4p
> |       |-- info
> |       `-- sub0
> |           |-- hw_params
> |           |-- info
> |           |-- prealloc
> |           |-- status
> |           `-- sw_params
> |-- cards
> |-- devices
> |-- modules
> |-- oss
> |   |-- devices
> |   `-- sndstat
> |-- pcm
> |-- timers
> `-- version
> 
> 16 directories, 52 files

Thanks.  I think I got the culprit.  It's a patch introducing
CONFIG_SND_VERBOSE_PROCFS option.

Try the patch below.


Takashi

diff --git a/include/sound/pcm.h b/include/sound/pcm.h
index df70e75..9796bc0 100644
--- a/include/sound/pcm.h
+++ b/include/sound/pcm.h
@@ -374,12 +374,14 @@ struct snd_pcm_substream {
 	/* -- OSS things -- */
 	struct snd_pcm_oss_substream oss;
 #endif
+#ifdef CONFIG_SND_VERBOSE_PROCFS
 	struct snd_info_entry *proc_root;
 	struct snd_info_entry *proc_info_entry;
 	struct snd_info_entry *proc_hw_params_entry;
 	struct snd_info_entry *proc_sw_params_entry;
 	struct snd_info_entry *proc_status_entry;
 	struct snd_info_entry *proc_prealloc_entry;
+#endif
 	/* misc flags */
 	unsigned int no_mmap_ctrl: 1;
 	unsigned int hw_opened: 1;
@@ -400,12 +402,14 @@ struct snd_pcm_str {
 	struct snd_pcm_oss_stream oss;
 #endif
 	struct snd_pcm_file *files;
+#ifdef CONFIG_SND_VERBOSE_PROCFS
 	struct snd_info_entry *proc_root;
 	struct snd_info_entry *proc_info_entry;
 #ifdef CONFIG_SND_DEBUG
 	unsigned int xrun_debug;	/* 0 = disabled, 1 = verbose, 2 = stacktrace */
 	struct snd_info_entry *proc_xrun_debug_entry;
 #endif
+#endif
 };
 
 struct snd_pcm {
diff --git a/include/sound/pcm_oss.h b/include/sound/pcm_oss.h
index 39df2ba..c854647 100644
--- a/include/sound/pcm_oss.h
+++ b/include/sound/pcm_oss.h
@@ -75,7 +75,9 @@ struct snd_pcm_oss_substream {
 struct snd_pcm_oss_stream {
 	struct snd_pcm_oss_setup *setup_list;	/* setup list */
 	struct mutex setup_mutex;
+#ifdef CONFIG_SND_VERBOSE_PROCFS
 	struct snd_info_entry *proc_entry;
+#endif
 };
 
 struct snd_pcm_oss {
diff --git a/sound/core/Kconfig b/sound/core/Kconfig
index 8efc1b1..44015a8 100644
--- a/sound/core/Kconfig
+++ b/sound/core/Kconfig
@@ -142,7 +142,7 @@ config SND_SUPPORT_OLD_API
 
 config SND_VERBOSE_PROCFS
 	bool "Verbose procfs contents"
-	depends on SND
+	depends on SND && PROC_FS
 	default y
 	help
 	  Say Y here to include code for verbose procfs contents (provides
diff --git a/sound/core/oss/pcm_oss.c b/sound/core/oss/pcm_oss.c
index c5978d6..817b727 100644
--- a/sound/core/oss/pcm_oss.c
+++ b/sound/core/oss/pcm_oss.c
@@ -2212,7 +2212,7 @@ static int snd_pcm_oss_mmap(struct file 
 	return 0;
 }
 
-#ifdef CONFIG_PROC_FS
+#ifdef CONFIG_SND_VERBOSE_PROCFS
 /*
  *  /proc interface
  */
@@ -2366,10 +2366,10 @@ static void snd_pcm_oss_proc_done(struct
 		}
 	}
 }
-#else /* !CONFIG_PROC_FS */
+#else /* !CONFIG_SND_VERBOSE_PROCFS */
 #define snd_pcm_oss_proc_init(pcm)
 #define snd_pcm_oss_proc_done(pcm)
-#endif /* CONFIG_PROC_FS */
+#endif /* CONFIG_SND_VERBOSE_PROCFS */
 
 /*
  *  ENTRY functions
diff --git a/sound/core/pcm.c b/sound/core/pcm.c
index 122e10a..d8c6d7f 100644
--- a/sound/core/pcm.c
+++ b/sound/core/pcm.c
@@ -142,7 +142,7 @@ static int snd_pcm_control_ioctl(struct 
 	return -ENOIOCTLCMD;
 }
 
-#if defined(CONFIG_PROC_FS) && defined(CONFIG_SND_VERBOSE_PROCFS)
+#ifdef CONFIG_SND_VERBOSE_PROCFS
 
 #define STATE(v) [SNDRV_PCM_STATE_##v] = #v
 #define STREAM(v) [SNDRV_PCM_STREAM_##v] = #v
@@ -599,12 +599,12 @@ static int snd_pcm_substream_proc_done(s
 	}
 	return 0;
 }
-#else /* !CONFIG_PROC_FS */
+#else /* !CONFIG_SND_VERBOSE_PROCFS */
 static inline int snd_pcm_stream_proc_init(struct snd_pcm_str *pstr) { return 0; }
 static inline int snd_pcm_stream_proc_done(struct snd_pcm_str *pstr) { return 0; }
 static inline int snd_pcm_substream_proc_init(struct snd_pcm_substream *substream) { return 0; }
 static inline int snd_pcm_substream_proc_done(struct snd_pcm_substream *substream) { return 0; }
-#endif /* CONFIG_PROC_FS */
+#endif /* CONFIG_SND_VERBOSE_PROCFS */
 
 /**
  * snd_pcm_new_stream - create a new PCM stream
diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c
index 230a940..91fe5d0 100644
--- a/sound/core/pcm_lib.c
+++ b/sound/core/pcm_lib.c
@@ -130,7 +130,7 @@ void snd_pcm_playback_silence(struct snd
 static void xrun(struct snd_pcm_substream *substream)
 {
 	snd_pcm_stop(substream, SNDRV_PCM_STATE_XRUN);
-#ifdef CONFIG_SND_DEBUG
+#if defined(CONFIG_SND_DEBUG) && defined(CONFIG_SND_VERBOSE_PROCFS)
 	if (substream->pstr->xrun_debug) {
 		snd_printd(KERN_DEBUG "XRUN: pcmC%dD%d%c\n",
 			   substream->pcm->card->number,
@@ -204,7 +204,7 @@ static inline int snd_pcm_update_hw_ptr_
 	delta = hw_ptr_interrupt - new_hw_ptr;
 	if (delta > 0) {
 		if ((snd_pcm_uframes_t)delta < runtime->buffer_size / 2) {
-#ifdef CONFIG_SND_DEBUG
+#if defined(CONFIG_SND_DEBUG) && defined(CONFIG_SND_VERBOSE_PROCFS)
 			if (runtime->periods > 1 && substream->pstr->xrun_debug) {
 				snd_printd(KERN_ERR "Unexpected hw_pointer value [1] (stream = %i, delta: -%ld, max jitter = %ld): wrong interrupt acknowledge?\n", substream->stream, (long) delta, runtime->buffer_size / 2);
 				if (substream->pstr->xrun_debug > 1)
@@ -249,7 +249,7 @@ int snd_pcm_update_hw_ptr(struct snd_pcm
 	delta = old_hw_ptr - new_hw_ptr;
 	if (delta > 0) {
 		if ((snd_pcm_uframes_t)delta < runtime->buffer_size / 2) {
-#ifdef CONFIG_SND_DEBUG
+#if defined(CONFIG_SND_DEBUG) && defined(CONFIG_SND_VERBOSE_PROCFS)
 			if (runtime->periods > 2 && substream->pstr->xrun_debug) {
 				snd_printd(KERN_ERR "Unexpected hw_pointer value [2] (stream = %i, delta: -%ld, max jitter = %ld): wrong interrupt acknowledge?\n", substream->stream, (long) delta, runtime->buffer_size / 2);
 				if (substream->pstr->xrun_debug > 1)
diff --git a/sound/core/pcm_memory.c b/sound/core/pcm_memory.c
index a0119ae..428f8c1 100644
--- a/sound/core/pcm_memory.c
+++ b/sound/core/pcm_memory.c
@@ -100,8 +100,10 @@ static void snd_pcm_lib_preallocate_dma_
 int snd_pcm_lib_preallocate_free(struct snd_pcm_substream *substream)
 {
 	snd_pcm_lib_preallocate_dma_free(substream);
+#ifdef CONFIG_SND_VERBOSE_PROCFS
 	snd_info_unregister(substream->proc_prealloc_entry);
 	substream->proc_prealloc_entry = NULL;
+#endif
 	return 0;
 }
 
@@ -124,7 +126,7 @@ int snd_pcm_lib_preallocate_free_for_all
 	return 0;
 }
 
-#ifdef CONFIG_PROC_FS
+#ifdef CONFIG_SND_VERBOSE_PROCFS
 /*
  * read callback for prealloc proc file
  *
@@ -203,9 +205,9 @@ static inline void preallocate_info_init
 	substream->proc_prealloc_entry = entry;
 }
 
-#else /* !CONFIG_PROC_FS */
+#else /* !CONFIG_SND_VERBOSE_PROCFS */
 #define preallocate_info_init(s)
-#endif
+#endif /* CONFIG_SND_VERBOSE_PROCFS */
 
 /*
  * pre-allocate the buffer and create a proc file for the substream


-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

^ permalink raw reply related	[flat|nested] 23+ messages in thread

* Re: [Alsa-devel] Re: ALSA regression: oops on shutdown
@ 2006-04-24 16:34                   ` Takashi Iwai
  0 siblings, 0 replies; 23+ messages in thread
From: Takashi Iwai @ 2006-04-24 16:34 UTC (permalink / raw)
  To: Alexey Dobriyan
  Cc: Lee Revell, Andrew Morton, linux-kernel, perex, alsa-devel

At Mon, 24 Apr 2006 19:30:33 +0400,
Alexey Dobriyan wrote:
> 
> On Mon, Apr 24, 2006 at 04:26:10PM +0200, Takashi Iwai wrote:
> > At Mon, 24 Apr 2006 15:34:30 +0200,
> > I wrote:
> > > 
> > > At Mon, 24 Apr 2006 07:51:44 +0400,
> > > Alexey Dobriyan wrote:
> > > > 
> > > > On Mon, Apr 24, 2006 at 07:11:42AM +0400, Alexey Dobriyan wrote:
> > > > > On Sun, Apr 23, 2006 at 10:39:19PM -0400, Lee Revell wrote:
> > > > >
> > > > > Andrew asked about precise steps of reproduction:
> > > > >
> > > > > 	rmmod snd_pcm_oss
> > > > >
> > > > > which is part of Gentoo install scripts (/etc/init.d/alsasound:134-140, to
> > > > > be precise) (basically lsmod | grep snd | xargs rmmod).
> > > > >
> > > > > BUG: unable to handle kernel paging request at virtual address 6b6b6b6b
> > > > >  printing eip:
> > > > > c016c6a4
> > > > > *pde = 00000000
> > > > > Oops: 0000 [#1]
> > > > > PREEMPT
> > > > > Modules linked in: snd_pcm_oss snd_mixer_oss snd_intel8x0 snd_ac97_codec snd_ac97_bus snd_pcm snd_timer snd soundcore snd_page_alloc ehci_hcd uhci_hcd usbcore
> > > > > CPU:    0
> > > > > EIP:    0060:[<c016c6a4>]    Not tainted VLI
> > > > > EFLAGS: 00010286   (2.6.17-rc2-6b426e785cb81e53dc2fc4dcf997661472b470ef #1)
> > > > > EIP is at remove_proc_entry+0x2c/0x11c
> > > > > eax: 00000000   ebx: deb48b80   ecx: ffffffff   edx: de11ed24
> > > > > esi: de11ed24   edi: 6b6b6b6b   ebp: de4cb000   esp: de4cbf28
> > > > > ds: 007b   es: 007b   ss: 0068
> > > > > Process rmmod (pid: 7735, threadinfo=de4cb000 task=c1487a90)
> > > > > Stack: <0>de11ed24 6b6b6b6b deb48b80 de11ed24 bf8590cc df93603b de4f0e78 00000000
> > > > >        df965fc8 de4f0d84 df967e74 df966184 de4f0d88 df95292d df967f00 00000000
> > > > >        c0125f7a 00000000 5f646e73 5f6d6370 0073736f de85d4a4 b7f27000 c013789d
> > > > > Call Trace:
> > > > >  [<df93603b>] snd_info_unregister+0x2e/0x44 [snd]
> > > > >  [<df965fc8>] snd_pcm_oss_proc_done+0x19/0x30 [snd_pcm_oss]
> > > > >  [<df966184>] snd_pcm_oss_unregister_minor+0x3b/0x3f [snd_pcm_oss]
> > > > >  [<df95292d>] snd_pcm_notify+0x4a/0x91 [snd_pcm]
> > > > >  [<c0125f7a>] sys_delete_module+0x113/0x138
> > > > >  [<c013789d>] do_munmap+0xe2/0xef
> > > > >  [<c010259b>] syscall_call+0x7/0xb
> > > > > Code: 85 d2 56 53 51 51 89 14 24 89 44 24 04 75 13 8d 4c 24 04 89 e2 e8 dd f7 ff ff 85 c0 0f 85 f2 00 00 00 8b 7c 24 04 31 c0 83 c9 ff <f2> ae f7 d1 49 b0 01 89 ce e8 fa 13 fa ff 8b 04 24 8d 58 38 83
> > > > > EIP: [<c016c6a4>] remove_proc_entry+0x2c/0x11c SS:ESP 0068:de4cbf28
> > > > >  BUG: rmmod/7735, lock held at task exit time!
> > > > >  [df960920] {register_mutex}
> > > > > .. held by:             rmmod: 7735 [c1487a90, 118]
> > > > > ... acquired at:               snd_pcm_notify+0x10/0x91 [snd_pcm]
> > > >
> > > > Other symptoms are 6 (six) "prealloc" files, 3 "oss" files and 1 "oss"
> > > > directory (according to highlighting):
> > > >
> > > > $ ls /proc/asound/
> > > > card0  devices  modules  oss  oss  prealloc  prealloc  prealloc  timers
> > > > 			      ^^^
> > > > 			      directory
> > > >
> > > > cards  ICH5     oss      oss  pcm  prealloc  prealloc  prealloc  version
> > > >
> > > > "ls -l" thinks all 4 "oss" files are files (again, according to
> > > > highlighting).
> > >
> > > That's odd.  It implies that the proc file paths are flatten.
> >
> > But, not all entries seem flatten (e.g. pcm0p, sub0, etc).
> > Could you show the output of "tree /proc/asound" ?
> 
> 2.6.16 (good)			2.6.17-rc2-whatever (bad)
> ---------------------------------------------------------
> /proc/asound/			/proc/asound/
> |-- ICH5 -> card0		|-- ICH5 -> card0
> |-- card0			|-- card0
> |   |-- codec97#0		|   |-- codec97#0
> |   |   |-- ac97#0-0		|   |   |-- ac97#0-0
> |   |   `-- ac97#0-0+regs	|   |   `-- ac97#0-0+regs
> |   |-- id			|   |-- id
> |   |-- intel8x0		|   |-- intel8x0
> |   |-- oss_mixer		|   `-- oss_mixer
> |   |-- pcm0c			|-- cards
> |   |   |-- info		|-- devices
> |   |   |-- oss			|-- modules
> |   |   `-- sub0		|-- oss
> |   |       |-- hw_params	|-- oss
> |   |       |-- info		|-- oss
> |   |       |-- prealloc	|-- oss
> |   |       |-- status		|-- pcm
> |   |       `-- sw_params	|-- prealloc
> |   |-- pcm0p			|-- prealloc
> |   |   |-- info		|-- prealloc
> |   |   |-- oss			|-- prealloc
> |   |   `-- sub0		|-- prealloc
> |   |       |-- hw_params	|-- prealloc
> |   |       |-- info		|-- timers
> |   |       |-- prealloc	`-- version
> |   |       |-- status
> |   |       `-- sw_params	3 directories, 21 files
> |   |-- pcm1c
> |   |   |-- info
> |   |   |-- oss
> |   |   `-- sub0
> |   |       |-- hw_params
> |   |       |-- info
> |   |       |-- prealloc
> |   |       |-- status
> |   |       `-- sw_params
> |   |-- pcm2c
> |   |   |-- info
> |   |   `-- sub0
> |   |       |-- hw_params
> |   |       |-- info
> |   |       |-- prealloc
> |   |       |-- status
> |   |       `-- sw_params
> |   |-- pcm3c
> |   |   |-- info
> |   |   `-- sub0
> |   |       |-- hw_params
> |   |       |-- info
> |   |       |-- prealloc
> |   |       |-- status
> |   |       `-- sw_params
> |   `-- pcm4p
> |       |-- info
> |       `-- sub0
> |           |-- hw_params
> |           |-- info
> |           |-- prealloc
> |           |-- status
> |           `-- sw_params
> |-- cards
> |-- devices
> |-- modules
> |-- oss
> |   |-- devices
> |   `-- sndstat
> |-- pcm
> |-- timers
> `-- version
> 
> 16 directories, 52 files

Thanks.  I think I got the culprit.  It's a patch introducing
CONFIG_SND_VERBOSE_PROCFS option.

Try the patch below.


Takashi

diff --git a/include/sound/pcm.h b/include/sound/pcm.h
index df70e75..9796bc0 100644
--- a/include/sound/pcm.h
+++ b/include/sound/pcm.h
@@ -374,12 +374,14 @@ struct snd_pcm_substream {
 	/* -- OSS things -- */
 	struct snd_pcm_oss_substream oss;
 #endif
+#ifdef CONFIG_SND_VERBOSE_PROCFS
 	struct snd_info_entry *proc_root;
 	struct snd_info_entry *proc_info_entry;
 	struct snd_info_entry *proc_hw_params_entry;
 	struct snd_info_entry *proc_sw_params_entry;
 	struct snd_info_entry *proc_status_entry;
 	struct snd_info_entry *proc_prealloc_entry;
+#endif
 	/* misc flags */
 	unsigned int no_mmap_ctrl: 1;
 	unsigned int hw_opened: 1;
@@ -400,12 +402,14 @@ struct snd_pcm_str {
 	struct snd_pcm_oss_stream oss;
 #endif
 	struct snd_pcm_file *files;
+#ifdef CONFIG_SND_VERBOSE_PROCFS
 	struct snd_info_entry *proc_root;
 	struct snd_info_entry *proc_info_entry;
 #ifdef CONFIG_SND_DEBUG
 	unsigned int xrun_debug;	/* 0 = disabled, 1 = verbose, 2 = stacktrace */
 	struct snd_info_entry *proc_xrun_debug_entry;
 #endif
+#endif
 };
 
 struct snd_pcm {
diff --git a/include/sound/pcm_oss.h b/include/sound/pcm_oss.h
index 39df2ba..c854647 100644
--- a/include/sound/pcm_oss.h
+++ b/include/sound/pcm_oss.h
@@ -75,7 +75,9 @@ struct snd_pcm_oss_substream {
 struct snd_pcm_oss_stream {
 	struct snd_pcm_oss_setup *setup_list;	/* setup list */
 	struct mutex setup_mutex;
+#ifdef CONFIG_SND_VERBOSE_PROCFS
 	struct snd_info_entry *proc_entry;
+#endif
 };
 
 struct snd_pcm_oss {
diff --git a/sound/core/Kconfig b/sound/core/Kconfig
index 8efc1b1..44015a8 100644
--- a/sound/core/Kconfig
+++ b/sound/core/Kconfig
@@ -142,7 +142,7 @@ config SND_SUPPORT_OLD_API
 
 config SND_VERBOSE_PROCFS
 	bool "Verbose procfs contents"
-	depends on SND
+	depends on SND && PROC_FS
 	default y
 	help
 	  Say Y here to include code for verbose procfs contents (provides
diff --git a/sound/core/oss/pcm_oss.c b/sound/core/oss/pcm_oss.c
index c5978d6..817b727 100644
--- a/sound/core/oss/pcm_oss.c
+++ b/sound/core/oss/pcm_oss.c
@@ -2212,7 +2212,7 @@ static int snd_pcm_oss_mmap(struct file 
 	return 0;
 }
 
-#ifdef CONFIG_PROC_FS
+#ifdef CONFIG_SND_VERBOSE_PROCFS
 /*
  *  /proc interface
  */
@@ -2366,10 +2366,10 @@ static void snd_pcm_oss_proc_done(struct
 		}
 	}
 }
-#else /* !CONFIG_PROC_FS */
+#else /* !CONFIG_SND_VERBOSE_PROCFS */
 #define snd_pcm_oss_proc_init(pcm)
 #define snd_pcm_oss_proc_done(pcm)
-#endif /* CONFIG_PROC_FS */
+#endif /* CONFIG_SND_VERBOSE_PROCFS */
 
 /*
  *  ENTRY functions
diff --git a/sound/core/pcm.c b/sound/core/pcm.c
index 122e10a..d8c6d7f 100644
--- a/sound/core/pcm.c
+++ b/sound/core/pcm.c
@@ -142,7 +142,7 @@ static int snd_pcm_control_ioctl(struct 
 	return -ENOIOCTLCMD;
 }
 
-#if defined(CONFIG_PROC_FS) && defined(CONFIG_SND_VERBOSE_PROCFS)
+#ifdef CONFIG_SND_VERBOSE_PROCFS
 
 #define STATE(v) [SNDRV_PCM_STATE_##v] = #v
 #define STREAM(v) [SNDRV_PCM_STREAM_##v] = #v
@@ -599,12 +599,12 @@ static int snd_pcm_substream_proc_done(s
 	}
 	return 0;
 }
-#else /* !CONFIG_PROC_FS */
+#else /* !CONFIG_SND_VERBOSE_PROCFS */
 static inline int snd_pcm_stream_proc_init(struct snd_pcm_str *pstr) { return 0; }
 static inline int snd_pcm_stream_proc_done(struct snd_pcm_str *pstr) { return 0; }
 static inline int snd_pcm_substream_proc_init(struct snd_pcm_substream *substream) { return 0; }
 static inline int snd_pcm_substream_proc_done(struct snd_pcm_substream *substream) { return 0; }
-#endif /* CONFIG_PROC_FS */
+#endif /* CONFIG_SND_VERBOSE_PROCFS */
 
 /**
  * snd_pcm_new_stream - create a new PCM stream
diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c
index 230a940..91fe5d0 100644
--- a/sound/core/pcm_lib.c
+++ b/sound/core/pcm_lib.c
@@ -130,7 +130,7 @@ void snd_pcm_playback_silence(struct snd
 static void xrun(struct snd_pcm_substream *substream)
 {
 	snd_pcm_stop(substream, SNDRV_PCM_STATE_XRUN);
-#ifdef CONFIG_SND_DEBUG
+#if defined(CONFIG_SND_DEBUG) && defined(CONFIG_SND_VERBOSE_PROCFS)
 	if (substream->pstr->xrun_debug) {
 		snd_printd(KERN_DEBUG "XRUN: pcmC%dD%d%c\n",
 			   substream->pcm->card->number,
@@ -204,7 +204,7 @@ static inline int snd_pcm_update_hw_ptr_
 	delta = hw_ptr_interrupt - new_hw_ptr;
 	if (delta > 0) {
 		if ((snd_pcm_uframes_t)delta < runtime->buffer_size / 2) {
-#ifdef CONFIG_SND_DEBUG
+#if defined(CONFIG_SND_DEBUG) && defined(CONFIG_SND_VERBOSE_PROCFS)
 			if (runtime->periods > 1 && substream->pstr->xrun_debug) {
 				snd_printd(KERN_ERR "Unexpected hw_pointer value [1] (stream = %i, delta: -%ld, max jitter = %ld): wrong interrupt acknowledge?\n", substream->stream, (long) delta, runtime->buffer_size / 2);
 				if (substream->pstr->xrun_debug > 1)
@@ -249,7 +249,7 @@ int snd_pcm_update_hw_ptr(struct snd_pcm
 	delta = old_hw_ptr - new_hw_ptr;
 	if (delta > 0) {
 		if ((snd_pcm_uframes_t)delta < runtime->buffer_size / 2) {
-#ifdef CONFIG_SND_DEBUG
+#if defined(CONFIG_SND_DEBUG) && defined(CONFIG_SND_VERBOSE_PROCFS)
 			if (runtime->periods > 2 && substream->pstr->xrun_debug) {
 				snd_printd(KERN_ERR "Unexpected hw_pointer value [2] (stream = %i, delta: -%ld, max jitter = %ld): wrong interrupt acknowledge?\n", substream->stream, (long) delta, runtime->buffer_size / 2);
 				if (substream->pstr->xrun_debug > 1)
diff --git a/sound/core/pcm_memory.c b/sound/core/pcm_memory.c
index a0119ae..428f8c1 100644
--- a/sound/core/pcm_memory.c
+++ b/sound/core/pcm_memory.c
@@ -100,8 +100,10 @@ static void snd_pcm_lib_preallocate_dma_
 int snd_pcm_lib_preallocate_free(struct snd_pcm_substream *substream)
 {
 	snd_pcm_lib_preallocate_dma_free(substream);
+#ifdef CONFIG_SND_VERBOSE_PROCFS
 	snd_info_unregister(substream->proc_prealloc_entry);
 	substream->proc_prealloc_entry = NULL;
+#endif
 	return 0;
 }
 
@@ -124,7 +126,7 @@ int snd_pcm_lib_preallocate_free_for_all
 	return 0;
 }
 
-#ifdef CONFIG_PROC_FS
+#ifdef CONFIG_SND_VERBOSE_PROCFS
 /*
  * read callback for prealloc proc file
  *
@@ -203,9 +205,9 @@ static inline void preallocate_info_init
 	substream->proc_prealloc_entry = entry;
 }
 
-#else /* !CONFIG_PROC_FS */
+#else /* !CONFIG_SND_VERBOSE_PROCFS */
 #define preallocate_info_init(s)
-#endif
+#endif /* CONFIG_SND_VERBOSE_PROCFS */
 
 /*
  * pre-allocate the buffer and create a proc file for the substream

^ permalink raw reply related	[flat|nested] 23+ messages in thread

* Re: Re: ALSA regression: oops on shutdown
  2006-04-24 16:34                   ` [Alsa-devel] " Takashi Iwai
  (?)
  (?)
@ 2006-04-24 18:42                   ` Alexey Dobriyan
  -1 siblings, 0 replies; 23+ messages in thread
From: Alexey Dobriyan @ 2006-04-24 18:42 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: Lee Revell, Andrew Morton, linux-kernel, perex, alsa-devel

On Mon, Apr 24, 2006 at 06:34:45PM +0200, Takashi Iwai wrote:
> Thanks.  I think I got the culprit.  It's a patch introducing
> CONFIG_SND_VERBOSE_PROCFS option.
>
> Try the patch below.

Seems to work fine, thanks.

> --- a/include/sound/pcm.h
> +++ b/include/sound/pcm.h
> @@ -374,12 +374,14 @@ struct snd_pcm_substream {
>  	/* -- OSS things -- */
>  	struct snd_pcm_oss_substream oss;
>  #endif
> +#ifdef CONFIG_SND_VERBOSE_PROCFS
>  	struct snd_info_entry *proc_root;
>  	struct snd_info_entry *proc_info_entry;
>  	struct snd_info_entry *proc_hw_params_entry;
>  	struct snd_info_entry *proc_sw_params_entry;
>  	struct snd_info_entry *proc_status_entry;
>  	struct snd_info_entry *proc_prealloc_entry;
> +#endif
>  	/* misc flags */
>  	unsigned int no_mmap_ctrl: 1;
>  	unsigned int hw_opened: 1;
> @@ -400,12 +402,14 @@ struct snd_pcm_str {
>  	struct snd_pcm_oss_stream oss;
>  #endif
>  	struct snd_pcm_file *files;
> +#ifdef CONFIG_SND_VERBOSE_PROCFS
>  	struct snd_info_entry *proc_root;
>  	struct snd_info_entry *proc_info_entry;
>  #ifdef CONFIG_SND_DEBUG
>  	unsigned int xrun_debug;	/* 0 = disabled, 1 = verbose, 2 = stacktrace */
>  	struct snd_info_entry *proc_xrun_debug_entry;
>  #endif
> +#endif
>  };
>  
>  struct snd_pcm {
> diff --git a/include/sound/pcm_oss.h b/include/sound/pcm_oss.h
> index 39df2ba..c854647 100644
> --- a/include/sound/pcm_oss.h
> +++ b/include/sound/pcm_oss.h
> @@ -75,7 +75,9 @@ struct snd_pcm_oss_substream {
>  struct snd_pcm_oss_stream {
>  	struct snd_pcm_oss_setup *setup_list;	/* setup list */
>  	struct mutex setup_mutex;
> +#ifdef CONFIG_SND_VERBOSE_PROCFS
>  	struct snd_info_entry *proc_entry;
> +#endif
>  };
>  
>  struct snd_pcm_oss {
> diff --git a/sound/core/Kconfig b/sound/core/Kconfig
> index 8efc1b1..44015a8 100644
> --- a/sound/core/Kconfig
> +++ b/sound/core/Kconfig
> @@ -142,7 +142,7 @@ config SND_SUPPORT_OLD_API
>  
>  config SND_VERBOSE_PROCFS
>  	bool "Verbose procfs contents"
> -	depends on SND
> +	depends on SND && PROC_FS
>  	default y
>  	help
>  	  Say Y here to include code for verbose procfs contents (provides
> diff --git a/sound/core/oss/pcm_oss.c b/sound/core/oss/pcm_oss.c
> index c5978d6..817b727 100644
> --- a/sound/core/oss/pcm_oss.c
> +++ b/sound/core/oss/pcm_oss.c
> @@ -2212,7 +2212,7 @@ static int snd_pcm_oss_mmap(struct file 
>  	return 0;
>  }
>  
> -#ifdef CONFIG_PROC_FS
> +#ifdef CONFIG_SND_VERBOSE_PROCFS
>  /*
>   *  /proc interface
>   */
> @@ -2366,10 +2366,10 @@ static void snd_pcm_oss_proc_done(struct
>  		}
>  	}
>  }
> -#else /* !CONFIG_PROC_FS */
> +#else /* !CONFIG_SND_VERBOSE_PROCFS */
>  #define snd_pcm_oss_proc_init(pcm)
>  #define snd_pcm_oss_proc_done(pcm)
> -#endif /* CONFIG_PROC_FS */
> +#endif /* CONFIG_SND_VERBOSE_PROCFS */
>  
>  /*
>   *  ENTRY functions
> diff --git a/sound/core/pcm.c b/sound/core/pcm.c
> index 122e10a..d8c6d7f 100644
> --- a/sound/core/pcm.c
> +++ b/sound/core/pcm.c
> @@ -142,7 +142,7 @@ static int snd_pcm_control_ioctl(struct 
>  	return -ENOIOCTLCMD;
>  }
>  
> -#if defined(CONFIG_PROC_FS) && defined(CONFIG_SND_VERBOSE_PROCFS)
> +#ifdef CONFIG_SND_VERBOSE_PROCFS
>  
>  #define STATE(v) [SNDRV_PCM_STATE_##v] = #v
>  #define STREAM(v) [SNDRV_PCM_STREAM_##v] = #v
> @@ -599,12 +599,12 @@ static int snd_pcm_substream_proc_done(s
>  	}
>  	return 0;
>  }
> -#else /* !CONFIG_PROC_FS */
> +#else /* !CONFIG_SND_VERBOSE_PROCFS */
>  static inline int snd_pcm_stream_proc_init(struct snd_pcm_str *pstr) { return 0; }
>  static inline int snd_pcm_stream_proc_done(struct snd_pcm_str *pstr) { return 0; }
>  static inline int snd_pcm_substream_proc_init(struct snd_pcm_substream *substream) { return 0; }
>  static inline int snd_pcm_substream_proc_done(struct snd_pcm_substream *substream) { return 0; }
> -#endif /* CONFIG_PROC_FS */
> +#endif /* CONFIG_SND_VERBOSE_PROCFS */
>  
>  /**
>   * snd_pcm_new_stream - create a new PCM stream
> diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c
> index 230a940..91fe5d0 100644
> --- a/sound/core/pcm_lib.c
> +++ b/sound/core/pcm_lib.c
> @@ -130,7 +130,7 @@ void snd_pcm_playback_silence(struct snd
>  static void xrun(struct snd_pcm_substream *substream)
>  {
>  	snd_pcm_stop(substream, SNDRV_PCM_STATE_XRUN);
> -#ifdef CONFIG_SND_DEBUG
> +#if defined(CONFIG_SND_DEBUG) && defined(CONFIG_SND_VERBOSE_PROCFS)
>  	if (substream->pstr->xrun_debug) {
>  		snd_printd(KERN_DEBUG "XRUN: pcmC%dD%d%c\n",
>  			   substream->pcm->card->number,
> @@ -204,7 +204,7 @@ static inline int snd_pcm_update_hw_ptr_
>  	delta = hw_ptr_interrupt - new_hw_ptr;
>  	if (delta > 0) {
>  		if ((snd_pcm_uframes_t)delta < runtime->buffer_size / 2) {
> -#ifdef CONFIG_SND_DEBUG
> +#if defined(CONFIG_SND_DEBUG) && defined(CONFIG_SND_VERBOSE_PROCFS)
>  			if (runtime->periods > 1 && substream->pstr->xrun_debug) {
>  				snd_printd(KERN_ERR "Unexpected hw_pointer value [1] (stream = %i, delta: -%ld, max jitter = %ld): wrong interrupt acknowledge?\n", substream->stream, (long) delta, runtime->buffer_size / 2);
>  				if (substream->pstr->xrun_debug > 1)
> @@ -249,7 +249,7 @@ int snd_pcm_update_hw_ptr(struct snd_pcm
>  	delta = old_hw_ptr - new_hw_ptr;
>  	if (delta > 0) {
>  		if ((snd_pcm_uframes_t)delta < runtime->buffer_size / 2) {
> -#ifdef CONFIG_SND_DEBUG
> +#if defined(CONFIG_SND_DEBUG) && defined(CONFIG_SND_VERBOSE_PROCFS)
>  			if (runtime->periods > 2 && substream->pstr->xrun_debug) {
>  				snd_printd(KERN_ERR "Unexpected hw_pointer value [2] (stream = %i, delta: -%ld, max jitter = %ld): wrong interrupt acknowledge?\n", substream->stream, (long) delta, runtime->buffer_size / 2);
>  				if (substream->pstr->xrun_debug > 1)
> diff --git a/sound/core/pcm_memory.c b/sound/core/pcm_memory.c
> index a0119ae..428f8c1 100644
> --- a/sound/core/pcm_memory.c
> +++ b/sound/core/pcm_memory.c
> @@ -100,8 +100,10 @@ static void snd_pcm_lib_preallocate_dma_
>  int snd_pcm_lib_preallocate_free(struct snd_pcm_substream *substream)
>  {
>  	snd_pcm_lib_preallocate_dma_free(substream);
> +#ifdef CONFIG_SND_VERBOSE_PROCFS
>  	snd_info_unregister(substream->proc_prealloc_entry);
>  	substream->proc_prealloc_entry = NULL;
> +#endif
>  	return 0;
>  }
>  
> @@ -124,7 +126,7 @@ int snd_pcm_lib_preallocate_free_for_all
>  	return 0;
>  }
>  
> -#ifdef CONFIG_PROC_FS
> +#ifdef CONFIG_SND_VERBOSE_PROCFS
>  /*
>   * read callback for prealloc proc file
>   *
> @@ -203,9 +205,9 @@ static inline void preallocate_info_init
>  	substream->proc_prealloc_entry = entry;
>  }
>  
> -#else /* !CONFIG_PROC_FS */
> +#else /* !CONFIG_SND_VERBOSE_PROCFS */
>  #define preallocate_info_init(s)
> -#endif
> +#endif /* CONFIG_SND_VERBOSE_PROCFS */
>  
>  /*
>   * pre-allocate the buffer and create a proc file for the substream



-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [Alsa-devel] Re: ALSA regression: oops on shutdown
  2006-04-24 16:34                   ` [Alsa-devel] " Takashi Iwai
  (?)
@ 2006-04-24 18:42                   ` Alexey Dobriyan
  -1 siblings, 0 replies; 23+ messages in thread
From: Alexey Dobriyan @ 2006-04-24 18:42 UTC (permalink / raw)
  To: Takashi Iwai; +Cc: Lee Revell, Andrew Morton, linux-kernel, perex, alsa-devel

On Mon, Apr 24, 2006 at 06:34:45PM +0200, Takashi Iwai wrote:
> Thanks.  I think I got the culprit.  It's a patch introducing
> CONFIG_SND_VERBOSE_PROCFS option.
>
> Try the patch below.

Seems to work fine, thanks.

> --- a/include/sound/pcm.h
> +++ b/include/sound/pcm.h
> @@ -374,12 +374,14 @@ struct snd_pcm_substream {
>  	/* -- OSS things -- */
>  	struct snd_pcm_oss_substream oss;
>  #endif
> +#ifdef CONFIG_SND_VERBOSE_PROCFS
>  	struct snd_info_entry *proc_root;
>  	struct snd_info_entry *proc_info_entry;
>  	struct snd_info_entry *proc_hw_params_entry;
>  	struct snd_info_entry *proc_sw_params_entry;
>  	struct snd_info_entry *proc_status_entry;
>  	struct snd_info_entry *proc_prealloc_entry;
> +#endif
>  	/* misc flags */
>  	unsigned int no_mmap_ctrl: 1;
>  	unsigned int hw_opened: 1;
> @@ -400,12 +402,14 @@ struct snd_pcm_str {
>  	struct snd_pcm_oss_stream oss;
>  #endif
>  	struct snd_pcm_file *files;
> +#ifdef CONFIG_SND_VERBOSE_PROCFS
>  	struct snd_info_entry *proc_root;
>  	struct snd_info_entry *proc_info_entry;
>  #ifdef CONFIG_SND_DEBUG
>  	unsigned int xrun_debug;	/* 0 = disabled, 1 = verbose, 2 = stacktrace */
>  	struct snd_info_entry *proc_xrun_debug_entry;
>  #endif
> +#endif
>  };
>  
>  struct snd_pcm {
> diff --git a/include/sound/pcm_oss.h b/include/sound/pcm_oss.h
> index 39df2ba..c854647 100644
> --- a/include/sound/pcm_oss.h
> +++ b/include/sound/pcm_oss.h
> @@ -75,7 +75,9 @@ struct snd_pcm_oss_substream {
>  struct snd_pcm_oss_stream {
>  	struct snd_pcm_oss_setup *setup_list;	/* setup list */
>  	struct mutex setup_mutex;
> +#ifdef CONFIG_SND_VERBOSE_PROCFS
>  	struct snd_info_entry *proc_entry;
> +#endif
>  };
>  
>  struct snd_pcm_oss {
> diff --git a/sound/core/Kconfig b/sound/core/Kconfig
> index 8efc1b1..44015a8 100644
> --- a/sound/core/Kconfig
> +++ b/sound/core/Kconfig
> @@ -142,7 +142,7 @@ config SND_SUPPORT_OLD_API
>  
>  config SND_VERBOSE_PROCFS
>  	bool "Verbose procfs contents"
> -	depends on SND
> +	depends on SND && PROC_FS
>  	default y
>  	help
>  	  Say Y here to include code for verbose procfs contents (provides
> diff --git a/sound/core/oss/pcm_oss.c b/sound/core/oss/pcm_oss.c
> index c5978d6..817b727 100644
> --- a/sound/core/oss/pcm_oss.c
> +++ b/sound/core/oss/pcm_oss.c
> @@ -2212,7 +2212,7 @@ static int snd_pcm_oss_mmap(struct file 
>  	return 0;
>  }
>  
> -#ifdef CONFIG_PROC_FS
> +#ifdef CONFIG_SND_VERBOSE_PROCFS
>  /*
>   *  /proc interface
>   */
> @@ -2366,10 +2366,10 @@ static void snd_pcm_oss_proc_done(struct
>  		}
>  	}
>  }
> -#else /* !CONFIG_PROC_FS */
> +#else /* !CONFIG_SND_VERBOSE_PROCFS */
>  #define snd_pcm_oss_proc_init(pcm)
>  #define snd_pcm_oss_proc_done(pcm)
> -#endif /* CONFIG_PROC_FS */
> +#endif /* CONFIG_SND_VERBOSE_PROCFS */
>  
>  /*
>   *  ENTRY functions
> diff --git a/sound/core/pcm.c b/sound/core/pcm.c
> index 122e10a..d8c6d7f 100644
> --- a/sound/core/pcm.c
> +++ b/sound/core/pcm.c
> @@ -142,7 +142,7 @@ static int snd_pcm_control_ioctl(struct 
>  	return -ENOIOCTLCMD;
>  }
>  
> -#if defined(CONFIG_PROC_FS) && defined(CONFIG_SND_VERBOSE_PROCFS)
> +#ifdef CONFIG_SND_VERBOSE_PROCFS
>  
>  #define STATE(v) [SNDRV_PCM_STATE_##v] = #v
>  #define STREAM(v) [SNDRV_PCM_STREAM_##v] = #v
> @@ -599,12 +599,12 @@ static int snd_pcm_substream_proc_done(s
>  	}
>  	return 0;
>  }
> -#else /* !CONFIG_PROC_FS */
> +#else /* !CONFIG_SND_VERBOSE_PROCFS */
>  static inline int snd_pcm_stream_proc_init(struct snd_pcm_str *pstr) { return 0; }
>  static inline int snd_pcm_stream_proc_done(struct snd_pcm_str *pstr) { return 0; }
>  static inline int snd_pcm_substream_proc_init(struct snd_pcm_substream *substream) { return 0; }
>  static inline int snd_pcm_substream_proc_done(struct snd_pcm_substream *substream) { return 0; }
> -#endif /* CONFIG_PROC_FS */
> +#endif /* CONFIG_SND_VERBOSE_PROCFS */
>  
>  /**
>   * snd_pcm_new_stream - create a new PCM stream
> diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c
> index 230a940..91fe5d0 100644
> --- a/sound/core/pcm_lib.c
> +++ b/sound/core/pcm_lib.c
> @@ -130,7 +130,7 @@ void snd_pcm_playback_silence(struct snd
>  static void xrun(struct snd_pcm_substream *substream)
>  {
>  	snd_pcm_stop(substream, SNDRV_PCM_STATE_XRUN);
> -#ifdef CONFIG_SND_DEBUG
> +#if defined(CONFIG_SND_DEBUG) && defined(CONFIG_SND_VERBOSE_PROCFS)
>  	if (substream->pstr->xrun_debug) {
>  		snd_printd(KERN_DEBUG "XRUN: pcmC%dD%d%c\n",
>  			   substream->pcm->card->number,
> @@ -204,7 +204,7 @@ static inline int snd_pcm_update_hw_ptr_
>  	delta = hw_ptr_interrupt - new_hw_ptr;
>  	if (delta > 0) {
>  		if ((snd_pcm_uframes_t)delta < runtime->buffer_size / 2) {
> -#ifdef CONFIG_SND_DEBUG
> +#if defined(CONFIG_SND_DEBUG) && defined(CONFIG_SND_VERBOSE_PROCFS)
>  			if (runtime->periods > 1 && substream->pstr->xrun_debug) {
>  				snd_printd(KERN_ERR "Unexpected hw_pointer value [1] (stream = %i, delta: -%ld, max jitter = %ld): wrong interrupt acknowledge?\n", substream->stream, (long) delta, runtime->buffer_size / 2);
>  				if (substream->pstr->xrun_debug > 1)
> @@ -249,7 +249,7 @@ int snd_pcm_update_hw_ptr(struct snd_pcm
>  	delta = old_hw_ptr - new_hw_ptr;
>  	if (delta > 0) {
>  		if ((snd_pcm_uframes_t)delta < runtime->buffer_size / 2) {
> -#ifdef CONFIG_SND_DEBUG
> +#if defined(CONFIG_SND_DEBUG) && defined(CONFIG_SND_VERBOSE_PROCFS)
>  			if (runtime->periods > 2 && substream->pstr->xrun_debug) {
>  				snd_printd(KERN_ERR "Unexpected hw_pointer value [2] (stream = %i, delta: -%ld, max jitter = %ld): wrong interrupt acknowledge?\n", substream->stream, (long) delta, runtime->buffer_size / 2);
>  				if (substream->pstr->xrun_debug > 1)
> diff --git a/sound/core/pcm_memory.c b/sound/core/pcm_memory.c
> index a0119ae..428f8c1 100644
> --- a/sound/core/pcm_memory.c
> +++ b/sound/core/pcm_memory.c
> @@ -100,8 +100,10 @@ static void snd_pcm_lib_preallocate_dma_
>  int snd_pcm_lib_preallocate_free(struct snd_pcm_substream *substream)
>  {
>  	snd_pcm_lib_preallocate_dma_free(substream);
> +#ifdef CONFIG_SND_VERBOSE_PROCFS
>  	snd_info_unregister(substream->proc_prealloc_entry);
>  	substream->proc_prealloc_entry = NULL;
> +#endif
>  	return 0;
>  }
>  
> @@ -124,7 +126,7 @@ int snd_pcm_lib_preallocate_free_for_all
>  	return 0;
>  }
>  
> -#ifdef CONFIG_PROC_FS
> +#ifdef CONFIG_SND_VERBOSE_PROCFS
>  /*
>   * read callback for prealloc proc file
>   *
> @@ -203,9 +205,9 @@ static inline void preallocate_info_init
>  	substream->proc_prealloc_entry = entry;
>  }
>  
> -#else /* !CONFIG_PROC_FS */
> +#else /* !CONFIG_SND_VERBOSE_PROCFS */
>  #define preallocate_info_init(s)
> -#endif
> +#endif /* CONFIG_SND_VERBOSE_PROCFS */
>  
>  /*
>   * pre-allocate the buffer and create a proc file for the substream


^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2006-04-24 18:45 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-23 23:57 ALSA regression: oops on shutdown Alexey Dobriyan
2006-04-24  1:57 ` Andrew Morton
2006-04-24  1:57   ` Andrew Morton
2006-04-24  2:37   ` Alexey Dobriyan
2006-04-24  2:37     ` Alexey Dobriyan
2006-04-24  2:39     ` [Alsa-devel] " Lee Revell
2006-04-24  3:11       ` Alexey Dobriyan
2006-04-24  3:11         ` [Alsa-devel] " Alexey Dobriyan
2006-04-24  3:51         ` Alexey Dobriyan
2006-04-24  3:51           ` [Alsa-devel] " Alexey Dobriyan
2006-04-24 13:34           ` Takashi Iwai
2006-04-24 13:34           ` [Alsa-devel] " Takashi Iwai
2006-04-24 14:26             ` Takashi Iwai
2006-04-24 15:30               ` Alexey Dobriyan
2006-04-24 16:34                 ` Takashi Iwai
2006-04-24 16:34                   ` [Alsa-devel] " Takashi Iwai
2006-04-24 18:42                   ` Alexey Dobriyan
2006-04-24 18:42                   ` Alexey Dobriyan
2006-04-24 15:30               ` Alexey Dobriyan
2006-04-24 14:26             ` Takashi Iwai
2006-04-24  2:39     ` Lee Revell
2006-04-24 13:00   ` Takashi Iwai
2006-04-24 13:00   ` [Alsa-devel] " Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.