[PATCH] add raw driver Kconfig entry for s390

[PATCH] add raw driver Kconfig entry for s390

[Olaf Hering]

From: Ihno Krumreich <ihno@suse.de>

The raw module is not enabled on s390/s390x
During SLES9 and SLES10 development IBM filed bugs about the missing raw
driver. Avoid that for SLES11 by adding it to the other char driver
entries.

Signed-off-by: Olaf Hering <olh@suse.de>

---
 drivers/s390/Kconfig |   20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

Index: linux-2.6.16/drivers/s390/Kconfig
===================================================================
--- linux-2.6.16.orig/drivers/s390/Kconfig
+++ linux-2.6.16/drivers/s390/Kconfig
@@ -51,6 +51,26 @@ config UNIX98_PTY_COUNT
 	  When not in use, each additional set of 256 PTYs occupy
 	  approximately 8 KB of kernel memory on 32-bit architectures.
 
+config RAW_DRIVER
+	tristate "RAW driver (/dev/raw/rawN) (OBSOLETE)"
+	help
+	  The raw driver permits block devices to be bound to /dev/raw/rawN.
+	  Once bound, I/O against /dev/raw/rawN uses efficient zero-copy I/O.
+	  See the raw(8) manpage for more details.
+
+          The raw driver is deprecated and may be removed from 2.7
+          kernels.  Applications should simply open the device (eg /dev/hda1)
+          with the O_DIRECT flag.
+
+config MAX_RAW_DEVS
+	int "Maximum number of RAW devices to support (1-8192)"
+	depends on RAW_DRIVER
+	default "256"
+	help
+	  The maximum number of RAW devices that are supported.
+	  Default is 256. Increase this number in case you need lots of
+	  raw devices.
+
 config HANGCHECK_TIMER
 	tristate "Hangcheck timer"
 	help

Re: [PATCH] add raw driver Kconfig entry for s390

[Christoph Hellwig]

On Sat, May 13, 2006 at 01:52:56PM +0200, Olaf Hering wrote:
> From: Ihno Krumreich <ihno@suse.de>
> 
> The raw module is not enabled on s390/s390x
> During SLES9 and SLES10 development IBM filed bugs about the missing raw
> driver. Avoid that for SLES11 by adding it to the other char driver
> entries.

The raw driver ist deptrecated amd your friends at IBM should better stop
using it ASAP.  It certainly won't survive until SLES11 is due if you
guys stick to your current release schedule.

Re: [PATCH] add raw driver Kconfig entry for s390

[Martin Schwidefsky]

On Sat, 2006-05-13 at 13:52 +0200, Olaf Hering wrote:
> From: Ihno Krumreich <ihno@suse.de>
> 
> The raw module is not enabled on s390/s390x
> During SLES9 and SLES10 development IBM filed bugs about the missing raw
> driver. Avoid that for SLES11 by adding it to the other char driver
> entries.
> 
> Signed-off-by: Olaf Hering <olh@suse.de>

NACK. The raw device driver is obsolete and we should not add it to the
s390 kconfig. I know that it is needed in SLES10 for compatability to
SLES9 but given that the option is supposed to vanish I prefer to keep
it out of the upstream tree.

-- 
blue skies,
  Martin.

Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH

"Reality continues to ruin my life." - Calvin.