libata PATA updated patch

libata PATA updated patch

[Alan Cox]

I've put a patch versus -rc4 in the usual place. This should sort out
the PIO problems and a few other glitches

Alan

http://zeniv.linux.org.uk/~alan/IDE

Re: libata PATA updated patch

[John Stoffel]

Alan> I've put a patch versus -rc4 in the usual place. This should
Alan> sort out the PIO problems and a few other glitches

Should I bother testing this on my HPT302 box?  I didn't see any
response to my earlier bug reports, just checking to make sure I'm
doing a usefull service here.

John

Re: libata PATA updated patch

[Alan Cox]

On Maw, 2006-05-16 at 15:56 -0400, John Stoffel wrote:
> Alan> I've put a patch versus -rc4 in the usual place. This should
> Alan> sort out the PIO problems and a few other glitches
> 
> Should I bother testing this on my HPT302 box?  I didn't see any
> response to my earlier bug reports, just checking to make sure I'm
> doing a usefull service here.

I've not attacked the HPT3xx hardware again yet. For one the fact that
Sergei Shtylyov is rewriting the "old style" driver for it to knock a
lot of the problems out means much of that stuff will want porting again
once he is finished

Sergei may well appreciate testers however.

Thanks for the testing so far

Alan

Re: libata PATA updated patch

[John Stoffel]

>>>>> "Alan" == Alan Cox <alan@lxorguk.ukuu.org.uk> writes:

>> Should I bother testing this on my HPT302 box?  I didn't see any
>> response to my earlier bug reports, just checking to make sure I'm
>> doing a usefull service here.

Alan> I've not attacked the HPT3xx hardware again yet. For one the
Alan> fact that Sergei Shtylyov is rewriting the "old style" driver
Alan> for it to knock a lot of the problems out means much of that
Alan> stuff will want porting again once he is finished

Thanks, I'll hold off for now then, but I'm more than happy to run
tests for you in you need them.  

Alan> Sergei may well appreciate testers however.

Alan> Thanks for the testing so far

You're very welcome!  Least I can do, not being a kernel programmer.

Re: libata PATA updated patch

[Kevin Radloff]

On 5/16/06, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> I've put a patch versus -rc4 in the usual place. This should sort out
> the PIO problems and a few other glitches
>
> Alan
>
> http://zeniv.linux.org.uk/~alan/IDE

As expected, all seems to be well on my laptop. Thanks! :)

-- 
Kevin 'radsaq' Radloff
radsaq@gmail.com
http://thesaq.com/

Re: libata PATA updated patch

[Kevin Radloff]

On 5/16/06, Kevin Radloff <radsaq@gmail.com> wrote:
> On 5/16/06, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> > I've put a patch versus -rc4 in the usual place. This should sort out
> > the PIO problems and a few other glitches
> >
> > Alan
> >
> > http://zeniv.linux.org.uk/~alan/IDE
>
> As expected, all seems to be well on my laptop. Thanks! :)

Okay, I was wrong. :( Sometimes the IDE adapter doesn't resume after
unsuspending (suspend to RAM) or something like that. Whatever is
happening the disks are inaccessible though, so it's hard to get the
exact details.

I don't really have the time/motivation to debug that sort of thing in
the middle of the work week though; I'll need to experiment more this
weekend. (And my typical setup also has the -ck kernel patch and the
madwifi drivers)

0000:00:00.0 Host bridge: Intel Corporation 82852/82855 GM/GME/PM/GMV
Processor to I/O Controller (rev 02)
0000:00:00.1 System peripheral: Intel Corporation 82852/82855
GM/GME/PM/GMV Processor to I/O Controller (rev 02)
0000:00:00.3 System peripheral: Intel Corporation 82852/82855
GM/GME/PM/GMV Processor to I/O Controller (rev 02)
0000:00:02.0 VGA compatible controller: Intel Corporation 82852/855GM
Integrated Graphics Device (rev 02)
0000:00:02.1 Display controller: Intel Corporation 82852/855GM
Integrated Graphics Device (rev 02)
0000:00:1d.0 USB Controller: Intel Corporation 82801DB/DBL/DBM
(ICH4/ICH4-L/ICH4-M) USB UHCI Controller #1 (rev 03)
0000:00:1d.1 USB Controller: Intel Corporation 82801DB/DBL/DBM
(ICH4/ICH4-L/ICH4-M) USB UHCI Controller #2 (rev 03)
0000:00:1d.7 USB Controller: Intel Corporation 82801DB/DBM
(ICH4/ICH4-M) USB2 EHCI Controller (rev 03)
0000:00:1e.0 PCI bridge: Intel Corporation 82801 Mobile PCI Bridge (rev 83)
0000:00:1f.0 ISA bridge: Intel Corporation 82801DBM (ICH4-M) LPC
Interface Bridge (rev 03)
0000:00:1f.1 IDE interface: Intel Corporation 82801DBM (ICH4-M) IDE
Controller (rev 03)
0000:00:1f.3 SMBus: Intel Corporation 82801DB/DBL/DBM
(ICH4/ICH4-L/ICH4-M) SMBus Controller (rev 03)
0000:00:1f.5 Multimedia audio controller: Intel Corporation
82801DB/DBL/DBM (ICH4/ICH4-L/ICH4-M) AC'97 Audio Controller (rev 03)
0000:00:1f.6 Modem: Intel Corporation 82801DB/DBL/DBM
(ICH4/ICH4-L/ICH4-M) AC'97 Modem Controller (rev 03)
0000:01:0a.0 CardBus bridge: Ricoh Co Ltd RL5c476 II (rev ab)
0000:01:0a.1 CardBus bridge: Ricoh Co Ltd RL5c476 II (rev ab)
0000:01:0a.2 FireWire (IEEE 1394): Ricoh Co Ltd R5C552 IEEE 1394
Controller (rev 03)
0000:01:0a.3 System peripheral: Ricoh Co Ltd R5C576 SD Bus Host Adapter (rev 01)
0000:01:0a.4 System peripheral: Ricoh Co Ltd R5C592 Memory Stick Bus
Host Adapter
0000:01:0c.0 Ethernet controller: Realtek Semiconductor Co., Ltd.
RTL-8139/8139C/8139C+ (rev 10)
0000:01:0d.0 Ethernet controller: Atheros Communications, Inc. AR5212
802.11abg NIC (rev 01)

-- 
Kevin 'radsaq' Radloff
radsaq@gmail.com
http://thesaq.com/

Re: libata PATA updated patch

[Alan Cox]

On Mer, 2006-05-17 at 08:58 -0400, Kevin Radloff wrote:
> Okay, I was wrong. :( Sometimes the IDE adapter doesn't resume after
> unsuspending (suspend to RAM) or something like that. Whatever is
> happening the disks are inaccessible though, so it's hard to get the
> exact details.

Linux does not support suspend/resume with any kind of IDE disk, PATA or
SATA. It happens to work for many cases. Full suspend/resume support is
on its way and some of it should be in 2.6.18 or so.

Re: libata PATA updated patch

[Kevin Radloff]

On 5/17/06, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> On Mer, 2006-05-17 at 08:58 -0400, Kevin Radloff wrote:
> > Okay, I was wrong. :( Sometimes the IDE adapter doesn't resume after
> > unsuspending (suspend to RAM) or something like that. Whatever is
> > happening the disks are inaccessible though, so it's hard to get the
> > exact details.
>
> Linux does not support suspend/resume with any kind of IDE disk, PATA or
> SATA. It happens to work for many cases. Full suspend/resume support is
> on its way and some of it should be in 2.6.18 or so.

Ah.. Should I not bother investigating the regression and just wait instead? :)

-- 
Kevin 'radsaq' Radloff
radsaq@gmail.com
http://thesaq.com/

Re: libata PATA updated patch

[Matthieu CASTET]

Le Tue, 16 May 2006 17:13:57 +0100, Alan Cox a écrit :

> I've put a patch versus -rc4 in the usual place. This should sort out
> the PIO problems and a few other glitches
> 
> Alan
> 
> http://zeniv.linux.org.uk/~alan/IDE
Ok the via timing are ok now.

If I had in ata_host_intr someting like [1] for checking the altstatus, my
ATAPI drive works.
It report "ata_altstatus take 3us", for driver that wasn't worked before.

I don't know if it is a correct fix and where it should be putted (in
libata-core or in the pata_via check_altstatus callback).
I don't know if it should be used only for ATA_CMD_SET_FEATURES &&
SETFEATURES_XFER.

Now real testing could begging.

Matthieu



[1]
		for (i=0; ata_altstatus(ap) & ATA_BUSY; i++) {
                        if (i > 10)
                                goto idle_irq;
                udelay(1);
                }
                if (i)
                        printk("ata_altstatus take %dus\n", i);