Re: [patch, -rc5-mm3] fix irqpoll some more

[Steven Rostedt <rostedt@goodmis.org>]

On Mon, 2006-06-05 at 10:49 +0200, Ingo Molnar wrote:

> +	/*
> +	 * HACK:
> +	 *
> +	 * In the first pass we dont touch handlers that are behind
> +	 * a disabled IRQ line. In the second pass (having no other
> +	 * choice) we ignore the disabled state of IRQ lines. We've
> +	 * got a screaming interrupt, so we have the choice between
> +	 * a real lockup happening due to that screaming interrupt,
> +	 * against a theoretical locking that becomes possible if we
> +	 * ignore a disabled IRQ line.

FYI,  with irqpoll on in my i386 SMP machine, I hit this theoretical
locking every time in the vortex driver.

-- Steve

> +	 *
> +	 * FIXME: proper disable_irq_handler() API would remove the
> +	 * need for this hack.
> +	 */
> +	if (!ok && first_pass) {
> +		first_pass = 0;
> +		goto repeat;
> +	}
> +
>  	/* So the caller can adjust the irq error counts */
>  	return ok;
>  }